2024-03-07 11:33:46

by Naresh Solanki

[permalink] [raw]
Subject: [PATCH v4] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

tda38640 has a single regulator output along with CAT_FAULT# pin to
report internal events. Hence add properties for regulator & interrupt.

Signed-off-by: Naresh Solanki <[email protected]>

---
Changes in V4:
1. Update commit message.

Changes in V3:
1. Update regulator node from vout0 to vout.

Changes in V2:
1. Remove TEST=..
2. Update regulator subnode property as vout0
3. Restore commented line in example
4. blank line after interrupts property in example.
---
.../hwmon/pmbus/infineon,tda38640.yaml | 28 +++++++++++++++++++
1 file changed, 28 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml
index ded1c115764b..5c4e52b472ad 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38640.yaml
@@ -30,6 +30,23 @@ properties:
unconnected(has internal pull-down).
type: boolean

+ interrupts:
+ maxItems: 1
+
+ regulators:
+ type: object
+ description:
+ list of regulators provided by this controller.
+
+ properties:
+ vout:
+ $ref: /schemas/regulator/regulator.yaml#
+ type: object
+
+ unevaluatedProperties: false
+
+ additionalProperties: false
+
required:
- compatible
- reg
@@ -38,6 +55,7 @@ additionalProperties: false

examples:
- |
+ #include <dt-bindings/interrupt-controller/irq.h>
i2c {
#address-cells = <1>;
#size-cells = <0>;
@@ -45,5 +63,15 @@ examples:
tda38640@40 {
compatible = "infineon,tda38640";
reg = <0x40>;
+
+ interrupt-parent = <&smb_pex_cpu0_event>;
+ interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
+
+ regulators {
+ pvnn_main_cpu0: vout {
+ regulator-name = "pvnn_main_cpu0";
+ regulator-enable-ramp-delay = <200>;
+ };
+ };
};
};

base-commit: 78cc80d834ed3b792605bc9c2215ed9e63825459
--
2.42.0



2024-03-07 18:13:23

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v4] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

On Thu, Mar 07, 2024 at 05:03:24PM +0530, Naresh Solanki wrote:
> tda38640 has a single regulator output along with CAT_FAULT# pin to
> report internal events. Hence add properties for regulator & interrupt.
>
> Signed-off-by: Naresh Solanki <[email protected]>

Acked-by: Conor Dooley <[email protected]>

thanks,
Conor.


Attachments:
(No filename) (353.00 B)
signature.asc (235.00 B)
Download all attachments

2024-03-07 18:42:26

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v4] dt-bindings: hwmon: tda38640: Add interrupt & regulator properties

On Thu, Mar 07, 2024 at 05:03:24PM +0530, Naresh Solanki wrote:
> tda38640 has a single regulator output along with CAT_FAULT# pin to
> report internal events. Hence add properties for regulator & interrupt.
>
> Signed-off-by: Naresh Solanki <[email protected]>
> Acked-by: Conor Dooley <[email protected]>

Applied.

Thanks,
Guenter