2020-05-10 20:08:23

by Kangmin Park

Subject: [PATCH] docs/devicetree: mailbox: fix trivial typo

From: Kangmin Park <[email protected]>

Fix node id typo in example

Signed-off-by: Kangmin Park <[email protected]>
---
Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
index 4438432..ad76edc 100644
--- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
+++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
@@ -87,7 +87,7 @@ Example:
ranges;

/* APU<->RPU0 IPI mailbox controller */
- ipi_mailbox_rpu0: mailbox@ff90400 {
+ ipi_mailbox_rpu0: mailbox@ff990400 {
reg = <0xff990400 0x20>,
<0xff990420 0x20>,
<0xff990080 0x20>,
--
2.7.4

2020-05-11 07:03:33

by Michal Simek

Subject: Re: [PATCH] docs/devicetree: mailbox: fix trivial typo

On 10. 05. 20 21:38, [email protected] wrote:
> From: Kangmin Park <[email protected]>
>
> Fix node id typo in example

I think it is more than typo. It is incorrect unit-address which doesn't
match the first address specified in the reg property of the node.

Here is line from dt binding spec.
"The unit-address must match the first address specified in the
reg property of the node."



>
> Signed-off-by: Kangmin Park <[email protected]>

IIRC subject should start with dt-bindings:


> ---
> Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> index 4438432..ad76edc 100644
> --- a/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> +++ b/Documentation/devicetree/bindings/mailbox/xlnx,zynqmp-ipi-mailbox.txt
> @@ -87,7 +87,7 @@ Example:
> ranges;
>
> /* APU<->RPU0 IPI mailbox controller */
> - ipi_mailbox_rpu0: mailbox@ff90400 {
> + ipi_mailbox_rpu0: mailbox@ff990400 {
> reg = <0xff990400 0x20>,
> <0xff990420 0x20>,
> <0xff990080 0x20>,
>

Change is correct.

With nits above applied please add my
Acked-by: Michal Simek <[email protected]>

Thanks,
Michal