2018-04-24 08:27:34

by Arvind Yadav

Subject: [PATCH] HID: wacom: Release device resource data obtained by devres_alloc()

Free device resource data, if __wacom_devm_sysfs_create_group
is not successful.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/hid/wacom_sys.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index b54ef1f..ee7a37e 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1213,8 +1213,10 @@ static int __wacom_devm_sysfs_create_group(struct wacom *wacom,
devres->root = root;

error = sysfs_create_group(devres->root, group);
- if (error)
+ if (error) {
+ devres_free(devres);
return error;
+ }

devres_add(&wacom->hdev->dev, devres);

--
1.9.1

2018-04-24 09:24:16

by Benjamin Tissoires

Subject: Re: [PATCH] HID: wacom: Release device resource data obtained by devres_alloc()

On Tue, Apr 24, 2018 at 10:03 AM, Arvind Yadav
<[email protected]> wrote:
> Free device resource data, if __wacom_devm_sysfs_create_group
> is not successful.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---

Looks good to me:
Reviewed-by: Benjamin Tissoires <[email protected]>

Cheers,
Benjamin

> drivers/hid/wacom_sys.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index b54ef1f..ee7a37e 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1213,8 +1213,10 @@ static int __wacom_devm_sysfs_create_group(struct wacom *wacom,
> devres->root = root;
>
> error = sysfs_create_group(devres->root, group);
> - if (error)
> + if (error) {
> + devres_free(devres);
> return error;
> + }
>
> devres_add(&wacom->hdev->dev, devres);
>
> --
> 1.9.1
>

2018-04-25 08:52:58

by Jiri Kosina

Subject: Re: [PATCH] HID: wacom: Release device resource data obtained by devres_alloc()

On Tue, 24 Apr 2018, Arvind Yadav wrote:

> Free device resource data, if __wacom_devm_sysfs_create_group
> is not successful.

Applied, thanks.

--
Jiri Kosina
SUSE Labs