2024-04-19 18:14:45

by Ashok Kumar

Subject: [PATCH] staging:fbtft:fb_ili9320 Removed redundant Parentheses

From 51e98164e314a2d1d834d2a9baea21a9823650bb Mon Sep 17 00:00:00 2001
From: Ashok Kumar <[email protected]>
Date: Fri, 19 Apr 2024 10:32:48 -0700
Subject: [PATCH] staging:fbtft:fb_ili9320 Removed redundant
Parentheses

Adhere to Linux kernel coding style.
Reported by checkpatch

CHECK: Unnecessary parentheses around 'devcode != 0x0000'
+ if ((devcode != 0x0000) && (devcode != 0x9320))

Signed-off-by: Ashok Kumar <[email protected]>
---
drivers/staging/fbtft/fb_ili9320.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_ili9320.c
b/drivers/staging/fbtft/fb_ili9320.c
index 0be7c2d51548..409b54cc562e 100644
--- a/drivers/staging/fbtft/fb_ili9320.c
+++ b/drivers/staging/fbtft/fb_ili9320.c
@@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par)
devcode = read_devicecode(par);
fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code:
0x%04X\n",
devcode);
- if ((devcode != 0x0000) && (devcode != 0x9320))
+ if (devcode != 0x0000 && devcode != 0x9320)
dev_warn(par->info->device,
"Unrecognized Device code: 0x%04X (expected
0x9320)\n",
devcode);
--
2.34.1

2024-04-22 13:31:39

by Dan Carpenter

Subject: Re: [PATCH] staging:fbtft:fb_ili9320 Removed redundant Parentheses

0) Fix your From address.

1) Look at how other people write subjects.
git log --oneline drivers/staging/fbtft/fb_ili9320.c

On Fri, Apr 19, 2024 at 11:04:21AM -0700, A wrote:
> >From 51e98164e314a2d1d834d2a9baea21a9823650bb Mon Sep 17 00:00:00 2001
> From: Ashok Kumar <[email protected]>
> Date: Fri, 19 Apr 2024 10:32:48 -0700
> Subject: [PATCH] staging:fbtft:fb_ili9320 Removed redundant
> Parentheses

2) This should not be part of the email.

>
> Adhere to Linux kernel coding style.
> Reported by checkpatch
>
> CHECK: Unnecessary parentheses around 'devcode != 0x0000'
> + if ((devcode != 0x0000) && (devcode != 0x9320))
>

3) Just leave this as-is. Ignore checkpatch in this case. Greg likes
parens.

> Signed-off-by: Ashok Kumar <[email protected]>
> ---
> drivers/staging/fbtft/fb_ili9320.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_ili9320.c
> b/drivers/staging/fbtft/fb_ili9320.c
> index 0be7c2d51548..409b54cc562e 100644
> --- a/drivers/staging/fbtft/fb_ili9320.c
> +++ b/drivers/staging/fbtft/fb_ili9320.c
> @@ -37,7 +37,7 @@ static int init_display(struct fbtft_par *par)
> devcode = read_devicecode(par);
> fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code:
> 0x%04X\n",

4) This patch is corrupt and will not apply. Read the first two
paragraphs of Documentation/process/email-clients.rst.

regards,
dan carpenter