2021-09-30 08:27:20

by Adrian Hunter

Subject: [PATCH] perf tools: Suppress 'rm dlfilter' build message

The following build message:

rm dlfilters/dlfilter-test-api-v0.o

is unwanted.

The object fle is being treated as an intermediate file and being
automatically removed. Mark the object file as .SECONDARY to prevent
removal and hence the message.

Signed-off-by: Adrian Hunter <[email protected]>
---
tools/perf/Makefile.perf | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index e04313c4d840..ab8cb17d9ec5 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -787,6 +787,8 @@ $(OUTPUT)dlfilters/%.o: dlfilters/%.c include/perf/perf_dlfilter.h
$(Q)$(MKDIR) -p $(OUTPUT)dlfilters
$(QUIET_CC)$(CC) -c -Iinclude $(EXTRA_CFLAGS) -o $@ -fpic $<

+.SECONDARY: $(DLFILTERS:.so=.o)
+
$(OUTPUT)dlfilters/%.so: $(OUTPUT)dlfilters/%.o
$(QUIET_LINK)$(CC) $(EXTRA_CFLAGS) -shared -o $@ $<

--
2.25.1

2021-09-30 10:43:11

by kajoljain

Subject: Re: [PATCH] perf tools: Suppress 'rm dlfilter' build message

On 9/30/21 11:58 AM, Adrian Hunter wrote:
> The following build message:
>
> rm dlfilters/dlfilter-test-api-v0.o
>
> is unwanted.
>

Hi Adrian,

> The object fle is being treated as an intermediate file and being

Just minor nit, it should be `object file` not `object fle`

Thanks,
Kajol Jain

> automatically removed. Mark the object file as .SECONDARY to prevent
> removal and hence the message.
>
> Signed-off-by: Adrian Hunter <[email protected]>
> ---
> tools/perf/Makefile.perf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index e04313c4d840..ab8cb17d9ec5 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -787,6 +787,8 @@ $(OUTPUT)dlfilters/%.o: dlfilters/%.c include/perf/perf_dlfilter.h
> $(Q)$(MKDIR) -p $(OUTPUT)dlfilters
> $(QUIET_CC)$(CC) -c -Iinclude $(EXTRA_CFLAGS) -o $@ -fpic $<
>
> +.SECONDARY: $(DLFILTERS:.so=.o)
> +
> $(OUTPUT)dlfilters/%.so: $(OUTPUT)dlfilters/%.o
> $(QUIET_LINK)$(CC) $(EXTRA_CFLAGS) -shared -o $@ $<
>
>

2021-10-20 14:41:34

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf tools: Suppress 'rm dlfilter' build message

Em Thu, Sep 30, 2021 at 09:28:49AM +0300, Adrian Hunter escreveu:
> The following build message:
>
> rm dlfilters/dlfilter-test-api-v0.o
>
> is unwanted.
>
> The object fle is being treated as an intermediate file and being
> automatically removed. Mark the object file as .SECONDARY to prevent
> removal and hence the message.

Thanks, applied. Sorry for the delay, fell thru the cracks :-\ Also I
adjusted the fle typo reported by Kajol.

- Arnaldo


> Signed-off-by: Adrian Hunter <[email protected]>
> ---
> tools/perf/Makefile.perf | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index e04313c4d840..ab8cb17d9ec5 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -787,6 +787,8 @@ $(OUTPUT)dlfilters/%.o: dlfilters/%.c include/perf/perf_dlfilter.h
> $(Q)$(MKDIR) -p $(OUTPUT)dlfilters
> $(QUIET_CC)$(CC) -c -Iinclude $(EXTRA_CFLAGS) -o $@ -fpic $<
>
> +.SECONDARY: $(DLFILTERS:.so=.o)
> +
> $(OUTPUT)dlfilters/%.so: $(OUTPUT)dlfilters/%.o
> $(QUIET_LINK)$(CC) $(EXTRA_CFLAGS) -shared -o $@ $<
>
> --
> 2.25.1

--

- Arnaldo