2023-09-13 17:08:26

by Ian Abbott

[permalink] [raw]
Subject: Re: [PATCH v2 04/13] comedi: comedi_8254: Conditionally remove I/O port support

On 13/09/2023 17:40, Ian Abbott wrote:
> The comedi_8254 module supports both port I/O and memory-mapped I/O.
> In a future patch, the port I/O functions (`inb()`, `outb()`, and
> friends) will only be declared if the `HAS_IOPORT` configuration option
> is enabled.
>
> Conditionally compile the parts of the module that use port I/O so they
> are compiled if and only if the `CONFIG_HAS_IOPORT` macro is defined, so
> that it can still be built if the port I/O functions have not been
> declared. If `CONFIG_HAS_IOPORT` is undefined, replace the GPL-exported
> `comedi_8254_io_alloc()` function with a dummy static inline version
> that just returns `ERR_PTR(-ENXIO)`.
>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Niklas Schnelle <[email protected]>
> Signed-off-by: Ian Abbott <[email protected]>
> v2: N/A
> ---

Oops. I forgot the --- dividing line before the patch change log. (Same
mistake in patches 06 and 09. Time for a v3. Sorry about that.

--
-=( Ian Abbott <[email protected]> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || http://www.mev.co.uk )=-