Loongson platform support spi hardware controller and this series patch
was to add spi driver and binding support.
Change in v2:
1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
https://
lore.kernel.org/all/[email protected]/
2. Remove the clock-names in spi yaml file.
3. Add "loongson,ls7a-spi" compatible in spi yaml file.
4. Add an || COMPILE_TEST and drop && PCI then add some CONFIG_PCI
macro to limit some pci code.
5. Make the spi driver top code comment block that use C++ style.
6. Drop spi->max_speed_hz.
7. Add a spin_lock for loongson_spi_setup.
8. Add a timeout and cpu_relax() in loongson_spi_write_read_8bit.
9. Add spi_transfer_one and drop transfer and rework entire spi
driver that include some necessary changes.
10. Use module_init replace subsys_initcall.
11. About PM interface that I don't find any issue so I don't add
any changes.
Change in v3:
1. This [PATCH v3 1/2] dt-bindings patch need depend on clk patch:
https://
lore.kernel.org/all/[email protected]/
2. Drop the unused blank line in loongson,ls-spi.yaml file.
3. Replace clock minItems with clock maxItems in yaml file.
4. Separate spi driver into platform module, pci module and core
module.
5. Replace DIV_ROUND_UP with DIV_ROUND_UP_ULL to fix compile error
"undefined reference to `__aeabi_uldivmod'" and "__udivdi3 undefined"
that reported by test robot.
6. Remove the spin lock.
7. Clear the loongson_spi->hz and loongson_spi->mode in setup to fixup
the issue that multiple spi device transfer that maybe cause spi was
be misconfigured.
Change in v4:
1. This [PATCH v4 1/2] dt-bindings patch need depend on clk patch:
https://
lore.kernel.org/all/[email protected]/
2. Add "#include <linux/io.h>" in spi-loongson-core.c for fix the compile
issue which devm_ioremap no declaration.
3. Add "EXPORT_SYMBOL_GPL(loongson_spi_dev_pm_ops)" in
spi-loongson-core.c for fix the compile issue which
loongson_spi_dev_pm_ops undefined.
Change in v5:
1. Get rid of the clock patch's dependency and open-code the clock IDs.
2. Fixup checkpatch issue that by installed ply and gitpython package
locally, but this series of patch's code doesn't have any change.
Change in v6:
1. Remove the "#include <dt-bindings/clock/loongson,ls2k-clk.h>" in
yaml file.
Change in v7:
1. Remove the "loongson,ls7a-spi" and change yaml file name as
"loongson,ls2k-spi.yaml".
2. Use module_pci_driver and module_platform_driver to replace
module_init and module_exit.
3. Drop ".owner = THIS_MODULE" in spi platform driver.
4. Add devm_spi_alloc_master devm_spi_register_master to simplify code.
5. Add pci_disable_device() in loongson_spi_pci_unregister.
Change in v8:
1. Add reviewed-by information for spi bindings patch.
2. Fixup the uncorrect spi yaml file path in MAINTAINERS file.
3. Add spi_master_suspend and spi_master_resume in spi pm function.
Change in v9:
1. Make spi_master_suspend go first in pm suspend.
Change in v10:
1. Fix the compile issue about of_node_get and of_get_property no
declaration.
2. set config SPI_LOONGSON_CORE invisible.
3. Captial "spi" in commit log and Kconfig file.
4. Write header files in alphabetical order.
5. Use clamp_val, GENMASK() and BIT() in spi clock setting.
6. Optimize clock and mode setting code.
7. Use readb_poll_timeout in loongson_spi_write_read_8bit.
8. Remove some useless dmesg print.
9. Use device_set_node replace of_node_get.
10. Use dev_err_probe in code.
11. Use devm_clk_get_optional replace devm_clk_get.
12. Remove SPI_NO_CS for drop 2k500 non common type spi.
13. Use pcim_enable_device() and pcim_iomap_regions() in spi pci
driver.
14. Passing the remapped address in loongson_spi_init_master.
15. Remove the useless goto flag "err_out".
16. Use pci vendor id in pci_ids.h.
17. Use devm_platform_ioremap_resource in spi platform driver.
18. Remove the useless item in pci_device_id.
19. Remove the inned comma in of_device_id.
20. Add some headfile in spi_loongson.h.
21. Remove the useless extern for loongson_spi_init_master in
spi_loongson.h.
Change in v11:
1. Use spi_get_chipselect() to replace all spi->chip_select in
spi driver
Change in v12:
1. Reword the dt-bindings patch title.
2. Use a specific spi compatible in dt-bindings and spi driver.
3. Add Cc list for the reviewers of the previous version.
4. Add a static for rdiv[12] array in loongson_spi_set_clk.
5. Fixup the compile warning for spi HZ that reported by robot.
6. Use "#define LOONGSON_... BIT(0)" in readb_poll_timeout.
7. Add a error code return that when write spi failed.
8. Use spi_controller* instead of spi_master* in all cases.
9. Check for the error first which for clock gain.
10. Drop the ->remove() in spi pci driver.
11. Drop the comma for the terminator entry in pci_device_id.
12. Adjust the head file in spi driver.
13. Use forward declarations for device and spi_controller.
Yinbo Zhu (2):
spi: add loongson spi bindings
spi: loongson: add bus driver for the loongson spi controller
.../bindings/spi/loongson,ls2k-spi.yaml | 41 +++
MAINTAINERS | 10 +
drivers/spi/Kconfig | 26 ++
drivers/spi/Makefile | 3 +
drivers/spi/spi-loongson-core.c | 275 ++++++++++++++++++
drivers/spi/spi-loongson-pci.c | 55 ++++
drivers/spi/spi-loongson-plat.c | 47 +++
drivers/spi/spi-loongson.h | 49 ++++
8 files changed, 506 insertions(+)
--
2.20.1
Add the Loongson platform spi binding with DT schema format using
json-schema.
Signed-off-by: Yinbo Zhu <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/spi/loongson,ls2k-spi.yaml | 41 +++++++++++++++++++
MAINTAINERS | 6 +++
2 files changed, 47 insertions(+)
create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
diff --git a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
new file mode 100644
index 000000000000..423ee851edd5
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/loongson,ls2k-spi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Loongson SPI controller
+
+maintainers:
+ - Yinbo Zhu <[email protected]>
+
+allOf:
+ - $ref: /schemas/spi/spi-controller.yaml#
+
+properties:
+ compatible:
+ enum:
+ - loongson,ls2k1000-spi
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ spi0: spi@1fff0220{
+ compatible = "loongson,ls2k1000-spi";
+ reg = <0x1fff0220 0x10>;
+ clocks = <&clk 17>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index bc201627c2e0..5e604dddd87b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12186,6 +12186,12 @@ F: Documentation/devicetree/bindings/clock/loongson,ls2k-clk.yaml
F: drivers/clk/clk-loongson2.c
F: include/dt-bindings/clock/loongson,ls2k-clk.h
+LOONGSON SPI DRIVER
+M: Yinbo Zhu <[email protected]>
+L: [email protected]
+S: Maintained
+F: Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
+
LOONGSON-2 SOC SERIES GUTS DRIVER
M: Yinbo Zhu <[email protected]>
L: [email protected]
--
2.20.1
On 08/06/2023 10:39, zhuyinbo wrote:
>>>
>>> Signed-off-by: Yinbo Zhu <[email protected]>
>>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>>> ---
>>> .../bindings/spi/loongson,ls2k-spi.yaml | 41 +++++++++++++++++++
>>> MAINTAINERS | 6 +++
>>> 2 files changed, 47 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>> new file mode 100644
>>> index 000000000000..423ee851edd5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>
>> Filename based on compatible.
>
>
> There will be more ls2k series SoC spi device in the future thus I still
> use "loongson,ls2k-spi.yaml" for cover it.
Add them now.
>
>>
>>> @@ -0,0 +1,41 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/spi/loongson,ls2k-spi.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Loongson SPI controller
>>> +
>>> +maintainers:
>>> + - Yinbo Zhu <[email protected]>
>>> +
>>> +allOf:
>>> + - $ref: /schemas/spi/spi-controller.yaml#
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - loongson,ls2k1000-spi
>>
>> No compatibles for other devices? Didn't we have big discussion about this?
>>
>> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
>
>
> There are other ls2k SPI devices compatible, such as,
> "loongson,ls2k0500-spi", "loongson,ls2k2000-spi" but currently I plan to
> add ls2k1000 spi device first, Other ls2k SoC spi device adaptation may
> require some additional work and I will add it later.
Previously you claimed this serves entire family, so I don't understand
why you need to fix something. Why previously it was working for entire
family but now it does not?
Best regards,
Krzysztof
在 2023/6/8 下午4:53, Krzysztof Kozlowski 写道:
> On 08/06/2023 10:39, zhuyinbo wrote:
>>>>
>>>> Signed-off-by: Yinbo Zhu <[email protected]>
>>>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>>>> ---
>>>> .../bindings/spi/loongson,ls2k-spi.yaml | 41 +++++++++++++++++++
>>>> MAINTAINERS | 6 +++
>>>> 2 files changed, 47 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>> new file mode 100644
>>>> index 000000000000..423ee851edd5
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>
>>> Filename based on compatible.
>>
>>
>> There will be more ls2k series SoC spi device in the future thus I still
>> use "loongson,ls2k-spi.yaml" for cover it.
>
> Add them now.
The 2k0500 doesn't support CCF and not use CCF to gain clock and We
internally tend to prioritize supporting 2k1000.
>
>>
>>>
>>>> @@ -0,0 +1,41 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/spi/loongson,ls2k-spi.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Loongson SPI controller
>>>> +
>>>> +maintainers:
>>>> + - Yinbo Zhu <[email protected]>
>>>> +
>>>> +allOf:
>>>> + - $ref: /schemas/spi/spi-controller.yaml#
>>>> +
>>>> +properties:
>>>> + compatible:
>>>> + enum:
>>>> + - loongson,ls2k1000-spi
>>>
>>> No compatibles for other devices? Didn't we have big discussion about this?
>>>
>>> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
>>
>>
>> There are other ls2k SPI devices compatible, such as,
>> "loongson,ls2k0500-spi", "loongson,ls2k2000-spi" but currently I plan to
>> add ls2k1000 spi device first, Other ls2k SoC spi device adaptation may
>> require some additional work and I will add it later.
>
> Previously you claimed this serves entire family, so I don't understand
> why you need to fix something. Why previously it was working for entire
> family but now it does not?
It can work was for ls2k1000 and ls2k0500 and it specifically refers to
spi driver. but 2k0500 doesn't implementing a clock driver and doesn't
use CCF to gain clock but can use "clock-frequency". Is it necessary to
obtain a clock based on CCF? If it's necessary, then it seems that it
can only added 2k1000 spi first.
Thanks,
Yinbo
On 08/06/2023 12:00, zhuyinbo wrote:
>
>
> 在 2023/6/8 下午4:53, Krzysztof Kozlowski 写道:
>> On 08/06/2023 10:39, zhuyinbo wrote:
>>>>>
>>>>> Signed-off-by: Yinbo Zhu <[email protected]>
>>>>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>>>>> ---
>>>>> .../bindings/spi/loongson,ls2k-spi.yaml | 41 +++++++++++++++++++
>>>>> MAINTAINERS | 6 +++
>>>>> 2 files changed, 47 insertions(+)
>>>>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..423ee851edd5
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>
>>>> Filename based on compatible.
>>>
>>>
>>> There will be more ls2k series SoC spi device in the future thus I still
>>> use "loongson,ls2k-spi.yaml" for cover it.
>>
>> Add them now.
>
>
> The 2k0500 doesn't support CCF and not use CCF to gain clock and We
> internally tend to prioritize supporting 2k1000.
Don't you refer now to drivers? Because how hardware can not support
clocks if it has them? How CCF is anyhow related to hardware?
>
>>
>>>
>>>>
>>>>> @@ -0,0 +1,41 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/spi/loongson,ls2k-spi.yaml#
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>> +
>>>>> +title: Loongson SPI controller
>>>>> +
>>>>> +maintainers:
>>>>> + - Yinbo Zhu <[email protected]>
>>>>> +
>>>>> +allOf:
>>>>> + - $ref: /schemas/spi/spi-controller.yaml#
>>>>> +
>>>>> +properties:
>>>>> + compatible:
>>>>> + enum:
>>>>> + - loongson,ls2k1000-spi
>>>>
>>>> No compatibles for other devices? Didn't we have big discussion about this?
>>>>
>>>> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
>>>
>>>
>>> There are other ls2k SPI devices compatible, such as,
>>> "loongson,ls2k0500-spi", "loongson,ls2k2000-spi" but currently I plan to
>>> add ls2k1000 spi device first, Other ls2k SoC spi device adaptation may
>>> require some additional work and I will add it later.
>>
>> Previously you claimed this serves entire family, so I don't understand
>> why you need to fix something. Why previously it was working for entire
>> family but now it does not?
>
>
> It can work was for ls2k1000 and ls2k0500 and it specifically refers to
> spi driver. but 2k0500 doesn't implementing a clock driver and doesn't
We do not discuss here drivers, but bindings. Whatever your drivers are
not supporting, matters less.
> use CCF to gain clock but can use "clock-frequency". Is it necessary to
> obtain a clock based on CCF? If it's necessary, then it seems that it
> can only added 2k1000 spi first.
Not related to bindings...
Best regards,
Krzysztof
在 2023/6/8 下午6:02, Krzysztof Kozlowski 写道:
> On 08/06/2023 12:00, zhuyinbo wrote:
>>
>>
>> 在 2023/6/8 下午4:53, Krzysztof Kozlowski 写道:
>>> On 08/06/2023 10:39, zhuyinbo wrote:
>>>>>>
>>>>>> Signed-off-by: Yinbo Zhu <[email protected]>
>>>>>> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>>>>>> ---
>>>>>> .../bindings/spi/loongson,ls2k-spi.yaml | 41 +++++++++++++++++++
>>>>>> MAINTAINERS | 6 +++
>>>>>> 2 files changed, 47 insertions(+)
>>>>>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>> new file mode 100644
>>>>>> index 000000000000..423ee851edd5
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>
>>>>> Filename based on compatible.
>>>>
>>>>
>>>> There will be more ls2k series SoC spi device in the future thus I still
>>>> use "loongson,ls2k-spi.yaml" for cover it.
>>>
>>> Add them now.
>>
>>
>> The 2k0500 doesn't support CCF and not use CCF to gain clock and We
>> internally tend to prioritize supporting 2k1000.
>
> Don't you refer now to drivers? Because how hardware can not support
> clocks if it has them? How CCF is anyhow related to hardware?
The CCF (common clock framework) driver only affects the clock parameter
pass method and isn't related to clock hardware. and if dts pass a
"clock-frequency" that not need a clock driver but if dts pass a
"clocks" that need a clock driver. Currently, only 2k1000 has
implemented a clock driver.
>
>>
>>>
>>>>
>>>>>
>>>>>> @@ -0,0 +1,41 @@
>>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>>>> +%YAML 1.2
>>>>>> +---
>>>>>> +$id: http://devicetree.org/schemas/spi/loongson,ls2k-spi.yaml#
>>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>>> +
>>>>>> +title: Loongson SPI controller
>>>>>> +
>>>>>> +maintainers:
>>>>>> + - Yinbo Zhu <[email protected]>
>>>>>> +
>>>>>> +allOf:
>>>>>> + - $ref: /schemas/spi/spi-controller.yaml#
>>>>>> +
>>>>>> +properties:
>>>>>> + compatible:
>>>>>> + enum:
>>>>>> + - loongson,ls2k1000-spi
>>>>>
>>>>> No compatibles for other devices? Didn't we have big discussion about this?
>>>>>
>>>>> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
>>>>
>>>>
>>>> There are other ls2k SPI devices compatible, such as,
>>>> "loongson,ls2k0500-spi", "loongson,ls2k2000-spi" but currently I plan to
>>>> add ls2k1000 spi device first, Other ls2k SoC spi device adaptation may
>>>> require some additional work and I will add it later.
>>>
>>> Previously you claimed this serves entire family, so I don't understand
>>> why you need to fix something. Why previously it was working for entire
>>> family but now it does not?
>>
>>
>> It can work was for ls2k1000 and ls2k0500 and it specifically refers to
>> spi driver. but 2k0500 doesn't implementing a clock driver and doesn't
>
> We do not discuss here drivers, but bindings. Whatever your drivers are
> not supporting, matters less.
>
>> use CCF to gain clock but can use "clock-frequency". Is it necessary to
>> obtain a clock based on CCF? If it's necessary, then it seems that it
>> can only added 2k1000 spi first.
>
> Not related to bindings...
I may understand that what you said, and the dt-bindings only cover
hardware and not involve the drivers. if so, I will add following:
--- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
+++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
@@ -16,6 +16,7 @@ properties:
compatible:
enum:
- loongson,ls2k1000-spi
+ - loongson,ls2k0500-spi
Thanks,
Yinbo
在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
> On 08/06/2023 13:42, zhuyinbo wrote:
>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>> @@ -16,6 +16,7 @@ properties:
>> compatible:
>> enum:
>> - loongson,ls2k1000-spi
>> + - loongson,ls2k0500-spi
>
> Aren't they compatible?
>
Are you saying that the spi driver is compatible with 2k0500 ?
Yes. and the 2k1000 spi hardware was same with 2k0500 common type spi
hardware.
but afterwards, it may be necessary to implement a clock drvier for
2k0500, because the spi driver was use "devm_clk_get_optional()" to
get clock and not use "of_property_read_u32(np, "clock-frequency",
&clk)", But this seems to have nothing to do with bindings.
Thanks,
Yinbo
On 08/06/2023 13:42, zhuyinbo wrote:
>>
>>> It can work was for ls2k1000 and ls2k0500 and it specifically refers to
>>> spi driver. but 2k0500 doesn't implementing a clock driver and doesn't
>>
>> We do not discuss here drivers, but bindings. Whatever your drivers are
>> not supporting, matters less.
>>
>>> use CCF to gain clock but can use "clock-frequency". Is it necessary to
>>> obtain a clock based on CCF? If it's necessary, then it seems that it
>>> can only added 2k1000 spi first.
>>
>> Not related to bindings...
>
>
> I may understand that what you said, and the dt-bindings only cover
> hardware and not involve the drivers. if so, I will add following:
>
>
> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
> @@ -16,6 +16,7 @@ properties:
> compatible:
> enum:
> - loongson,ls2k1000-spi
> + - loongson,ls2k0500-spi
Aren't they compatible?
Best regards,
Krzysztof
On 08/06/2023 14:10, zhuyinbo wrote:
>
>
> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>> On 08/06/2023 13:42, zhuyinbo wrote:
>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>> @@ -16,6 +16,7 @@ properties:
>>> compatible:
>>> enum:
>>> - loongson,ls2k1000-spi
>>> + - loongson,ls2k0500-spi
>>
>> Aren't they compatible?
>>
>
>
> Are you saying that the spi driver is compatible with 2k0500 ?
Didn't you say this through 11 previous revisions?
> Yes. and the 2k1000 spi hardware was same with 2k0500 common type spi
> hardware.
>
> but afterwards, it may be necessary to implement a clock drvier for
> 2k0500, because the spi driver was use "devm_clk_get_optional()" to
> get clock and not use "of_property_read_u32(np, "clock-frequency",
> &clk)", But this seems to have nothing to do with bindings.
>
Best regards,
Krzysztof
在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道:
> On 08/06/2023 14:10, zhuyinbo wrote:
>>
>>
>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>>> On 08/06/2023 13:42, zhuyinbo wrote:
>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>> @@ -16,6 +16,7 @@ properties:
>>>> compatible:
>>>> enum:
>>>> - loongson,ls2k1000-spi
>>>> + - loongson,ls2k0500-spi
>>>
>>> Aren't they compatible?
>>>
>>
>>
>> Are you saying that the spi driver is compatible with 2k0500 ?
>
> Didn't you say this through 11 previous revisions?
Yes, did I understand your meaning incorrectly ?
Thanks,
Yinbo
>
>> Yes. and the 2k1000 spi hardware was same with 2k0500 common type spi
>> hardware.
>>
>> but afterwards, it may be necessary to implement a clock drvier for
>> 2k0500, because the spi driver was use "devm_clk_get_optional()" to
>> get clock and not use "of_property_read_u32(np, "clock-frequency",
>> &clk)", But this seems to have nothing to do with bindings.
On 09/06/2023 05:13, zhuyinbo wrote:
>
>
> 在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道:
>> On 08/06/2023 14:10, zhuyinbo wrote:
>>>
>>>
>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>>>> On 08/06/2023 13:42, zhuyinbo wrote:
>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>> @@ -16,6 +16,7 @@ properties:
>>>>> compatible:
>>>>> enum:
>>>>> - loongson,ls2k1000-spi
>>>>> + - loongson,ls2k0500-spi
>>>>
>>>> Aren't they compatible?
>>>>
>>>
>>>
>>> Are you saying that the spi driver is compatible with 2k0500 ?
>>
>> Didn't you say this through 11 previous revisions?
>
>
> Yes, did I understand your meaning incorrectly ?
If they are compatible, then they are not part of one enum. They could
not be as this would easily fail in testing of your DTS.
Best regards,
Krzysztof
在 2023/6/10 上午12:45, Krzysztof Kozlowski 写道:
> On 09/06/2023 05:13, zhuyinbo wrote:
>>
>>
>> 在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道:
>>> On 08/06/2023 14:10, zhuyinbo wrote:
>>>>
>>>>
>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>>>>> On 08/06/2023 13:42, zhuyinbo wrote:
>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>> @@ -16,6 +16,7 @@ properties:
>>>>>> compatible:
>>>>>> enum:
>>>>>> - loongson,ls2k1000-spi
>>>>>> + - loongson,ls2k0500-spi
>>>>>
>>>>> Aren't they compatible?
>>>>>
>>>>
>>>>
>>>> Are you saying that the spi driver is compatible with 2k0500 ?
>>>
>>> Didn't you say this through 11 previous revisions?
>>
>>
>> Yes, did I understand your meaning incorrectly ?
>
> If they are compatible, then they are not part of one enum. They could
> not be as this would easily fail in testing of your DTS.
>
The "loongson,ls2k0500-spi" wasn't a compatible in previous version and
I will add "loongson,ls2k0500-spi" as a compatible in spi driver and
added it as a part of the one enum in dt-binding.
Thanks,
Yinbo
On 12/06/2023 09:13, zhuyinbo wrote:
>
>
> 在 2023/6/10 上午12:45, Krzysztof Kozlowski 写道:
>> On 09/06/2023 05:13, zhuyinbo wrote:
>>>
>>>
>>> 在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道:
>>>> On 08/06/2023 14:10, zhuyinbo wrote:
>>>>>
>>>>>
>>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>>>>>> On 08/06/2023 13:42, zhuyinbo wrote:
>>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>> @@ -16,6 +16,7 @@ properties:
>>>>>>> compatible:
>>>>>>> enum:
>>>>>>> - loongson,ls2k1000-spi
>>>>>>> + - loongson,ls2k0500-spi
>>>>>>
>>>>>> Aren't they compatible?
>>>>>>
>>>>>
>>>>>
>>>>> Are you saying that the spi driver is compatible with 2k0500 ?
>>>>
>>>> Didn't you say this through 11 previous revisions?
>>>
>>>
>>> Yes, did I understand your meaning incorrectly ?
>>
>> If they are compatible, then they are not part of one enum. They could
>> not be as this would easily fail in testing of your DTS.
>>
>
>
> The "loongson,ls2k0500-spi" wasn't a compatible in previous version and
> I will add "loongson,ls2k0500-spi" as a compatible in spi driver and
> added it as a part of the one enum in dt-binding.
No, because you claimed - if I understood correctly - that they are
compatible. Don't add fake entries to the driver.
Best regards,
Krzysztof
在 2023/6/12 下午3:17, Krzysztof Kozlowski 写道:
> On 12/06/2023 09:13, zhuyinbo wrote:
>>
>>
>> 在 2023/6/10 上午12:45, Krzysztof Kozlowski 写道:
>>> On 09/06/2023 05:13, zhuyinbo wrote:
>>>>
>>>>
>>>> 在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道:
>>>>> On 08/06/2023 14:10, zhuyinbo wrote:
>>>>>>
>>>>>>
>>>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>>>>>>> On 08/06/2023 13:42, zhuyinbo wrote:
>>>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>> @@ -16,6 +16,7 @@ properties:
>>>>>>>> compatible:
>>>>>>>> enum:
>>>>>>>> - loongson,ls2k1000-spi
>>>>>>>> + - loongson,ls2k0500-spi
>>>>>>>
>>>>>>> Aren't they compatible?
>>>>>>>
>>>>>>
>>>>>>
>>>>>> Are you saying that the spi driver is compatible with 2k0500 ?
>>>>>
>>>>> Didn't you say this through 11 previous revisions?
>>>>
>>>>
>>>> Yes, did I understand your meaning incorrectly ?
>>>
>>> If they are compatible, then they are not part of one enum. They could
>>> not be as this would easily fail in testing of your DTS.
>>>
>>
>>
>> The "loongson,ls2k0500-spi" wasn't a compatible in previous version and
>> I will add "loongson,ls2k0500-spi" as a compatible in spi driver and
>> added it as a part of the one enum in dt-binding.
>
> No, because you claimed - if I understood correctly - that they are
> compatible. Don't add fake entries to the driver.
>
I'm a bit confused, and I just need to add 'loongson,ls2k0500-spi' as
one enum in dt-bindings, but driver don't add this entry ?
Thanks,
Yinbo
On 12/06/2023 09:40, zhuyinbo wrote:
>
>
> 在 2023/6/12 下午3:17, Krzysztof Kozlowski 写道:
>> On 12/06/2023 09:13, zhuyinbo wrote:
>>>
>>>
>>> 在 2023/6/10 上午12:45, Krzysztof Kozlowski 写道:
>>>> On 09/06/2023 05:13, zhuyinbo wrote:
>>>>>
>>>>>
>>>>> 在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道:
>>>>>> On 08/06/2023 14:10, zhuyinbo wrote:
>>>>>>>
>>>>>>>
>>>>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>>>>>>>> On 08/06/2023 13:42, zhuyinbo wrote:
>>>>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>>> @@ -16,6 +16,7 @@ properties:
>>>>>>>>> compatible:
>>>>>>>>> enum:
>>>>>>>>> - loongson,ls2k1000-spi
>>>>>>>>> + - loongson,ls2k0500-spi
>>>>>>>>
>>>>>>>> Aren't they compatible?
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Are you saying that the spi driver is compatible with 2k0500 ?
>>>>>>
>>>>>> Didn't you say this through 11 previous revisions?
>>>>>
>>>>>
>>>>> Yes, did I understand your meaning incorrectly ?
>>>>
>>>> If they are compatible, then they are not part of one enum. They could
>>>> not be as this would easily fail in testing of your DTS.
>>>>
>>>
>>>
>>> The "loongson,ls2k0500-spi" wasn't a compatible in previous version and
>>> I will add "loongson,ls2k0500-spi" as a compatible in spi driver and
>>> added it as a part of the one enum in dt-binding.
>>
>> No, because you claimed - if I understood correctly - that they are
>> compatible. Don't add fake entries to the driver.
>>
>
>
> I'm a bit confused, and I just need to add 'loongson,ls2k0500-spi' as
> one enum in dt-bindings, but driver don't add this entry ?
Compatibility is expressed with a list:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#compatible
so it cannot be just one enum, but "items". There are hundreds of
examples including example-schema.
Best regards,
Krzysztof
在 2023/6/12 下午4:16, Krzysztof Kozlowski 写道:
>>>>>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>>>>>>>>> On 08/06/2023 13:42, zhuyinbo wrote:
>>>>>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>>>> @@ -16,6 +16,7 @@ properties:
>>>>>>>>>> compatible:
>>>>>>>>>> enum:
>>>>>>>>>> - loongson,ls2k1000-spi
>>>>>>>>>> + - loongson,ls2k0500-spi
>>>>>>>>>
>>>>>>>>> Aren't they compatible?
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Are you saying that the spi driver is compatible with 2k0500 ?
>>>>>>>
>>>>>>> Didn't you say this through 11 previous revisions?
>>>>>>
>>>>>>
>>>>>> Yes, did I understand your meaning incorrectly ?
>>>>>
>>>>> If they are compatible, then they are not part of one enum. They could
>>>>> not be as this would easily fail in testing of your DTS.
>>>>>
>>>>
>>>>
>>>> The "loongson,ls2k0500-spi" wasn't a compatible in previous version and
>>>> I will add "loongson,ls2k0500-spi" as a compatible in spi driver and
>>>> added it as a part of the one enum in dt-binding.
>>>
>>> No, because you claimed - if I understood correctly - that they are
>>> compatible. Don't add fake entries to the driver.
>>>
>>
>>
>> I'm a bit confused, and I just need to add 'loongson,ls2k0500-spi' as
>> one enum in dt-bindings, but driver don't add this entry ?
>
> Compatibility is expressed with a list:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#compatible
> so it cannot be just one enum, but "items". There are hundreds of
> examples including example-schema.
Is it a description like the following?
properties:
compatible:
- enum:
- - loongson,ls2k1000-spi
+ oneOf:
+ - enum:
+ - loongson,ls2k1000-spi
+ - items:
+ - enum:
+ - loongson,ls2k1000-spi
+ - const: loongson,ls2k1000-spi
+ - items:
+ - enum:
+ - loongson,ls2k0500-spi
+ - const: loongson,ls2k1000-spi
reg:
Thanks,
Yinbo
On 12/06/2023 13:29, zhuyinbo wrote:
>
>
> 在 2023/6/12 下午4:16, Krzysztof Kozlowski 写道:
>>>>>>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>>>>>>>>>> On 08/06/2023 13:42, zhuyinbo wrote:
>>>>>>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>>>>> @@ -16,6 +16,7 @@ properties:
>>>>>>>>>>> compatible:
>>>>>>>>>>> enum:
>>>>>>>>>>> - loongson,ls2k1000-spi
>>>>>>>>>>> + - loongson,ls2k0500-spi
>>>>>>>>>>
>>>>>>>>>> Aren't they compatible?
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Are you saying that the spi driver is compatible with 2k0500 ?
>>>>>>>>
>>>>>>>> Didn't you say this through 11 previous revisions?
>>>>>>>
>>>>>>>
>>>>>>> Yes, did I understand your meaning incorrectly ?
>>>>>>
>>>>>> If they are compatible, then they are not part of one enum. They could
>>>>>> not be as this would easily fail in testing of your DTS.
>>>>>>
>>>>>
>>>>>
>>>>> The "loongson,ls2k0500-spi" wasn't a compatible in previous version and
>>>>> I will add "loongson,ls2k0500-spi" as a compatible in spi driver and
>>>>> added it as a part of the one enum in dt-binding.
>>>>
>>>> No, because you claimed - if I understood correctly - that they are
>>>> compatible. Don't add fake entries to the driver.
>>>>
>>>
>>>
>>> I'm a bit confused, and I just need to add 'loongson,ls2k0500-spi' as
>>> one enum in dt-bindings, but driver don't add this entry ?
>>
>> Compatibility is expressed with a list:
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#compatible
>> so it cannot be just one enum, but "items". There are hundreds of
>> examples including example-schema.
>
>
> Is it a description like the following?
>
> properties:
> compatible:
> - enum:
> - - loongson,ls2k1000-spi
> + oneOf:
> + - enum:
> + - loongson,ls2k1000-spi
> + - items:
> + - enum:
> + - loongson,ls2k1000-spi
> + - const: loongson,ls2k1000-spi
Remove this items part - it does not make sense. Device is not
compatible with itself. Rest looks ok.
Best regards,
Krzysztof
在 2023/6/13 上午2:03, Krzysztof Kozlowski 写道:
> On 12/06/2023 13:29, zhuyinbo wrote:
>>
>>
>> 在 2023/6/12 下午4:16, Krzysztof Kozlowski 写道:
>>>>>>>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道:
>>>>>>>>>>> On 08/06/2023 13:42, zhuyinbo wrote:
>>>>>>>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>>>>>>>>>>>> @@ -16,6 +16,7 @@ properties:
>>>>>>>>>>>> compatible:
>>>>>>>>>>>> enum:
>>>>>>>>>>>> - loongson,ls2k1000-spi
>>>>>>>>>>>> + - loongson,ls2k0500-spi
>>>>>>>>>>>
>>>>>>>>>>> Aren't they compatible?
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Are you saying that the spi driver is compatible with 2k0500 ?
>>>>>>>>>
>>>>>>>>> Didn't you say this through 11 previous revisions?
>>>>>>>>
>>>>>>>>
>>>>>>>> Yes, did I understand your meaning incorrectly ?
>>>>>>>
>>>>>>> If they are compatible, then they are not part of one enum. They could
>>>>>>> not be as this would easily fail in testing of your DTS.
>>>>>>>
>>>>>>
>>>>>>
>>>>>> The "loongson,ls2k0500-spi" wasn't a compatible in previous version and
>>>>>> I will add "loongson,ls2k0500-spi" as a compatible in spi driver and
>>>>>> added it as a part of the one enum in dt-binding.
>>>>>
>>>>> No, because you claimed - if I understood correctly - that they are
>>>>> compatible. Don't add fake entries to the driver.
>>>>>
>>>>
>>>>
>>>> I'm a bit confused, and I just need to add 'loongson,ls2k0500-spi' as
>>>> one enum in dt-bindings, but driver don't add this entry ?
>>>
>>> Compatibility is expressed with a list:
>>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#compatible
>>> so it cannot be just one enum, but "items". There are hundreds of
>>> examples including example-schema.
>>
>>
>> Is it a description like the following?
>>
>> properties:
>> compatible:
>> - enum:
>> - - loongson,ls2k1000-spi
>> + oneOf:
>> + - enum:
>> + - loongson,ls2k1000-spi
>> + - items:
>> + - enum:
>> + - loongson,ls2k1000-spi
>> + - const: loongson,ls2k1000-spi
>
> Remove this items part - it does not make sense. Device is not
> compatible with itself. Rest looks ok.
okay, I got it.
Thanks,
Yinbo