2022-08-24 07:57:12

by CGEL

Subject: [PATCH linux-next] scsi: lpfc: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value from lpfc_sli4_issue_wqe() directly instead of storing it
in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/scsi/lpfc/lpfc_sli.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 608016725db9..1298cea81396 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -10322,12 +10322,10 @@ static int
__lpfc_sli_issue_fcp_io_s4(struct lpfc_hba *phba, uint32_t ring_number,
struct lpfc_iocbq *piocb, uint32_t flag)
{
- int rc;
struct lpfc_io_buf *lpfc_cmd = piocb->io_buf;

lpfc_prep_embed_io(phba, lpfc_cmd);
- rc = lpfc_sli4_issue_wqe(phba, lpfc_cmd->hdwq, piocb);
- return rc;
+ return lpfc_sli4_issue_wqe(phba, lpfc_cmd->hdwq, piocb);
}

void
--
2.25.1

2022-08-24 14:36:48

by James Smart

Subject: Re: [PATCH linux-next] scsi: lpfc: Remove the unneeded result variable

On 8/24/2022 12:50 AM, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Return the value from lpfc_sli4_issue_wqe() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_sli.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 608016725db9..1298cea81396 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -10322,12 +10322,10 @@ static int
> __lpfc_sli_issue_fcp_io_s4(struct lpfc_hba *phba, uint32_t ring_number,
> struct lpfc_iocbq *piocb, uint32_t flag)
> {
> - int rc;
> struct lpfc_io_buf *lpfc_cmd = piocb->io_buf;
>
> lpfc_prep_embed_io(phba, lpfc_cmd);
> - rc = lpfc_sli4_issue_wqe(phba, lpfc_cmd->hdwq, piocb);
> - return rc;
> + return lpfc_sli4_issue_wqe(phba, lpfc_cmd->hdwq, piocb);
> }
>
> void

Thanks

Reviewed-by: James Smart <[email protected]>

-- james

2022-09-01 04:41:54

by Martin K. Petersen

Subject: Re: [PATCH linux-next] scsi: lpfc: Remove the unneeded result variable

> Return the value from lpfc_sli4_issue_wqe() directly instead of
> storing it in another redundant variable.

Applied to 6.1/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering