2022-11-08 13:07:51

by Sandor Yu

Subject: [PATCH v3 02/10] dt-bindings: display: bridge: Add MHDP HDMI for i.MX8MQ

Add bindings for i.MX8MQ MHDP HDMI.

Signed-off-by: Sandor Yu <[email protected]>
---
.../display/bridge/cdns,mhdp-imx8mq-hdmi.yaml | 59 +++++++++++++++++++
1 file changed, 59 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml

diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
new file mode 100644
index 000000000000..8c0afef157aa
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cadence MHDP HDMI bridge
+
+maintainers:
+ - Sandor Yu <[email protected]>
+
+description:
+ The Cadence MHDP TX HDMI interface.
+
+properties:
+ compatible:
+ enum:
+ - cdns,mhdp-imx8mq-hdmi
+
+ reg:
+ maxItems: 1
+
+ phys:
+ maxItems: 1
+
+ interrupts:
+ items:
+ - description: Hotplug detect interrupter for cable plugin event.
+ - description: Hotplug detect interrupter for cable plugout event.
+
+ interrupt-names:
+ items:
+ - const: plug_in
+ - const: plug_out
+
+ port:
+ $ref: /schemas/graph.yaml#/properties/port
+ description:
+ A port node pointing to the output port of a display controller.
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ mhdp_hdmi: hdmi-bridge@32c00000 {
+ compatible = "cdns,mhdp-imx8mq-hdmi";
+ reg = <0x32c00000 0x100000>;
+ interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "plug_in", "plug_out";
+ phys = <&hdmi_phy>;
+
+ port {
+ mhdp_in: endpoint {
+ remote-endpoint = <&dcss_out>;
+ };
+ };
+ };
--
2.34.1

2022-11-15 14:10:28

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 02/10] dt-bindings: display: bridge: Add MHDP HDMI for i.MX8MQ

On 08/11/2022 14:00, Sandor Yu wrote:
> Add bindings for i.MX8MQ MHDP HDMI.
>
> Signed-off-by: Sandor Yu <[email protected]>
> ---
> .../display/bridge/cdns,mhdp-imx8mq-hdmi.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
> new file mode 100644
> index 000000000000..8c0afef157aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cadence MHDP HDMI bridge
> +
> +maintainers:
> + - Sandor Yu <[email protected]>
> +
> +description:
> + The Cadence MHDP TX HDMI interface.
> +
> +properties:
> + compatible:
> + enum:
> + - cdns,mhdp-imx8mq-hdmi
> +
> + reg:
> + maxItems: 1
> +
> + phys:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: Hotplug detect interrupter for cable plugin event.
> + - description: Hotplug detect interrupter for cable plugout event.

I don't know what is interrupter, so maybe just "cable plugin/plugout"
or "Hotplug cable plugin/plugout"?

Sorry for not bringing this earlier.

> +
> + interrupt-names:
> + items:
> + - const: plug_in
> + - const: plug_out
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + A port node pointing to the output port of a display controller.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + mhdp_hdmi: hdmi-bridge@32c00000 {
> + compatible = "cdns,mhdp-imx8mq-hdmi";
> + reg = <0x32c00000 0x100000>;
> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;

Align with opening <



Best regards,
Krzysztof

2022-11-16 16:38:47

by Rob Herring (Arm)

Subject: Re: [PATCH v3 02/10] dt-bindings: display: bridge: Add MHDP HDMI for i.MX8MQ

On Tue, Nov 08, 2022 at 09:00:05PM +0800, Sandor Yu wrote:
> Add bindings for i.MX8MQ MHDP HDMI.
>
> Signed-off-by: Sandor Yu <[email protected]>
> ---
> .../display/bridge/cdns,mhdp-imx8mq-hdmi.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
> new file mode 100644
> index 000000000000..8c0afef157aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/cdns,mhdp-imx8mq-hdmi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cadence MHDP HDMI bridge
> +
> +maintainers:
> + - Sandor Yu <[email protected]>
> +
> +description:
> + The Cadence MHDP TX HDMI interface.
> +
> +properties:
> + compatible:
> + enum:
> + - cdns,mhdp-imx8mq-hdmi
> +
> + reg:
> + maxItems: 1
> +
> + phys:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: Hotplug detect interrupter for cable plugin event.
> + - description: Hotplug detect interrupter for cable plugout event.
> +
> + interrupt-names:
> + items:
> + - const: plug_in
> + - const: plug_out
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + A port node pointing to the output port of a display controller.

You also need an output port to an HDMI connector node.

> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + mhdp_hdmi: hdmi-bridge@32c00000 {
> + compatible = "cdns,mhdp-imx8mq-hdmi";
> + reg = <0x32c00000 0x100000>;
> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "plug_in", "plug_out";
> + phys = <&hdmi_phy>;
> +
> + port {
> + mhdp_in: endpoint {
> + remote-endpoint = <&dcss_out>;
> + };
> + };
> + };
> --
> 2.34.1
>
>