2003-07-21 12:48:56

by Ian Soboroff

[permalink] [raw]
Subject: 2.6.0-test1 - device_suspend KERN_EMERG message?


Is there any special reason to scream that we're suspending devices in
device_suspend?

int device_suspend(u32 state, u32 level)
{
struct device * dev;
int error = 0;

printk(KERN_EMERG "Suspending devices\n");

...

And likewise further below during resume.

On my box, syslog shouts to all xterms and KDE throws up a kwrite message
too. Why is this an emergency? If there are no objections, I'll send
a patch to move these messages to KERN_NOTICE.

Ian


2003-07-21 12:57:31

by Patrick Mochel

[permalink] [raw]
Subject: Re: 2.6.0-test1 - device_suspend KERN_EMERG message?


> Is there any special reason to scream that we're suspending devices in
> device_suspend?
>
> int device_suspend(u32 state, u32 level)
> {
> struct device * dev;
> int error = 0;
>
> printk(KERN_EMERG "Suspending devices\n");

Hey, it's so everyone notices. :)

I don't mind toning it down or removing it.


-pat

2003-07-21 13:01:20

by Sean Neakums

[permalink] [raw]
Subject: Re: 2.6.0-test1 - device_suspend KERN_EMERG message?

Ian Soboroff <[email protected]> writes:

> On my box, syslog shouts to all xterms and KDE throws up a kwrite message
> too. Why is this an emergency? If there are no objections, I'll send
> a patch to move these messages to KERN_NOTICE.

I think I saw a patch posted recently that deletes them entirely.