2023-08-04 20:44:09

by Konrad Dybcio

Subject: [PATCH 2/6] media: venus: core: Remove trailing commas from of match entries

Even though it has zero effect on functionality, remove them for coherency
with other drivers.

Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/media/platform/qcom/venus/core.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 3cc38881d4f6..0af45faec247 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -884,14 +884,14 @@ static const struct venus_resources sc7280_res = {
};

static const struct of_device_id venus_dt_match[] = {
- { .compatible = "qcom,msm8916-venus", .data = &msm8916_res, },
- { .compatible = "qcom,msm8996-venus", .data = &msm8996_res, },
- { .compatible = "qcom,sdm660-venus", .data = &sdm660_res, },
- { .compatible = "qcom,sdm845-venus", .data = &sdm845_res, },
- { .compatible = "qcom,sdm845-venus-v2", .data = &sdm845_res_v2, },
- { .compatible = "qcom,sc7180-venus", .data = &sc7180_res, },
- { .compatible = "qcom,sc7280-venus", .data = &sc7280_res, },
- { .compatible = "qcom,sm8250-venus", .data = &sm8250_res, },
+ { .compatible = "qcom,msm8916-venus", .data = &msm8916_res },
+ { .compatible = "qcom,msm8996-venus", .data = &msm8996_res },
+ { .compatible = "qcom,sdm660-venus", .data = &sdm660_res },
+ { .compatible = "qcom,sdm845-venus", .data = &sdm845_res },
+ { .compatible = "qcom,sdm845-venus-v2", .data = &sdm845_res_v2 },
+ { .compatible = "qcom,sc7180-venus", .data = &sc7180_res },
+ { .compatible = "qcom,sc7280-venus", .data = &sc7280_res },
+ { .compatible = "qcom,sm8250-venus", .data = &sm8250_res },
{ }
};
MODULE_DEVICE_TABLE(of, venus_dt_match);

--
2.41.0

2023-08-04 22:13:53

by Bryan O'Donoghue

Subject: Re: [PATCH 2/6] media: venus: core: Remove trailing commas from of match entries

On 04/08/2023 21:09, Konrad Dybcio wrote:
> Even though it has zero effect on functionality, remove them for coherency
> with other drivers.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> drivers/media/platform/qcom/venus/core.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 3cc38881d4f6..0af45faec247 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -884,14 +884,14 @@ static const struct venus_resources sc7280_res = {
> };
>
> static const struct of_device_id venus_dt_match[] = {
> - { .compatible = "qcom,msm8916-venus", .data = &msm8916_res, },
> - { .compatible = "qcom,msm8996-venus", .data = &msm8996_res, },
> - { .compatible = "qcom,sdm660-venus", .data = &sdm660_res, },
> - { .compatible = "qcom,sdm845-venus", .data = &sdm845_res, },
> - { .compatible = "qcom,sdm845-venus-v2", .data = &sdm845_res_v2, },
> - { .compatible = "qcom,sc7180-venus", .data = &sc7180_res, },
> - { .compatible = "qcom,sc7280-venus", .data = &sc7280_res, },
> - { .compatible = "qcom,sm8250-venus", .data = &sm8250_res, },
> + { .compatible = "qcom,msm8916-venus", .data = &msm8916_res },
> + { .compatible = "qcom,msm8996-venus", .data = &msm8996_res },
> + { .compatible = "qcom,sdm660-venus", .data = &sdm660_res },
> + { .compatible = "qcom,sdm845-venus", .data = &sdm845_res },
> + { .compatible = "qcom,sdm845-venus-v2", .data = &sdm845_res_v2 },
> + { .compatible = "qcom,sc7180-venus", .data = &sc7180_res },
> + { .compatible = "qcom,sc7280-venus", .data = &sc7280_res },
> + { .compatible = "qcom,sm8250-venus", .data = &sm8250_res },
> { }
> };
> MODULE_DEVICE_TABLE(of, venus_dt_match);


Reviewed-by: Bryan O'Donoghue <[email protected]>