Hi all,
After merging the regulator tree, today's linux-next build (s390
allmodconfig) failed like this:
include/linux/mfd/rohm-generic.h:93:12: error: 'rohm_regulator_set_voltage_sel_restricted' defined but not used [-Werror=unused-function]
cc1: all warnings being treated as errors
Caused by commit
8b6e88555971 ("regulator: rohm-regulator: add helper for restricted voltage setting")
--
Cheers,
Stephen Rothwell
Hi dee Ho peeps,
On 11/23/21 09:41, Stephen Rothwell wrote:
> Hi all,
>
> After merging the regulator tree, today's linux-next build (s390
> allmodconfig) failed like this:
>
> include/Linux/mfd/rohm-generic.h:93:12: error: 'rohm_regulator_set_voltage_sel_restricted' defined but not used [-Werror=unused-function]
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 8b6e88555971 ("regulator: rohm-regulator: add helper for restricted voltage setting")
Ouch. The stub in header should be inlined. Sorry for that. I'll send
incremental patch to Mark - please let me know if that's not sufficient?
Best Regards
-- Matti Vaittinen
--
The Linux Kernel guy at ROHM Semiconductors
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~ this year is the year of a signature writers block ~~
Hi again,
On 11/23/21 09:41, Stephen Rothwell wrote:
> Hi all,
>
> After merging the regulator tree, today's linux-next build (s390
> allmodconfig) failed like this:
>
> include/linux/mfd/rohm-generic.h:93:12: error: 'rohm_regulator_set_voltage_sel_restricted' defined but not used [-Werror=unused-function]
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 8b6e88555971 ("regulator: rohm-regulator: add helper for restricted voltage setting")
As a second thought - do we need such a stub function at all? I guess
anyone who is actually adding a call to the
rohm_regulator_set_voltage_sel_restricted() helper should also have the
implementation selected. Failing to do so is probably indication of an
error. Compile testing could perhaps be an exception but this is
currently not supported.
Should I just drop the stub or make it inline? Am I overlooking something?
Best Regards
-- Matti Vaittinen
--
The Linux Kernel guy at ROHM Semiconductors
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~ this year is the year of a signature writers block ~~
On Tue, Nov 23, 2021 at 09:26:45AM +0000, Vaittinen, Matti wrote:
> As a second thought - do we need such a stub function at all? I guess
> anyone who is actually adding a call to the
> rohm_regulator_set_voltage_sel_restricted() helper should also have the
> implementation selected. Failing to do so is probably indication of an
> error. Compile testing could perhaps be an exception but this is
> currently not supported.
> Should I just drop the stub or make it inline? Am I overlooking something?
Dropping it does seem reasonable, I can't immediately think of a case
where the stub would get used. I've queued your existing patch to try
to make sure that a fix lands tomorrow so (assuming no test issues)
please send a removal patch on top of that.