2022-11-01 04:40:03

by Zhao Gongyi

Subject: [PATCH -next] selftests/pidfd_test: Remove the erroneous ','

Remove the erroneous ',', otherwise it might result in wrong output
and report:
...
Bail out! (errno %d)
test: Unexpected epoll_wait result (c=4208480, events=2)
...

Fixes: 740378dc7834 ("pidfd: add polling selftests")
Signed-off-by: Zhao Gongyi <[email protected]>
---
tools/testing/selftests/pidfd/pidfd_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/pidfd/pidfd_test.c b/tools/testing/selftests/pidfd/pidfd_test.c
index d36654265b7a..e2dd4ed84984 100644
--- a/tools/testing/selftests/pidfd/pidfd_test.c
+++ b/tools/testing/selftests/pidfd/pidfd_test.c
@@ -413,7 +413,7 @@ static void poll_pidfd(const char *test_name, int pidfd)

c = epoll_wait(epoll_fd, events, MAX_EVENTS, 5000);
if (c != 1 || !(events[0].events & EPOLLIN))
- ksft_exit_fail_msg("%s test: Unexpected epoll_wait result (c=%d, events=%x) ",
+ ksft_exit_fail_msg("%s test: Unexpected epoll_wait result (c=%d, events=%x) "
"(errno %d)\n",
test_name, c, events[0].events, errno);

--
2.17.1

2022-11-02 09:41:27

by Shuah Khan

Subject: Re: [PATCH -next] selftests/pidfd_test: Remove the erroneous ','

On 10/31/22 21:56, Zhao Gongyi wrote:
> Remove the erroneous ',', otherwise it might result in wrong output
> and report:
> ...
> Bail out! (errno %d)
> test: Unexpected epoll_wait result (c=4208480, events=2)
> ...
>
> Fixes: 740378dc7834 ("pidfd: add polling selftests")
> Signed-off-by: Zhao Gongyi <[email protected]>
> ---

Applied to linux-kselftest next for the next rc.

thanks,
-- Shuah