2007-02-09 15:44:42

by Alon Bar-Lev

Subject: [PATCH 01/34] __initdata cleanup - alpha

Trivial.

Signed-off-by: Alon Bar-Lev <[email protected]>
Signed-off-by: Bernhard Walle <[email protected]>

---

diff -urNp linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c
--- linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c 2007-01-31 22:15:30.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c 2007-01-31 22:19:30.000000000 +0200
@@ -122,7 +122,7 @@ static void get_sysnames(unsigned long,
char **, char **);
static void determine_cpu_caches (unsigned int);

-static char __initdata command_line[COMMAND_LINE_SIZE];
+static char __initdata command_line[COMMAND_LINE_SIZE] = "";

/*
* The format of "screen_info" is strange, and due to early
diff -urNp linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/smc37c669.c linux-2.6.20-rc6-mm3/arch/alpha/kernel/smc37c669.c
--- linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/smc37c669.c 2007-01-25 04:19:28.000000000 +0200
+++ linux-2.6.20-rc6-mm3/arch/alpha/kernel/smc37c669.c 2007-01-31 22:19:30.000000000 +0200
@@ -996,7 +996,7 @@ static SMC37c669_CONFIG_REGS *SMC37c669
** and standard ISA IRQs.
**
*/
-static SMC37c669_IRQ_TRANSLATION_ENTRY *SMC37c669_irq_table __initdata;
+static SMC37c669_IRQ_TRANSLATION_ENTRY *SMC37c669_irq_table __initdata = NULL;

/*
** The following definition is for the default IRQ
@@ -1045,7 +1045,7 @@ static SMC37c669_IRQ_TRANSLATION_ENTRY *
** ISA DMA channels.
**
*/
-static SMC37c669_DRQ_TRANSLATION_ENTRY *SMC37c669_drq_table __initdata;
+static SMC37c669_DRQ_TRANSLATION_ENTRY *SMC37c669_drq_table __initdata = NULL;

/*
** The following definition is the default DRQ

2007-02-09 16:47:36

by Jiri Slaby

Subject: Re: [PATCH 01/34] __initdata cleanup - alpha

Alon Bar-Lev napsal(a):
> Trivial.
>
> Signed-off-by: Alon Bar-Lev <[email protected]>
> Signed-off-by: Bernhard Walle <[email protected]>
>
> ---
>
> diff -urNp linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c
> --- linux-2.6.20-rc6-mm3.org/arch/alpha/kernel/setup.c 2007-01-31 22:15:30.000000000 +0200
> +++ linux-2.6.20-rc6-mm3/arch/alpha/kernel/setup.c 2007-01-31 22:19:30.000000000 +0200
> @@ -122,7 +122,7 @@ static void get_sysnames(unsigned long,
> char **, char **);
> static void determine_cpu_caches (unsigned int);
>
> -static char __initdata command_line[COMMAND_LINE_SIZE];
> +static char __initdata command_line[COMMAND_LINE_SIZE] = "";

Why is this "= 0" to static global variables needed?

regards,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E

2007-02-09 16:52:54

by Alon Bar-Lev

Subject: Re: [PATCH 01/34] __initdata cleanup - alpha

On 2/9/07, Jiri Slaby <[email protected]> wrote:
> > -static char __initdata command_line[COMMAND_LINE_SIZE];
> > +static char __initdata command_line[COMMAND_LINE_SIZE] = "";
>
> Why is this "= 0" to static global variables needed?

Please review http://lkml.org/lkml/2007/1/22/267

Best Regards,
Alon Bar-Lev.

2007-02-09 17:11:33

by Jiri Slaby

Subject: Re: [PATCH 01/34] __initdata cleanup - alpha

Alon Bar-Lev napsal(a):
> On 2/9/07, Jiri Slaby <[email protected]> wrote:
>> > -static char __initdata command_line[COMMAND_LINE_SIZE];
>> > +static char __initdata command_line[COMMAND_LINE_SIZE] = "";
>>
>> Why is this "= 0" to static global variables needed?
>
> Please review http://lkml.org/lkml/2007/1/22/267

Ok, thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E