2022-08-22 11:05:04

by Farber, Eliav

[permalink] [raw]
Subject: [PATCH v2 0/2] add power-supply control to enable eeprom usage

First patch describes the new binding property.
Second patch adds the functionality to the driver.

Change between v2 and v1:
- Use a gpio regulator for power-supply control.

Eliav Farber (2):
dt-bindings: at24: add new optional power-supply property
eeprom: at24: add support for power-supply control

.../devicetree/bindings/eeprom/at24.txt | 3 ++
drivers/misc/eeprom/at24.c | 41 +++++++++++++++++++
2 files changed, 44 insertions(+)

--
2.37.1


2022-08-22 11:05:49

by Farber, Eliav

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: at24: add new optional power-supply property

Boards using the AT24 EEPROMs might have a GPIO that controls the power
supply of the chip, and it must be set to enable the usage of it.

Add a new optional property to the device tree binding document, which
allows to specify a GPIO regulator for the pin that controls the power.

On Linux this means that we need to enable the GPIO at the beginning of
probe function, before trying to access the chip.

Signed-off-by: Eliav Farber <[email protected]>
---
V1 -> V2:
Change pointed out by Rob Herring:
- Use a gpio regulator for power-supply control.

Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index f9a7c984274c..6d23ceac5fdc 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -73,6 +73,9 @@ Optional properties:

- wp-gpios: GPIO to which the write-protect pin of the chip is connected.

+ - power-supply: phandle of the gpio regulator that provides the supply
+ voltage.
+
- address-width: number of address bits (one of 8, 16).

Example:
--
2.37.1

2022-08-22 21:59:56

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: at24: add new optional power-supply property

On Mon, Aug 22, 2022 at 10:58:29AM +0000, Eliav Farber wrote:
> Boards using the AT24 EEPROMs might have a GPIO that controls the power
> supply of the chip, and it must be set to enable the usage of it.
>
> Add a new optional property to the device tree binding document, which
> allows to specify a GPIO regulator for the pin that controls the power.
>
> On Linux this means that we need to enable the GPIO at the beginning of
> probe function, before trying to access the chip.
>
> Signed-off-by: Eliav Farber <[email protected]>
> ---
> V1 -> V2:
> Change pointed out by Rob Herring:
> - Use a gpio regulator for power-supply control.
>
> Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++
> 1 file changed, 3 insertions(+)

This file doesn't exist any more. Use the latest -rc1 kernel unless
there is a reason you need a different (even later) base.

Rob

2022-08-28 16:18:40

by Farber, Eliav

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: at24: add new optional power-supply property

On 8/23/2022 12:46 AM, Rob Herring wrote:
>>  Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++
>>  1 file changed, 3 insertions(+)
>
> This file doesn't exist any more. Use the latest -rc1 kernel unless
> there is a reason you need a different (even later) base.
I applied the change on top of v6.0-rc1

--
Thanks, Eliav

2022-08-30 17:18:57

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: at24: add new optional power-supply property

On 28/08/2022 18:45, Farber, Eliav wrote:
> On 8/23/2022 12:46 AM, Rob Herring wrote:
>>>  Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++
>>>  1 file changed, 3 insertions(+)
>>
>> This file doesn't exist any more. Use the latest -rc1 kernel unless
>> there is a reason you need a different (even later) base.
> I applied the change on top of v6.0-rc1

Not really. The file is gone since v5.5-rc1 as you can easily see in the
sources.

Since you did not Cc-me, it's another proof you based your work on some
old kernel.

Best regards,
Krzysztof