2022-07-13 21:37:53

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] ARM: dts: qcom: Add LPG node to pm8941



On 13.07.2022 23:23, Bjorn Andersson wrote:
> The PM8941 contains 8 LPG channels, as well as TRILED and LUT blocks.
> Add a node for these.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
>
> Changes since v1:
> - Added #pwm-cells
>
> arch/arm/boot/dts/qcom-pm8941.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index a68634397938..59d0cde63251 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -144,6 +144,16 @@ pm8941_1: pm8941@1 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + pm8941_lpg: lpg {
> + compatible = "qcom,pm8941-lpg";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #pwm-cells = <2>;
> +
> + status = "disabled";
> + };
> +
> pm8941_wled: wled@d800 {
> compatible = "qcom,pm8941-wled";
> reg = <0xd800>;