Use hyphen instead of underscore and align the PPMU event node name with
dtschema.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. New patch
---
arch/arm/boot/dts/exynos5420.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index e23e8ffb093f..10ccd5cb69fd 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -302,7 +302,7 @@ ppmu_dmc0_0: ppmu@10d00000 {
clocks = <&clock CLK_PCLK_PPMU_DREX0_0>;
clock-names = "ppmu";
events {
- ppmu_event3_dmc0_0: ppmu-event3-dmc0_0 {
+ ppmu_event3_dmc0_0: ppmu-event3-dmc0-0 {
event-name = "ppmu-event3-dmc0_0";
};
};
@@ -314,7 +314,7 @@ ppmu_dmc0_1: ppmu@10d10000 {
clocks = <&clock CLK_PCLK_PPMU_DREX0_1>;
clock-names = "ppmu";
events {
- ppmu_event3_dmc0_1: ppmu-event3-dmc0_1 {
+ ppmu_event3_dmc0_1: ppmu-event3-dmc0-1 {
event-name = "ppmu-event3-dmc0_1";
};
};
@@ -326,7 +326,7 @@ ppmu_dmc1_0: ppmu@10d60000 {
clocks = <&clock CLK_PCLK_PPMU_DREX1_0>;
clock-names = "ppmu";
events {
- ppmu_event3_dmc1_0: ppmu-event3-dmc1_0 {
+ ppmu_event3_dmc1_0: ppmu-event3-dmc1-0 {
event-name = "ppmu-event3-dmc1_0";
};
};
@@ -338,7 +338,7 @@ ppmu_dmc1_1: ppmu@10d70000 {
clocks = <&clock CLK_PCLK_PPMU_DREX1_1>;
clock-names = "ppmu";
events {
- ppmu_event3_dmc1_1: ppmu-event3-dmc1_1 {
+ ppmu_event3_dmc1_1: ppmu-event3-dmc1-1 {
event-name = "ppmu-event3-dmc1_1";
};
};
--
2.30.2
On Fri, 20 Aug 2021 17:03:53 +0200, Krzysztof Kozlowski wrote:
> Use hyphen instead of underscore and align the PPMU event node name with
> dtschema.
>
>
Applied, thanks!
[4/4] ARM: dts: exynos: align PPMU event node names with dtschema
commit: fb9b199e562d66af90f61d70eb737fa5e4deac2c
Best regards,
--
Krzysztof Kozlowski <[email protected]>
Hi Krzysztof,
On 15.09.2021 09:50, Krzysztof Kozlowski wrote:
> On Fri, 20 Aug 2021 17:03:53 +0200, Krzysztof Kozlowski wrote:
>> Use hyphen instead of underscore and align the PPMU event node name with
>> dtschema.
>>
>>
> Applied, thanks!
>
> [4/4] ARM: dts: exynos: align PPMU event node names with dtschema
> commit: fb9b199e562d66af90f61d70eb737fa5e4deac2c
>
This breaks probing of Exynos event counters, which are needed by the
Exynos DMC driver on Odroid XU3/XU4/HC1 boards. Just check the today's
linux-next. I had no time to analyze which part of the code depends on
the node names though...
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
On 16/09/2021 13:15, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 15.09.2021 09:50, Krzysztof Kozlowski wrote:
>> On Fri, 20 Aug 2021 17:03:53 +0200, Krzysztof Kozlowski wrote:
>>> Use hyphen instead of underscore and align the PPMU event node name with
>>> dtschema.
>>>
>>>
>> Applied, thanks!
>>
>> [4/4] ARM: dts: exynos: align PPMU event node names with dtschema
>> commit: fb9b199e562d66af90f61d70eb737fa5e4deac2c
>>
> This breaks probing of Exynos event counters, which are needed by the
> Exynos DMC driver on Odroid XU3/XU4/HC1 boards. Just check the today's
> linux-next. I had no time to analyze which part of the code depends on
> the node names though...
Thanks for the report. I'll drop the patch from my queue and check later
the driver.
Best regards,
Krzysztof