2024-04-13 14:04:32

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc

In "struct rpm_cc", the 'rpm' field is unused.

Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

Apparently, it has never been used. It is not a left-over from a
refactoring.
---
drivers/clk/qcom/clk-rpm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/qcom/clk-rpm.c b/drivers/clk/qcom/clk-rpm.c
index 745026ef4d9c..9da034f8f2ff 100644
--- a/drivers/clk/qcom/clk-rpm.c
+++ b/drivers/clk/qcom/clk-rpm.c
@@ -98,7 +98,6 @@ struct clk_rpm {
};

struct rpm_cc {
- struct qcom_rpm *rpm;
struct clk_rpm **clks;
size_t num_clks;
u32 xo_buffer_value;
--
2.44.0



2024-04-20 01:57:06

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc

Quoting Christophe JAILLET (2024-04-13 07:04:04)
> In "struct rpm_cc", the 'rpm' field is unused.
>
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2024-04-21 16:07:21

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] clk: qcom: rpm: Remove an unused field in struct rpm_cc


On Sat, 13 Apr 2024 16:04:04 +0200, Christophe JAILLET wrote:
> In "struct rpm_cc", the 'rpm' field is unused.
>
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
>
> [...]

Applied, thanks!

[1/1] clk: qcom: rpm: Remove an unused field in struct rpm_cc
commit: 3cb55215479f04940240792479c60fad53c2d202

Best regards,
--
Bjorn Andersson <[email protected]>