2001-10-09 16:18:22

by White, Charles

[permalink] [raw]
Subject: [PATCH] Update to the Compaq cpqarray driver...

This patch is for 2.4.10-ac8.

This changes the driver to use the new 2.4 kernel PCI APIs. This changes
how all our cards are detected.
This adds some new IOCTLs for adding/deleting volumes while the driver
is online.
It have added code to request/release the io-region used by our cards.

It has a small fix to the flush on unload.

<<cpqarray_2.4.20D_for_2.4.10ac8.patch>>


Attachments:
cpqarray_2.4.20D_for_2.4.10ac8.patch (43.35 kB)
cpqarray_2.4.20D_for_2.4.10ac8.patch

2001-10-09 20:19:33

by Andreas Dilger

[permalink] [raw]
Subject: Re: [PATCH] Update to the Compaq cpqarray driver...

On Oct 09, 2001 11:17 -0500, White, Charles wrote:
> This patch is for 2.4.10-ac8.
>
> This changes the driver to use the new 2.4 kernel PCI APIs. This changes
> how all our cards are detected.
> This adds some new IOCTLs for adding/deleting volumes while the driver
> is online.
> It have added code to request/release the io-region used by our cards.

Minor note - static global variables are already zero initialized, so no
need for the following bit of the patch (which is also bad if MAX_CTLR
is not 8):

-static ctlr_info_t *hba[MAX_CTLR];
+static ctlr_info_t *hba[MAX_CTLR] =
+ { NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL };

For future reference, you'd want something like "hda[MAX_CTRL] = { NULL, };"
(assuming you are initializing a local array) which should do the right thing
(it initializes the rest of the array as zero).

Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert

2001-11-08 14:40:08

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] Update to the Compaq cpqarray driver for 2.4.14 kernel tree ...

On Thu, Nov 08 2001, White, Charles wrote:
> The patch is to big to include in the e-mail...
> This is version 2.4.20 of the cpqarray driver...
>
> This changes the driver to use the new 2.4 kernel PCI APIs. This changes
> how all our cards are detected.
> This adds some new IOCTLs for adding/deleting volumes while the driver
> is online.
> It have added code to request/release the io-region used by our cards.
>
> It has a small fix to the flush on unload.
>
> ftp://ftp.compaq.com/pub/products/drivers/linux/released/cpqarray/cpqarr
> ay_2.4.20D_for_2.4.14.patch

It's backing out the recent changes etc.

--
Jens Axboe