2013-03-13 05:39:47

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the final tree (staging tree related)

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/staging/dwc2/hcd.c: In function '_dwc2_hcd_urb_enqueue':
drivers/staging/dwc2/hcd.c:2387:3: error: implicit declaration of function 'bus_to_virt' [-Werror=implicit-function-declaration]
drivers/staging/dwc2/hcd.c:2387:7: warning: assignment makes pointer from integer without a cast [enabled by default]

Caused by commit 7359d482eb4d ("staging: HCD files for the DWC2 driver").

From Documentation/bus-virt-phys-mapping.txt:

"[ NOTE: The virt_to_bus() and bus_to_virt() functions have been
superseded by the functionality provided by the PCI DMA interface
(see Documentation/DMA-API-HOWTO.txt). They continue
to be documented below for historical purposes, but new code
must not use them. --davidm 00/12/12 ]"

See also Documentation/DMA-API-HOWTO.txt.

I have added this patch for today:

From: Stephen Rothwell <[email protected]>
Date: Wed, 13 Mar 2013 16:35:50 +1100
Subject: [PATCH] staging: the DWC2 driver uses bus_to_virt

Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/staging/dwc2/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/dwc2/Kconfig b/drivers/staging/dwc2/Kconfig
index 610418a..bc4cdfe 100644
--- a/drivers/staging/dwc2/Kconfig
+++ b/drivers/staging/dwc2/Kconfig
@@ -1,6 +1,7 @@
config USB_DWC2
tristate "DesignWare USB2 DRD Core Support"
depends on USB
+ depends on VIRT_TO_BUS
select USB_OTG_UTILS
help
Say Y or M here if your system has a Dual Role HighSpeed
--
1.8.1


--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (1.67 kB)
(No filename) (836.00 B)
Download all attachments

2013-03-14 20:23:54

by Paul Zimmerman

[permalink] [raw]
Subject: RE: linux-next: build failure after merge of the final tree (staging tree related)

> From: Stephen Rothwell [mailto:[email protected]]
> Sent: Tuesday, March 12, 2013 10:40 PM
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/staging/dwc2/hcd.c: In function '_dwc2_hcd_urb_enqueue':
> drivers/staging/dwc2/hcd.c:2387:3: error: implicit declaration of function 'bus_to_virt' [-Werror=implicit-function-declaration]
> drivers/staging/dwc2/hcd.c:2387:7: warning: assignment makes pointer from integer without a cast [enabled by default]
>
> Caused by commit 7359d482eb4d ("staging: HCD files for the DWC2 driver").
>
> From Documentation/bus-virt-phys-mapping.txt:
>
> "[ NOTE: The virt_to_bus() and bus_to_virt() functions have been
> superseded by the functionality provided by the PCI DMA interface
> (see Documentation/DMA-API-HOWTO.txt). They continue
> to be documented below for historical purposes, but new code
> must not use them. --davidm 00/12/12 ]"
>
> See also Documentation/DMA-API-HOWTO.txt.
>
> I have added this patch for today:
>
> From: Stephen Rothwell <[email protected]>
> Date: Wed, 13 Mar 2013 16:35:50 +1100
> Subject: [PATCH] staging: the DWC2 driver uses bus_to_virt
>
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> drivers/staging/dwc2/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/dwc2/Kconfig b/drivers/staging/dwc2/Kconfig
> index 610418a..bc4cdfe 100644
> --- a/drivers/staging/dwc2/Kconfig
> +++ b/drivers/staging/dwc2/Kconfig
> @@ -1,6 +1,7 @@
> config USB_DWC2
> tristate "DesignWare USB2 DRD Core Support"
> depends on USB
> + depends on VIRT_TO_BUS
> select USB_OTG_UTILS
> help
> Say Y or M here if your system has a Dual Role HighSpeed
> --

Hi Greg,

Do you apply these sort of patches automatically, or do you need an ack from me?
In case you do:

Acked-by: Paul Zimmerman <[email protected]>

2013-03-14 20:33:57

by Greg KH

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the final tree (staging tree related)

On Thu, Mar 14, 2013 at 08:23:39PM +0000, Paul Zimmerman wrote:
> > From: Stephen Rothwell [mailto:[email protected]]
> > Sent: Tuesday, March 12, 2013 10:40 PM
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/staging/dwc2/hcd.c: In function '_dwc2_hcd_urb_enqueue':
> > drivers/staging/dwc2/hcd.c:2387:3: error: implicit declaration of function 'bus_to_virt' [-Werror=implicit-function-declaration]
> > drivers/staging/dwc2/hcd.c:2387:7: warning: assignment makes pointer from integer without a cast [enabled by default]
> >
> > Caused by commit 7359d482eb4d ("staging: HCD files for the DWC2 driver").
> >
> > From Documentation/bus-virt-phys-mapping.txt:
> >
> > "[ NOTE: The virt_to_bus() and bus_to_virt() functions have been
> > superseded by the functionality provided by the PCI DMA interface
> > (see Documentation/DMA-API-HOWTO.txt). They continue
> > to be documented below for historical purposes, but new code
> > must not use them. --davidm 00/12/12 ]"
> >
> > See also Documentation/DMA-API-HOWTO.txt.
> >
> > I have added this patch for today:
> >
> > From: Stephen Rothwell <[email protected]>
> > Date: Wed, 13 Mar 2013 16:35:50 +1100
> > Subject: [PATCH] staging: the DWC2 driver uses bus_to_virt
> >
> > Signed-off-by: Stephen Rothwell <[email protected]>
> > ---
> > drivers/staging/dwc2/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/dwc2/Kconfig b/drivers/staging/dwc2/Kconfig
> > index 610418a..bc4cdfe 100644
> > --- a/drivers/staging/dwc2/Kconfig
> > +++ b/drivers/staging/dwc2/Kconfig
> > @@ -1,6 +1,7 @@
> > config USB_DWC2
> > tristate "DesignWare USB2 DRD Core Support"
> > depends on USB
> > + depends on VIRT_TO_BUS
> > select USB_OTG_UTILS
> > help
> > Say Y or M here if your system has a Dual Role HighSpeed
> > --
>
> Hi Greg,
>
> Do you apply these sort of patches automatically, or do you need an ack from me?
> In case you do:
>
> Acked-by: Paul Zimmerman <[email protected]>

Thanks, I'll take it, I hadn't gotten to this fix just yet.

greg k-h