2013-05-30 10:24:41

by Yijing Wang

Subject: [PATCH 5/7] dwc2: remove redundant D0 power state set

Pci_enable_device() will set device power state to D0,
so it's no need to do it again in dwc2_driver_probe().

Signed-off-by: Yijing Wang <[email protected]>
---
drivers/staging/dwc2/pci.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c
index 69c65eb..6a196c2 100644
--- a/drivers/staging/dwc2/pci.c
+++ b/drivers/staging/dwc2/pci.c
@@ -131,8 +131,6 @@ static int dwc2_driver_probe(struct pci_dev *dev,
if (!hsotg)
return -ENOMEM;

- pci_set_power_state(dev, PCI_D0);
-
hsotg->dev = &dev->dev;
hsotg->regs = devm_request_and_ioremap(&dev->dev, &dev->resource[0]);
if (!hsotg->regs)
--
1.7.1

2013-05-30 18:19:22

by Paul Zimmerman

Subject: RE: [PATCH 5/7] dwc2: remove redundant D0 power state set

> From: Yijing Wang [mailto:[email protected]]
> Sent: Thursday, May 30, 2013 3:24 AM
>
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in dwc2_driver_probe().
>
> Signed-off-by: Yijing Wang <[email protected]>
> ---
> drivers/staging/dwc2/pci.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dwc2/pci.c b/drivers/staging/dwc2/pci.c
> index 69c65eb..6a196c2 100644
> --- a/drivers/staging/dwc2/pci.c
> +++ b/drivers/staging/dwc2/pci.c
> @@ -131,8 +131,6 @@ static int dwc2_driver_probe(struct pci_dev *dev,
> if (!hsotg)
> return -ENOMEM;
>
> - pci_set_power_state(dev, PCI_D0);
> -
> hsotg->dev = &dev->dev;
> hsotg->regs = devm_request_and_ioremap(&dev->dev, &dev->resource[0]);
> if (!hsotg->regs)
> --
> 1.7.1

Acked-by: Paul Zimmerman <[email protected]>