2014-12-02 23:54:03

by KY Srinivasan

[permalink] [raw]
Subject: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

The clocksource based on Hyper-V per-partition reference count MSR is
continuous. Mark it accordingly.

Signed-off-by: K. Y. Srinivasan <[email protected]>
cc: [email protected]
---
arch/x86/kernel/cpu/mshyperv.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index a450373..939155f 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
.rating = 400, /* use this when running on Hyperv*/
.read = read_hv_clock,
.mask = CLOCKSOURCE_MASK(64),
+ .flags = CLOCK_SOURCE_IS_CONTINUOUS,
};

static void __init ms_hyperv_init_platform(void)
--
1.7.4.1


2014-12-03 00:04:23

by Jeff Leung

[permalink] [raw]
Subject: RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

Does this mean that host-to guest timesync now works properly with Linux
guests?

-- Jeff

> -----Original Message-----
> From: [email protected]
[mailto:[email protected]]
> On Behalf Of K. Y. Srinivasan
> Sent: Tuesday, December 2, 2014 17:04
> To: [email protected]; [email protected];
[email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]
> Cc: K. Y. Srinivasan; [email protected]
> Subject: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being
continuous
>
> The clocksource based on Hyper-V per-partition reference count MSR is
continuous. Mark
> it accordingly.
>
> Signed-off-by: K. Y. Srinivasan <[email protected]>
> cc: [email protected]
> ---
> arch/x86/kernel/cpu/mshyperv.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mshyperv.c
b/arch/x86/kernel/cpu/mshyperv.c index
> a450373..939155f 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
> .rating = 400, /* use this when running on Hyperv*/
> .read = read_hv_clock,
> .mask = CLOCKSOURCE_MASK(64),
> + .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> };
>
> static void __init ms_hyperv_init_platform(void)
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in the body of a
> message to [email protected] More majordomo info at
> http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2014-12-03 00:06:51

by KY Srinivasan

[permalink] [raw]
Subject: RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous



> -----Original Message-----
> From: Jeff Leung [mailto:[email protected]]
> Sent: Tuesday, December 2, 2014 3:58 PM
> To: KY Srinivasan; [email protected]; [email protected]; linux-
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Cc: [email protected]
> Subject: RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being
> continuous
>
> Does this mean that host-to guest timesync now works properly with Linux
> guests?
>
> -- Jeff

Jeff,

We have had the Hyper-V clocksource for sometime now and this patch just marks this clocksource
as being continuous. Nothing has changed with regards to timesynch.

Regards,

K. Y

>
> > -----Original Message-----
> > From: [email protected]
> [mailto:[email protected]]
> > On Behalf Of K. Y. Srinivasan
> > Sent: Tuesday, December 2, 2014 17:04
> > To: [email protected]; [email protected];
> [email protected];
> > [email protected]; [email protected]; [email protected];
> > [email protected]; [email protected]; [email protected]
> > Cc: K. Y. Srinivasan; [email protected]
> > Subject: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being
> continuous
> >
> > The clocksource based on Hyper-V per-partition reference count MSR is
> continuous. Mark
> > it accordingly.
> >
> > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > cc: [email protected]
> > ---
> > arch/x86/kernel/cpu/mshyperv.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/x86/kernel/cpu/mshyperv.c
> b/arch/x86/kernel/cpu/mshyperv.c index
> > a450373..939155f 100644
> > --- a/arch/x86/kernel/cpu/mshyperv.c
> > +++ b/arch/x86/kernel/cpu/mshyperv.c
> > @@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
> > .rating = 400, /* use this when running on Hyperv*/
> > .read = read_hv_clock,
> > .mask = CLOCKSOURCE_MASK(64),
> > + .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> > };
> >
> > static void __init ms_hyperv_init_platform(void)
> > --
> > 1.7.4.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in the body of a
> > message to [email protected] More majordomo info at
> > http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/

2014-12-03 00:14:11

by Jeff Leung

[permalink] [raw]
Subject: RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

> We have had the Hyper-V clocksource for sometime now and this patch
just marks this
> clocksource as being continuous. Nothing has changed with regards to
timesynch.

Alright, that cleared up that question. Gleaning around from the source
tree, I don't seem to
comprehend what changes are being made when the clock source has the
flag
CLOCK_SOURCE_IS_CONTINUOUS marked.

> Regards,
>
> K. Y
>
> >
> > > -----Original Message-----
> > > From: [email protected]
> > [mailto:[email protected]]
> > > On Behalf Of K. Y. Srinivasan
> > > Sent: Tuesday, December 2, 2014 17:04
> > > To: [email protected]; [email protected];
> > [email protected];
> > > [email protected]; [email protected]; [email protected];
> > > [email protected]; [email protected]; [email protected]
> > > Cc: K. Y. Srinivasan; [email protected]
> > > Subject: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being
> > continuous
> > >
> > > The clocksource based on Hyper-V per-partition reference count MSR
> > > is
> > continuous. Mark
> > > it accordingly.
> > >
> > > Signed-off-by: K. Y. Srinivasan <[email protected]>
> > > cc: [email protected]
> > > ---
> > > arch/x86/kernel/cpu/mshyperv.c | 1 +
> > > 1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/x86/kernel/cpu/mshyperv.c
> > b/arch/x86/kernel/cpu/mshyperv.c index
> > > a450373..939155f 100644
> > > --- a/arch/x86/kernel/cpu/mshyperv.c
> > > +++ b/arch/x86/kernel/cpu/mshyperv.c
> > > @@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
> > > .rating = 400, /* use this when running on Hyperv*/
> > > .read = read_hv_clock,
> > > .mask = CLOCKSOURCE_MASK(64),
> > > + .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> > > };
> > >
> > > static void __init ms_hyperv_init_platform(void)
> > > --
> > > 1.7.4.1
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > linux-kernel" in the body of a
> > > message to [email protected] More majordomo info at
> > > http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at http://www.tux.org/lkml/
>

2014-12-29 21:32:48

by KY Srinivasan

[permalink] [raw]
Subject: RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous



> -----Original Message-----
> From: K. Y. Srinivasan [mailto:[email protected]]
> Sent: Tuesday, December 2, 2014 5:04 PM
> To: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Cc: KY Srinivasan; [email protected]
> Subject: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous
>
> The clocksource based on Hyper-V per-partition reference count MSR is
> continuous. Mark it accordingly.

Thomas,

If there are no issues, please pickup this patch.

Regards,

K. Y
>
> Signed-off-by: K. Y. Srinivasan <[email protected]>
> cc: [email protected]
> ---
> arch/x86/kernel/cpu/mshyperv.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mshyperv.c
> b/arch/x86/kernel/cpu/mshyperv.c index a450373..939155f 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -107,6 +107,7 @@ static struct clocksource hyperv_cs = {
> .rating = 400, /* use this when running on Hyperv*/
> .read = read_hv_clock,
> .mask = CLOCKSOURCE_MASK(64),
> + .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> };
>
> static void __init ms_hyperv_init_platform(void)
> --
> 1.7.4.1