2014-11-12 01:27:50

by bpqw

[permalink] [raw]
Subject: RE: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

>Signed-off-by: bean huo <[email protected]>
>Signed-off-by: bpqw <[email protected]>
>---
>V2:
> - Add signed-off-by
> - Modify commit logs that wrapped to less than 80 columns

Dear maintainers:

Please give some tips,if this patch is OK?thanks!


2014-11-12 09:02:31

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

On Wed, Nov 12, 2014 at 01:26:58AM +0000, bpqw wrote:
> >Signed-off-by: bean huo <[email protected]>
> >Signed-off-by: bpqw <[email protected]>
> >---
> >V2:
> > - Add signed-off-by
> > - Modify commit logs that wrapped to less than 80 columns
>
> Dear maintainers:
>
> Please give some tips,if this patch is OK?thanks!

Patch looks okay to me content-wise, but you might want to use proper
names and capitalization for the From: and Signed-off-by: lines. bpqw
doesn't look like a real name to me, and "bean huo" should probably
be "Bean Huo".

Thierry


Attachments:
(No filename) (556.00 B)
(No filename) (819.00 B)
Download all attachments

2014-11-12 14:17:42

by bpqw

[permalink] [raw]
Subject: RE: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

>Patch looks okay to me content-wise, but you might want to use proper names and
>capitalization for the From: and Signed-off-by: lines. bpqw doesn't look like a real name to me, and "bean huo" should probably be "Bean Huo".

>Thierry

Thanks,will modify it and submit V3.