2012-11-29 08:48:34

by Kim, Milo

Subject: [PATCH 1/2] mfd: tps65910: remove unused data

The 'io_mutex' is not used anywhere.
The regmap API supports the mutex internally, so no additional mutex required.

And 'domain' private data is unnecessary because the irq domain is
already registered by using regmap_add_irq_chip().

Signed-off-by: Milo(Woogyom) Kim <[email protected]>
---
drivers/mfd/tps65910.c | 1 -
include/linux/mfd/tps65910.h | 2 --
2 files changed, 3 deletions(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index fdb3027..d5ef3a5 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -486,7 +486,6 @@ static __devinit int tps65910_i2c_probe(struct i2c_client *i2c,
tps65910->dev = &i2c->dev;
tps65910->i2c_client = i2c;
tps65910->id = chip_id;
- mutex_init(&tps65910->io_mutex);

tps65910->regmap = devm_regmap_init_i2c(i2c, &tps65910_regmap_config);
if (IS_ERR(tps65910->regmap)) {
diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h
index 0b16903..20e433e 100644
--- a/include/linux/mfd/tps65910.h
+++ b/include/linux/mfd/tps65910.h
@@ -893,7 +893,6 @@ struct tps65910 {
struct device *dev;
struct i2c_client *i2c_client;
struct regmap *regmap;
- struct mutex io_mutex;
unsigned int id;

/* Client devices */
@@ -907,7 +906,6 @@ struct tps65910 {
/* IRQ Handling */
int chip_irq;
struct regmap_irq_chip_data *irq_data;
- struct irq_domain *domain;
};

struct tps65910_platform_data {
--
1.7.9.5


Best Regards,
Milo

2012-11-29 19:19:12

by Laxman Dewangan

Subject: Re: [PATCH 1/2] mfd: tps65910: remove unused data

On Thursday 29 November 2012 02:18 PM, Kim, Milo wrote:
> The 'io_mutex' is not used anywhere.
> The regmap API supports the mutex internally, so no additional mutex required.
>
> And 'domain' private data is unnecessary because the irq domain is
> already registered by using regmap_add_irq_chip().
>
> Signed-off-by: Milo(Woogyom) Kim<[email protected]>
> ---

Thanks, I missed on my cleanups.

Acked-by: Laxman Dewangan <[email protected]>
> drivers/mfd/tps65910.c | 1 -
> include/linux/mfd/tps65910.h | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index fdb3027..d5ef3a5 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -486,7 +486,6 @@ static __devinit int tps65910_i2c_probe(struct i2c_client *i2c,
> tps65910->dev =&i2c->dev;
> tps65910->i2c_client = i2c;
> tps65910->id = chip_id;
> - mutex_init(&tps65910->io_mutex);
>
> tps65910->regmap = devm_regmap_init_i2c(i2c,&tps65910_regmap_config);
> if (IS_ERR(tps65910->regmap)) {
> diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h
> index 0b16903..20e433e 100644
> --- a/include/linux/mfd/tps65910.h
> +++ b/include/linux/mfd/tps65910.h
> @@ -893,7 +893,6 @@ struct tps65910 {
> struct device *dev;
> struct i2c_client *i2c_client;
> struct regmap *regmap;
> - struct mutex io_mutex;
> unsigned int id;
>
> /* Client devices */
> @@ -907,7 +906,6 @@ struct tps65910 {
> /* IRQ Handling */
> int chip_irq;
> struct regmap_irq_chip_data *irq_data;
> - struct irq_domain *domain;
> };
>
> struct tps65910_platform_data {

2012-11-30 11:22:28

by Samuel Ortiz

Subject: Re: [PATCH 1/2] mfd: tps65910: remove unused data

Hi Milo,

On Thu, Nov 29, 2012 at 08:48:26AM +0000, Kim, Milo wrote:
> The 'io_mutex' is not used anywhere.
> The regmap API supports the mutex internally, so no additional mutex required.
>
> And 'domain' private data is unnecessary because the irq domain is
> already registered by using regmap_add_irq_chip().
>
> Signed-off-by: Milo(Woogyom) Kim <[email protected]>
> ---
> drivers/mfd/tps65910.c | 1 -
> include/linux/mfd/tps65910.h | 2 --
> 2 files changed, 3 deletions(-)
Applied, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/