2020-04-19 09:38:58

by Markus Elfring

[permalink] [raw]
Subject: Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()

> The "if(!encoder)" branch return the same value 0 of the success
> branch, maybe return -EINVAL is more better.

I suggest to improve the commit message.

* Would you like to adjust the patch subject?

* How do you think about to add the tag “Fixes”
because of adjustments for the exception handling?

Regards,
Markus


2020-04-20 01:06:15

by 赵军奎

[permalink] [raw]
Subject: Re:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()



发件人:Markus Elfring <[email protected]>
发送日期:2020-04-19 17:34:47
收件人:Bernard Zhao <[email protected]>,[email protected],[email protected],Alex Deucher <[email protected]>,"Christian König" <[email protected]>,Chunming Zhou <[email protected]>
抄送人:Andrzej Pietrasiewicz <[email protected]>,Daniel Vetter <[email protected]>,David Airlie <[email protected]>,Dhinakaran Pandiyan <[email protected]>,"José Roberto de Souza" <[email protected]>,Lyude Paul <[email protected]>,Neil Armstrong <[email protected]>,Sam Ravnborg <[email protected]>,[email protected],[email protected]
主题:Re: [PATCH] drm/amdgpu: Return more error codes in amdgpu_connector_set_property()>> The "if(!encoder)" branch return the same value 0 of the success
>> branch, maybe return -EINVAL is more better.
>
>I suggest to improve the commit message.

Sure.

>
>* Would you like to adjust the patch subject?
>
>* How do you think about to add the tag “Fixes”
> because of adjustments for the exception handling?

This is a good idea, the code will be more in line with the Linux specifications.
I will adjust this patch commit message and modify the code. I will submit it again.

>
>Regards,
>Markus