2013-06-18 07:20:13

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the final tree (mfd tree related)

---

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/mfd/88pm800.c: In function 'pm800_pages_init':
drivers/mfd/88pm800.c:434:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
if (IS_ERR(subchip->regmap_power)) {
^
drivers/mfd/88pm800.c:435:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
ret = PTR_ERR(subchip->regmap_power);
^

Caused by commit f8ca616f67f7 ("mfd: 88pm800: Enhance error handling for
sub pages probe/remove") from the mfd tree. Forgot to include
linux/err.h (see Rule 1 in Documentation/SubmitChecklist).

I have reverted that commit for today.
--
Cheers,
Stephen Rothwell [email protected]

---

Attachments:

(No filename) (792.00 B)
(No filename) (836.00 B)
Download all attachments

2013-06-19 08:25:04

by Samuel Ortiz

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the final tree (mfd tree related)

---

Hi Stephen,

On Tue, Jun 18, 2013 at 05:19:57PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/mfd/88pm800.c: In function 'pm800_pages_init':
> drivers/mfd/88pm800.c:434:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
> if (IS_ERR(subchip->regmap_power)) {
> ^
> drivers/mfd/88pm800.c:435:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
> ret = PTR_ERR(subchip->regmap_power);
> ^
>
> Caused by commit f8ca616f67f7 ("mfd: 88pm800: Enhance error handling for
> sub pages probe/remove") from the mfd tree. Forgot to include
> linux/err.h (see Rule 1 in Documentation/SubmitChecklist).
Sorry about that. This is fixed now.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/

2013-06-20 02:27:47

by Chao Xie

[permalink] [raw]

Subject: RE: linux-next: build failure after merge of the final tree (mfd tree related)

---

> -----Original Message-----
> From: Samuel Ortiz [mailto:[email protected]]
> Sent: Wednesday, June 19, 2013 4:25 PM
> To: Stephen Rothwell
> Cc: [email protected]; [email protected]; Chao Xie; Yi Zhang
> Subject: Re: linux-next: build failure after merge of the final tree (mfd tree related)

> Hi Stephen,

>>On Tue, Jun 18, 2013 at 05:19:57PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the final tree, today's linux-next build (powerpc
>> allyesconfig) failed like this:
>>
>> drivers/mfd/88pm800.c: In function 'pm800_pages_init':
>> drivers/mfd/88pm800.c:434:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
>> if (IS_ERR(subchip->regmap_power)) {
>> ^
>> drivers/mfd/88pm800.c:435:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]
>> ret = PTR_ERR(subchip->regmap_power);
>> ^
>>
>> Caused by commit f8ca616f67f7 ("mfd: 88pm800: Enhance error handling for
>> sub pages probe/remove") from the mfd tree. Forgot to include
>> linux/err.h (see Rule 1 in Documentation/SubmitChecklist).
>Sorry about that. This is fixed now.

It is my fault. Thanks for fixing it.

> Cheers,
> Samuel.

> --
> Intel Open Source Technology Centre
> http://oss.intel.com/