2011-03-08 14:01:51

by Daniel J Blueman

Subject: [2.6.38-rc8, patch] minor ANSI prototype sparse fix

Fix function prototype to be ANSI-C compliant, consistent with other
function prototypes, addressing a sparse warning.

Signed-off-by: Daniel J Blueman <[email protected]>

diff --git a/kernel/module.c b/kernel/module.c
index efa290e..be35185 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1627,7 +1627,7 @@ void unset_section_ro_nx(struct module *mod,
void *module_region)
}

/* Iterate through all modules and set each module's text as RW */
-void set_all_modules_text_rw()
+void set_all_modules_text_rw(void)
{
struct module *mod;

@@ -1648,7 +1648,7 @@ void set_all_modules_text_rw()
}

/* Iterate through all modules and set each module's text as RO */
-void set_all_modules_text_ro()
+void set_all_modules_text_ro(void)
{
struct module *mod;

--
Daniel J Blueman

2011-03-11 03:38:04

by Rusty Russell

Subject: Re: [2.6.38-rc8, patch] minor ANSI prototype sparse fix

On Tue, 8 Mar 2011 22:01:47 +0800, Daniel J Blueman <[email protected]> wrote:
> Fix function prototype to be ANSI-C compliant, consistent with other
> function prototypes, addressing a sparse warning.
>
> Signed-off-by: Daniel J Blueman <[email protected]>

Thanks, applied.

FYI: your patch was line-wrapped, fixed manually:

> diff --git a/kernel/module.c b/kernel/module.c
> index efa290e..be35185 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -1627,7 +1627,7 @@ void unset_section_ro_nx(struct module *mod,
> void *module_region)
> }
>

Cheers,
Rusty.