2011-02-14 10:37:02

by Dmitry Baryshkov

Subject: [PATCH] tosa-bt: drop setting LED trigger name, as it's unsupported now

Since 2e48928d8a0f38c1b5c81eb3f1294de8a6382c68 it's no longer possible to set
the name of the LED trigger for RFKILL events. Drop respective code from tosa-bt.c

Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
Cc: Stephen Hemminger <[email protected]>
Cc: John W. Linville <[email protected]>
---
arch/arm/mach-pxa/tosa-bt.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-pxa/tosa-bt.c b/arch/arm/mach-pxa/tosa-bt.c
index c31e601..b9b1e5c 100644
--- a/arch/arm/mach-pxa/tosa-bt.c
+++ b/arch/arm/mach-pxa/tosa-bt.c
@@ -81,8 +81,6 @@ static int tosa_bt_probe(struct platform_device *dev)
goto err_rfk_alloc;
}

- rfkill_set_led_trigger_name(rfk, "tosa-bt");
-
rc = rfkill_register(rfk);
if (rc)
goto err_rfkill;
--
1.7.2.3

2011-02-18 06:20:24

by Eric Miao

Subject: Re: [PATCH] tosa-bt: drop setting LED trigger name, as it's unsupported now

On Mon, Feb 14, 2011 at 6:36 PM, Dmitry Eremin-Solenikov
<[email protected]> wrote:
> Since 2e48928d8a0f38c1b5c81eb3f1294de8a6382c68 it's no longer possible to set
> the name of the LED trigger for RFKILL events. Drop respective code from tosa-bt.c
>
> Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
> Cc: Stephen Hemminger <[email protected]>
> Cc: John W. Linville <[email protected]>

Applied to 'fix'.

I hope there is no existing user of this trigger name, but you know
better than I do.

> ---
>  arch/arm/mach-pxa/tosa-bt.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/tosa-bt.c b/arch/arm/mach-pxa/tosa-bt.c
> index c31e601..b9b1e5c 100644
> --- a/arch/arm/mach-pxa/tosa-bt.c
> +++ b/arch/arm/mach-pxa/tosa-bt.c
> @@ -81,8 +81,6 @@ static int tosa_bt_probe(struct platform_device *dev)
>                goto err_rfk_alloc;
>        }
>
> -       rfkill_set_led_trigger_name(rfk, "tosa-bt");
> -
>        rc = rfkill_register(rfk);
>        if (rc)
>                goto err_rfkill;
> --
> 1.7.2.3
>
>