2011-03-14 17:27:33

by Prasad Joshi

Subject: [RFC][PATCH v2 00/23] (alpha) __vmalloc: add gfp flags variant of pte and pmd allocation

__vmalloc: propagating GFP allocation flag.

- adds functions to allow caller to pass the GFP flag for memory allocation
- helps in fixing the Bug 30702 (__vmalloc(GFP_NOFS) can callback
file system evict_inode).

Signed-off-by: Anand Mitra <[email protected]>
Signed-off-by: Prasad Joshi <[email protected]>
---
Chnagelog:
arch/alpha/include/asm/pgalloc.h | 18 ++++++++++++++----
1 files changed, 14 insertions(+), 4 deletions(-)
---
diff --git a/arch/alpha/include/asm/pgalloc.h b/arch/alpha/include/asm/pgalloc.h
index bc2a0da..d05dfc2 100644
--- a/arch/alpha/include/asm/pgalloc.h
+++ b/arch/alpha/include/asm/pgalloc.h
@@ -38,10 +38,15 @@ pgd_free(struct mm_struct *mm, pgd_t *pgd)
}

static inline pmd_t *
+__pmd_alloc_one(struct mm_struct *mm, unsigned long address, gfp_t gfp_mask)
+{
+ return (pmd_t *)__get_free_page(gfp_mask | __GFP_ZERO);
+}
+
+static inline pmd_t *
pmd_alloc_one(struct mm_struct *mm, unsigned long address)
{
- pmd_t *ret = (pmd_t *)__get_free_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO);
- return ret;
+ return __pmd_alloc_one(mm, address, GFP_KERNEL | __GFP_REPEAT);
}

static inline void
@@ -51,10 +56,15 @@ pmd_free(struct mm_struct *mm, pmd_t *pmd)
}

static inline pte_t *
+__pte_alloc_one_kernel(struct mm_struct *mm, unsigned long addressi,
gfp_t gfp_mask)
+{
+ return (pte_t *)__get_free_page(gfp_mask | __GFP_ZERO);
+}
+
+static inline pte_t *
pte_alloc_one_kernel(struct mm_struct *mm, unsigned long address)
{
- pte_t *pte = (pte_t *)__get_free_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO);
- return pte;
+ return __pte_alloc_one_kernel(mm, address, GFP_KERNEL | __GFP_REPEAT);
}

static inline void

2011-03-14 20:55:05

by David Rientjes

Subject: Re: [RFC][PATCH v2 00/23] (alpha) __vmalloc: add gfp flags variant of pte and pmd allocation

On Mon, 14 Mar 2011, Prasad Joshi wrote:

> __vmalloc: propagating GFP allocation flag.
>

This isn't the correct title of the patch. You don't need to actually
give them titles, the subject line will be used instead.

The subject line should also indicate this as patch 01/2 and it should
read "mm, alpha: add gfp flags variant of pte and pmd allocations".

> - adds functions to allow caller to pass the GFP flag for memory allocation
> - helps in fixing the Bug 30702 (__vmalloc(GFP_NOFS) can callback
> file system evict_inode).
>
> Signed-off-by: Anand Mitra <[email protected]>
> Signed-off-by: Prasad Joshi <[email protected]>

The first signed-off-by line usually indicates the author of the change in
which case this would require the first line of the email to be

From: Anand Mitra <[email protected]>

if that's the correct attribution.

> ---
> Chnagelog:
> arch/alpha/include/asm/pgalloc.h | 18 ++++++++++++++----
> 1 files changed, 14 insertions(+), 4 deletions(-)
> ---
> diff --git a/arch/alpha/include/asm/pgalloc.h b/arch/alpha/include/asm/pgalloc.h
> index bc2a0da..d05dfc2 100644
> --- a/arch/alpha/include/asm/pgalloc.h
> +++ b/arch/alpha/include/asm/pgalloc.h
> @@ -38,10 +38,15 @@ pgd_free(struct mm_struct *mm, pgd_t *pgd)
> }
>
> static inline pmd_t *
> +__pmd_alloc_one(struct mm_struct *mm, unsigned long address, gfp_t gfp_mask)
> +{
> + return (pmd_t *)__get_free_page(gfp_mask | __GFP_ZERO);
> +}
> +
> +static inline pmd_t *
> pmd_alloc_one(struct mm_struct *mm, unsigned long address)
> {
> - pmd_t *ret = (pmd_t *)__get_free_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO);
> - return ret;
> + return __pmd_alloc_one(mm, address, GFP_KERNEL | __GFP_REPEAT);
> }
>
> static inline void
> @@ -51,10 +56,15 @@ pmd_free(struct mm_struct *mm, pmd_t *pmd)
> }
>
> static inline pte_t *
> +__pte_alloc_one_kernel(struct mm_struct *mm, unsigned long addressi,
> gfp_t gfp_mask)

This patch is corrupt probably because of your email client (and all other
patches in this series are corrupt, as well). Please see
Documentation/email-clients.txt and try sending test patches to a
colleague and git-apply them first.

BTW, s/addressi/address/ for this function definition.

> +{
> + return (pte_t *)__get_free_page(gfp_mask | __GFP_ZERO);
> +}
> +
> +static inline pte_t *
> pte_alloc_one_kernel(struct mm_struct *mm, unsigned long address)
> {
> - pte_t *pte = (pte_t *)__get_free_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO);
> - return pte;
> + return __pte_alloc_one_kernel(mm, address, GFP_KERNEL | __GFP_REPEAT);
> }
>
> static inline void