2010-06-30 16:02:37

by Christoph Egger

Subject: [PATCH 27/33] Removing dead IDE_PXA_CF

IDE_PXA_CF doesn't exist in Kconfig, therefore removing all references
for it from the source code.

Signed-off-by: Christoph Egger <[email protected]>
---
arch/arm/mach-pxa/trizeps4.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-pxa/trizeps4.c b/arch/arm/mach-pxa/trizeps4.c
index 6968911..0acff17 100644
--- a/arch/arm/mach-pxa/trizeps4.c
+++ b/arch/arm/mach-pxa/trizeps4.c
@@ -530,13 +530,9 @@ static void __init trizeps4_init(void)
i2c_register_board_info(0, trizeps4_i2c_devices,
ARRAY_SIZE(trizeps4_i2c_devices));

-#ifdef CONFIG_IDE_PXA_CF
- /* if boot direct from compact flash dont disable power */
- trizeps_conxs_bcr = 0x0009;
-#else
/* this is the reset value */
trizeps_conxs_bcr = 0x00A0;
-#endif
+
BCR_writew(trizeps_conxs_bcr);
board_backlight_power(1);
}
--
1.7.0.4

2010-06-30 18:19:49

by Marek Vasut

Subject: Re: [PATCH 27/33] Removing dead IDE_PXA_CF

Dne St 30. června 2010 18:02:32 Christoph Egger napsal(a):
> IDE_PXA_CF doesn't exist in Kconfig, therefore removing all references
> for it from the source code.

This thing would be on purpose I believe ... maybe documenting it better won't
hurt though.
>
> Signed-off-by: Christoph Egger <[email protected]>
> ---
> arch/arm/mach-pxa/trizeps4.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/trizeps4.c b/arch/arm/mach-pxa/trizeps4.c
> index 6968911..0acff17 100644
> --- a/arch/arm/mach-pxa/trizeps4.c
> +++ b/arch/arm/mach-pxa/trizeps4.c
> @@ -530,13 +530,9 @@ static void __init trizeps4_init(void)
> i2c_register_board_info(0, trizeps4_i2c_devices,
> ARRAY_SIZE(trizeps4_i2c_devices));
>
> -#ifdef CONFIG_IDE_PXA_CF
> - /* if boot direct from compact flash dont disable power */
> - trizeps_conxs_bcr = 0x0009;
> -#else
> /* this is the reset value */
> trizeps_conxs_bcr = 0x00A0;
> -#endif
> +
> BCR_writew(trizeps_conxs_bcr);
> board_backlight_power(1);
> }

2010-07-01 02:56:53

by Eric Miao

Subject: Re: [PATCH 27/33] Removing dead IDE_PXA_CF

On Thu, Jul 1, 2010 at 12:02 AM, Christoph Egger <[email protected]> wrote:
> IDE_PXA_CF doesn't exist in Kconfig, therefore removing all references
> for it from the source code.
>
> Signed-off-by: Christoph Egger <[email protected]>

Acked-by: Eric Miao <[email protected]>

Include Jurgen though, in case he has any idea.

> ---
>  arch/arm/mach-pxa/trizeps4.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/trizeps4.c b/arch/arm/mach-pxa/trizeps4.c
> index 6968911..0acff17 100644
> --- a/arch/arm/mach-pxa/trizeps4.c
> +++ b/arch/arm/mach-pxa/trizeps4.c
> @@ -530,13 +530,9 @@ static void __init trizeps4_init(void)
>        i2c_register_board_info(0, trizeps4_i2c_devices,
>                                        ARRAY_SIZE(trizeps4_i2c_devices));
>
> -#ifdef CONFIG_IDE_PXA_CF
> -       /* if boot direct from compact flash dont disable power */
> -       trizeps_conxs_bcr = 0x0009;
> -#else
>        /* this is the reset value */
>        trizeps_conxs_bcr = 0x00A0;
> -#endif
> +
>        BCR_writew(trizeps_conxs_bcr);
>        board_backlight_power(1);
>  }
> --
> 1.7.0.4
>
>