2010-11-24 08:39:17

by Axel Lin

Subject: [PATCH] ASoC: nuc900-ac97: fix a memory leak

Signed-off-by: Axel Lin <[email protected]>
---
sound/soc/nuc900/nuc900-ac97.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index 293dc74..e00e39d 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -384,7 +384,6 @@ out0:

static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
{
-
snd_soc_unregister_dai(&pdev->dev);

clk_put(nuc900_ac97_data->clk);
@@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
release_mem_region(nuc900_ac97_data->res->start,
resource_size(nuc900_ac97_data->res));

+ kfree(nuc900_ac97_data);
nuc900_ac97_data = NULL;

return 0;
--
1.7.2

2010-11-24 10:51:28

by Liam Girdwood

Subject: Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

On Wed, 2010-11-24 at 16:44 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>
> ---
> sound/soc/nuc900/nuc900-ac97.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
> index 293dc74..e00e39d 100644
> --- a/sound/soc/nuc900/nuc900-ac97.c
> +++ b/sound/soc/nuc900/nuc900-ac97.c
> @@ -384,7 +384,6 @@ out0:
>
> static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
> {
> -
> snd_soc_unregister_dai(&pdev->dev);
>
> clk_put(nuc900_ac97_data->clk);
> @@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
> release_mem_region(nuc900_ac97_data->res->start,
> resource_size(nuc900_ac97_data->res));
>
> + kfree(nuc900_ac97_data);
> nuc900_ac97_data = NULL;
>
> return 0;


Acked-by: Liam Girdwood <[email protected]>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

2010-11-24 11:31:17

by Wan ZongShun

Subject: Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

2010/11/24 Liam Girdwood <[email protected]>:
> On Wed, 2010-11-24 at 16:44 +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <[email protected]>
>> ---
>>  sound/soc/nuc900/nuc900-ac97.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
>> index 293dc74..e00e39d 100644
>> --- a/sound/soc/nuc900/nuc900-ac97.c
>> +++ b/sound/soc/nuc900/nuc900-ac97.c
>> @@ -384,7 +384,6 @@ out0:
>>
>>  static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>>  {
>> -
>>       snd_soc_unregister_dai(&pdev->dev);
>>
>>       clk_put(nuc900_ac97_data->clk);
>> @@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>>       release_mem_region(nuc900_ac97_data->res->start,
>>                               resource_size(nuc900_ac97_data->res));
>>
>> +     kfree(nuc900_ac97_data);
>>       nuc900_ac97_data = NULL;
>>
>>       return 0;
>
>
> Acked-by: Liam Girdwood <[email protected]>

Acked-by: Wan ZongShun <[email protected]>

thanks!

> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>
>



--
*linux-arm-kernel mailing list
mail addr:[email protected]
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:[email protected]
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
[email protected]

2010-11-24 11:33:05

by Mark Brown

Subject: Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

On Wed, Nov 24, 2010 at 04:44:23PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <[email protected]>

Applied, thanks.