2010-11-18 10:26:06

by Anoop P.A

Subject: [PATCH] Fix MSP71xx bpci interrupt handler return value

Signed-off-by: Anoop P A <[email protected]>
---
arch/mips/pci/ops-pmcmsp.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/pci/ops-pmcmsp.c b/arch/mips/pci/ops-pmcmsp.c
index b7c03d8..68798f8 100644
--- a/arch/mips/pci/ops-pmcmsp.c
+++ b/arch/mips/pci/ops-pmcmsp.c
@@ -308,7 +308,7 @@ static struct resource pci_mem_resource = {
* RETURNS: PCIBIOS_SUCCESSFUL - success
*

****************************************************************************/
-static int bpci_interrupt(int irq, void *dev_id)
+static irqreturn_t bpci_interrupt(int irq, void *dev_id)
{
struct msp_pci_regs *preg = (void *)PCI_BASE_REG;
unsigned int stat = preg->if_status;
@@ -326,7 +326,7 @@ static int bpci_interrupt(int irq, void *dev_id)
/* write to clear all asserted interrupts */
preg->if_status = stat;

- return PCIBIOS_SUCCESSFUL;
+ return IRQ_HANDLED;
}

/*****************************************************************************
--
1.7.0.4

2010-12-24 09:36:12

by Shane McDonald

Subject: Re: [PATCH] Fix MSP71xx bpci interrupt handler return value

Hi Anoop:

On Thu, Nov 18, 2010 at 4:32 AM, Anoop P A <[email protected]> wrote:
>
> Signed-off-by: Anoop P A <[email protected]>
> ---
> ?arch/mips/pci/ops-pmcmsp.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)

I have successfully booted a 2.6.37-rc6 kernel with this patch applied
on an MSP7120 Garibaldi evaluation board.

Tested-by: Shane McDonald <[email protected]>