2011-03-18 07:12:36

by Dan Carpenter

Subject: [patch 1/2] efivars: memory leak on error in create_efivars_bin_attributes()

This is a cut and paste bug. We intended to free ->del_var and
->new_var but we only free ->new_var.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index ff0c373..ff2fe40 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -677,8 +677,8 @@ create_efivars_bin_attributes(struct efivars *efivars)

return 0;
out_free:
- kfree(efivars->new_var);
- efivars->new_var = NULL;
+ kfree(efivars->del_var);
+ efivars->del_var = NULL;
kfree(efivars->new_var);
efivars->new_var = NULL;
return error;

2011-03-18 09:23:32

by Mike Waychison

Subject: Re: [patch 1/2] efivars: memory leak on error in create_efivars_bin_attributes()

On Fri, Mar 18, 2011 at 12:12 AM, Dan Carpenter <[email protected]> wrote:
> This is a cut and paste bug. ?We intended to free ->del_var and
> ->new_var but we only free ->new_var.
>
> Signed-off-by: Dan Carpenter <[email protected]>

Acked-by: Mike Waychison <[email protected]>