2010-06-30 16:01:43

by Christoph Egger

Subject: [PATCH 24/33] Removing dead ARCH_GUMSTIX_ORIG

ARCH_GUMSTIX_ORIG doesn't exist in Kconfig, therefore removing all
references for it from the source code.

Signed-off-by: Christoph Egger <[email protected]>
---
arch/arm/mach-pxa/include/mach/gumstix.h | 12 +-----------
1 files changed, 1 insertions(+), 11 deletions(-)

diff --git a/arch/arm/mach-pxa/include/mach/gumstix.h b/arch/arm/mach-pxa/include/mach/gumstix.h
index 06abd41..9b89868 100644
--- a/arch/arm/mach-pxa/include/mach/gumstix.h
+++ b/arch/arm/mach-pxa/include/mach/gumstix.h
@@ -14,25 +14,15 @@

/*
GPIOn - Input from MAX823 (or equiv), normalizing USB +5V into a clean
-interrupt signal for determining cable presence. On the original gumstix,
-this is GPIO81, and GPIO83 needs to be defined as well. On the gumstix F,
+interrupt signal for determining cable presence. On the gumstix F,
this moves to GPIO17 and GPIO37. */

/* GPIOx - Connects to USB D+ and used as a pull-up after GPIOn
has detected a cable insertion; driven low otherwise. */

-#ifdef CONFIG_ARCH_GUMSTIX_ORIG
-
-#define GPIO_GUMSTIX_USB_GPIOn 81
-#define GPIO_GUMSTIX_USB_GPIOx 83
-
-#else
-
#define GPIO_GUMSTIX_USB_GPIOn 35
#define GPIO_GUMSTIX_USB_GPIOx 41

-#endif
-
/* usb state change */
#define GUMSTIX_USB_INTR_IRQ IRQ_GPIO(GPIO_GUMSTIX_USB_GPIOn)

--
1.7.0.4

2010-07-01 04:28:00

by Eric Miao

Subject: Re: [PATCH 24/33] Removing dead ARCH_GUMSTIX_ORIG

On Thu, Jul 1, 2010 at 12:01 AM, Christoph Egger <[email protected]> wrote:
> ARCH_GUMSTIX_ORIG doesn't exist in Kconfig, therefore removing all
> references for it from the source code.
>
> Signed-off-by: Christoph Egger <[email protected]>

Acked-by: Eric Miao <[email protected]>

Cc'ed Jaya Kumar for additional thoughts.

> ---
>  arch/arm/mach-pxa/include/mach/gumstix.h |   12 +-----------
>  1 files changed, 1 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/include/mach/gumstix.h b/arch/arm/mach-pxa/include/mach/gumstix.h
> index 06abd41..9b89868 100644
> --- a/arch/arm/mach-pxa/include/mach/gumstix.h
> +++ b/arch/arm/mach-pxa/include/mach/gumstix.h
> @@ -14,25 +14,15 @@
>
>  /*
>  GPIOn - Input from MAX823 (or equiv), normalizing USB +5V into a clean
> -interrupt signal for determining cable presence. On the original gumstix,
> -this is GPIO81, and GPIO83 needs to be defined as well. On the gumstix F,
> +interrupt signal for determining cable presence. On the gumstix F,
>  this moves to GPIO17 and GPIO37. */
>
>  /* GPIOx - Connects to USB D+ and used as a pull-up after GPIOn
>  has detected a cable insertion; driven low otherwise. */
>
> -#ifdef CONFIG_ARCH_GUMSTIX_ORIG
> -
> -#define GPIO_GUMSTIX_USB_GPIOn         81
> -#define GPIO_GUMSTIX_USB_GPIOx         83
> -
> -#else
> -
>  #define GPIO_GUMSTIX_USB_GPIOn         35
>  #define GPIO_GUMSTIX_USB_GPIOx         41
>
> -#endif
> -
>  /* usb state change */
>  #define GUMSTIX_USB_INTR_IRQ           IRQ_GPIO(GPIO_GUMSTIX_USB_GPIOn)
>
> --
> 1.7.0.4
>
>

2010-07-01 23:57:22

by Jaya Kumar

Subject: Re: [PATCH 24/33] Removing dead ARCH_GUMSTIX_ORIG

On Thu, Jul 1, 2010 at 12:27 PM, Eric Miao <[email protected]> wrote:
> On Thu, Jul 1, 2010 at 12:01 AM, Christoph Egger <[email protected]> wrote:
>> ARCH_GUMSTIX_ORIG doesn't exist in Kconfig, therefore removing all
>> references for it from the source code.
>>
>> Signed-off-by: Christoph Egger <[email protected]>
>
> Acked-by: Eric Miao <[email protected]>
>
> Cc'ed Jaya Kumar for additional thoughts.

Looks okay to me too. Thanks.

Acked-by: Jaya Kumar <[email protected]>

>
>> ---
>> ?arch/arm/mach-pxa/include/mach/gumstix.h | ? 12 +-----------
>> ?1 files changed, 1 insertions(+), 11 deletions(-)
>>
>> diff --git a/arch/arm/mach-pxa/include/mach/gumstix.h b/arch/arm/mach-pxa/include/mach/gumstix.h
>> index 06abd41..9b89868 100644
>> --- a/arch/arm/mach-pxa/include/mach/gumstix.h
>> +++ b/arch/arm/mach-pxa/include/mach/gumstix.h
>> @@ -14,25 +14,15 @@
>>
>> ?/*
>> ?GPIOn - Input from MAX823 (or equiv), normalizing USB +5V into a clean
>> -interrupt signal for determining cable presence. On the original gumstix,
>> -this is GPIO81, and GPIO83 needs to be defined as well. On the gumstix F,
>> +interrupt signal for determining cable presence. On the gumstix F,
>> ?this moves to GPIO17 and GPIO37. */
>>
>> ?/* GPIOx - Connects to USB D+ and used as a pull-up after GPIOn
>> ?has detected a cable insertion; driven low otherwise. */
>>
>> -#ifdef CONFIG_ARCH_GUMSTIX_ORIG
>> -
>> -#define GPIO_GUMSTIX_USB_GPIOn ? ? ? ? 81
>> -#define GPIO_GUMSTIX_USB_GPIOx ? ? ? ? 83
>> -
>> -#else
>> -
>> ?#define GPIO_GUMSTIX_USB_GPIOn ? ? ? ? 35
>> ?#define GPIO_GUMSTIX_USB_GPIOx ? ? ? ? 41
>>
>> -#endif
>> -
>> ?/* usb state change */
>> ?#define GUMSTIX_USB_INTR_IRQ ? ? ? ? ? IRQ_GPIO(GPIO_GUMSTIX_USB_GPIOn)
>>
>> --
>> 1.7.0.4
>>
>>
>

2010-07-04 15:56:37

by Eric Miao

Subject: Re: [PATCH 24/33] Removing dead ARCH_GUMSTIX_ORIG

On Fri, Jul 2, 2010 at 7:57 AM, Jaya Kumar <[email protected]> wrote:
> On Thu, Jul 1, 2010 at 12:27 PM, Eric Miao <[email protected]> wrote:
>> On Thu, Jul 1, 2010 at 12:01 AM, Christoph Egger <[email protected]> wrote:
>>> ARCH_GUMSTIX_ORIG doesn't exist in Kconfig, therefore removing all
>>> references for it from the source code.
>>>
>>> Signed-off-by: Christoph Egger <[email protected]>
>>
>> Acked-by: Eric Miao <[email protected]>
>>
>> Cc'ed Jaya Kumar for additional thoughts.
>
> Looks okay to me too. Thanks.
>
> Acked-by: Jaya Kumar <[email protected]>
>

Applied.