2010-08-12 01:39:19

by xiaoyu Du

Subject: [PATCH] IPVS : bugfix for ICMPv6 checksum calculation

Hi:

This patch correct the ICMPv6 checksum calculation when IPv6 vs is used.

Signed-off-by: Xiaoyu Du <[email protected]>
---
net/netfilter/ipvs/ip_vs_core.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c
index 4f8ddba..124a1ae 100644
--- a/net/netfilter/ipvs/ip_vs_core.c
+++ b/net/netfilter/ipvs/ip_vs_core.c
@@ -638,8 +638,12 @@ void ip_vs_nat_icmp_v6(struct sk_buff *skb,
struct ip_vs_protocol *pp,

/* And finally the ICMP checksum */
icmph->icmp6_cksum = 0;
- /* TODO IPv6: is this correct for ICMPv6? */
ip_vs_checksum_complete(skb, icmp_offset);
+ icmph->icmp6_cksum = csum_ipv6_magic(&iph->saddr,
+ &iph->daddr,
+ skb->len - icmp_offset, IPPROTO_ICMPV6,
+ skb->csum);
+
skb->ip_summed = CHECKSUM_UNNECESSARY;

if (inout)
--

2010-08-12 05:48:07

by xiaoyu Du

Subject: Re: [PATCH] IPVS : bugfix for ICMPv6 checksum calculation

forgive my careless and poor english , "correct" should be "corrects".

2010-08-17 07:01:04

by Simon Horman

Subject: Re: [PATCH] IPVS : bugfix for ICMPv6 checksum calculation

On Thu, Aug 12, 2010 at 01:48:02PM +0800, xiaoyu Du wrote:
> forgive my careless and poor english , "correct" should be "corrects".

Thanks, got it.