2011-03-03 16:48:06

by Tomoki Sekiyama

[permalink] [raw]
Subject: Re: [PATCH][Bug 26922]USB: yurex: recognize GeneralKeys wireless presenter as generic HID (Re: New: 2.6.37 breaks USB wireless presenter HID device)

2011/1/21 Andrew Morton <[email protected]>:
> On Fri, 21 Jan 2011 07:28:49 +0900
> You hit the jackpot.  The patch was wordwrapped, space-stuffed and
> tab-replaced!
>
> Here's my attempt to reconstruct it:

Sorry for broken patch, and thanks for your repair.
The patch was confirmed to successfully fix the regression in recognition
of Wireless Presenter by the original bug reporter.

https://bugzilla.kernel.org/show_bug.cgi?id=26922

> From: Tomoki Sekiyama <[email protected]>
>
> Unfortunately, the device seems to have the same Vendor ID and Product ID
> as YUREX leg-shakes sensors, and the commit 6bc235a2e2 ("USB: add driver
> for Meywa-Denki & Kayac YUREX") added the ID to hid_ignore_list.
>
> I believe that we can distinguish YUREX and the Wireless Presenter by
> device type.  The patch below makes the driver ignore only YUREX
> (bInterfaceProtocol==0), and recognize Wireless Presenter
> (bInterfaceProtocol is keyboard or mouse) as generic HID.  (I don't have
> the Wireless Presenter, so not yet ested.)