[ CC me I am not subscribed to LKML ]
Hi,
with 2.6.37-rc1-git11 my none-BKL-config breaks (-git9 and -git9457b24
were OK) in stradis staging-crap.
Think the breakage aroses from [1].
$ cd ~/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none
$ grep "error:" ../../../../build_linux-2.6_git11.sd.1.log
/home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1891:
error: implicit declaration of function ‘lock_kernel’
/home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1897:
error: implicit declaration of function ‘unlock_kernel’
$ grep -i stradis ../build_i386_none_686/.config
CONFIG_VIDEO_STRADIS=m
For now, I will *unset* CONFIG_VIDEO_STRADIS.
Just wann let you know.
BTW, what was the scripts name to get the maintainers' email-list?
(Sorry, if I have forgotten people to CC).
Kind Regards,
- Sedat -
P.S.: My dot-config is attached.
[1] Merge branch 'staging-linus' of
git://git./linux/kernel/git/gregkh/staging-2.6
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1c32ca9f63d2a103dd33eae72e5aff53a23fe650
On Sunday 14 November 2010, Sedat Dilek wrote:
> with 2.6.37-rc1-git11 my none-BKL-config breaks (-git9 and -git9457b24
> were OK) in stradis staging-crap.
> Think the breakage aroses from [1].
>
> $ cd ~/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none
>
> $ grep "error:" ../../../../build_linux-2.6_git11.sd.1.log
> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1891:
> error: implicit declaration of function ‘lock_kernel’
> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1897:
> error: implicit declaration of function ‘unlock_kernel’
The driver is on its way out. I'll do a patch to just mark it "depends
on BKL" to make sure it doesn't get built when BKL is disabled.
It would be relatively easy to fix the right way, if you are interested.
Arnd
On Mon, Nov 15, 2010 at 12:54 PM, Arnd Bergmann <[email protected]> wrote:
> On Sunday 14 November 2010, Sedat Dilek wrote:
>> with 2.6.37-rc1-git11 my none-BKL-config breaks (-git9 and -git9457b24
>> were OK) in stradis staging-crap.
>> Think the breakage aroses from [1].
>>
>> $ cd ~/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none
>>
>> $ grep "error:" ../../../../build_linux-2.6_git11.sd.1.log
>> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1891:
>> error: implicit declaration of function ‘lock_kernel’
>> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1897:
>> error: implicit declaration of function ‘unlock_kernel’
>
> The driver is on its way out. I'll do a patch to just mark it "depends
> on BKL" to make sure it doesn't get built when BKL is disabled.
>
> It would be relatively easy to fix the right way, if you are interested.
>
> Arnd
>
I was enjoying the nice sunshine weather on Sunday :-)... here in
South-West Germany.
Thus I had not had big time to look into the code... as stradis moved
to staging area, it got built this time in a none-BKL-config.
I checked a previous kernel and its dot-config and there was no
stradis inside, so never built before.
As stradis is marked DEPRECATED and I am not using it (even dunno what
it is, sorry for my ignorance), it's not that important.
A "depends on BKL" would be nice for the none-BKL-config folks to not
fall into the "pitfall".
If you have a patch for stradis, I would add it to my patchset.
Thank you in advance for helping to fix the issue.
- Sedat -
On Mon, Nov 15, 2010 at 12:54 PM, Arnd Bergmann <[email protected]> wrote:
> On Sunday 14 November 2010, Sedat Dilek wrote:
>> with 2.6.37-rc1-git11 my none-BKL-config breaks (-git9 and -git9457b24
>> were OK) in stradis staging-crap.
>> Think the breakage aroses from [1].
>>
>> $ cd ~/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none
>>
>> $ grep "error:" ../../../../build_linux-2.6_git11.sd.1.log
>> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1891:
>> error: implicit declaration of function ‘lock_kernel’
>> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1897:
>> error: implicit declaration of function ‘unlock_kernel’
>
> The driver is on its way out. I'll do a patch to just mark it "depends
> on BKL" to make sure it doesn't get built when BKL is disabled.
>
> It would be relatively easy to fix the right way, if you are interested.
>
> Arnd
>
Thanks for the patch "staging/stradis: mark as "depends on BKL"" in [1].
- Sedat -
[1] http://git.kernel.org/?p=linux/kernel/git/arnd/bkl.git;a=commit;h=31a5739171c7c737653a6b1d415d7f285d6239b3