2011-02-25 15:35:12

by Daniel Drake

Subject: OF IOAPIC bindings compile error

Hi,

Testing linux-2.6-x86.git, I encountered a compile error which seems
to caused by the following commit with X86_IO_APIC=n:

commit bcc7c1244fcfd852b9f4590935491057e1cab9dd
Author: Sebastian Andrzej Siewior <[email protected]>
Date: Tue Feb 22 21:07:44 2011 +0100

x86: ioapic: Add OF bindings for IO_APIC

Error is:
arch/x86/kernel/devicetree.c: In function ?x86_dtb_find_config?:
arch/x86/kernel/devicetree.c:288:3: error: lvalue required as left
operand of assignment

It can be fixed by inserting #ifdef CONFIG_X86_IO_APIC inside
x86_dtb_find_config, but I'm not sure if this is the correct approach.

.config file in question:
http://dev.laptop.org/~dsd/20110225/ioioapic-problem-config.txt

Daniel

2011-02-25 15:38:46

by Sebastian Andrzej Siewior

Subject: Re: OF IOAPIC bindings compile error

Daniel Drake wrote:
> Hi,
Hi,

>
> Testing linux-2.6-x86.git, I encountered a compile error which seems
> to caused by the following commit with X86_IO_APIC=n:
>
> commit bcc7c1244fcfd852b9f4590935491057e1cab9dd
> Author: Sebastian Andrzej Siewior <[email protected]>
> Date: Tue Feb 22 21:07:44 2011 +0100
>
> x86: ioapic: Add OF bindings for IO_APIC

Please check:
Commit-ID: a906fdaacca49917d83e5032dfc31f694249ad10
Gitweb: http://git.kernel.org/tip/a906fdaacca49917d83e5032dfc31f694249ad10
x86: dt: Cleanup local apic setup

this fixes it.

> Daniel

Sebastian