2010-07-23 22:16:55

by Daniel J Blueman

Subject: [2.6.35-rc6] quiesce EDAC initialisation on desktop/mobile i7

Hi Linus,

A small fixlet for 2.6.35-rc7/final.

---

Don't print failure to detect Core i7 EDAC facilities to the console at boot
time, most often occurring on Core i7 desktops and laptops.

Signed-off-by: Daniel J Blueman <[email protected]>

diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
index cc9357d..e0187d1 100644
--- a/drivers/edac/i7core_edac.c
+++ b/drivers/edac/i7core_edac.c
@@ -1300,7 +1300,7 @@ int i7core_get_onedevice(struct pci_dev **prev, int devno,
if (devno == 0)
return -ENODEV;

- i7core_printk(KERN_ERR,
+ i7core_printk(KERN_INFO,
"Device not found: dev %02x.%d PCI ID %04x:%04x\n",
dev_descr->dev, dev_descr->func,
PCI_VENDOR_ID_INTEL, dev_descr->dev_id);

--
Daniel J Blueman

2010-07-24 10:56:50

by Borislav Petkov

Subject: Re: [2.6.35-rc6] quiesce EDAC initialisation on desktop/mobile i7

From: Daniel J Blueman <[email protected]>
Date: Fri, Jul 23, 2010 at 11:16:52PM +0100

> Hi Linus,
>
> A small fixlet for 2.6.35-rc7/final.
>
> ---
>
> Don't print failure to detect Core i7 EDAC facilities to the console at boot
> time, most often occurring on Core i7 desktops and laptops.
>
> Signed-off-by: Daniel J Blueman <[email protected]>
>
> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
> index cc9357d..e0187d1 100644
> --- a/drivers/edac/i7core_edac.c
> +++ b/drivers/edac/i7core_edac.c
> @@ -1300,7 +1300,7 @@ int i7core_get_onedevice(struct pci_dev **prev, int devno,
> if (devno == 0)
> return -ENODEV;
>
> - i7core_printk(KERN_ERR,
> + i7core_printk(KERN_INFO,
> "Device not found: dev %02x.%d PCI ID %04x:%04x\n",
> dev_descr->dev, dev_descr->func,
> PCI_VENDOR_ID_INTEL, dev_descr->dev_id);
>

Adding the driver maintainer to CC. Please, try doing that in the
future,

Thanks.

--
Regards/Gruss,
Boris.

2010-07-25 17:50:27

by Mauro Carvalho Chehab

Subject: Re: [2.6.35-rc6] quiesce EDAC initialisation on desktop/mobile i7

Em 24-07-2010 07:56, Borislav Petkov escreveu:
> From: Daniel J Blueman <[email protected]>
> Date: Fri, Jul 23, 2010 at 11:16:52PM +0100
>
>> Hi Linus,
>>
>> A small fixlet for 2.6.35-rc7/final.
>>
>> ---
>>
>> Don't print failure to detect Core i7 EDAC facilities to the console at boot
>> time, most often occurring on Core i7 desktops and laptops.
>>
>> Signed-off-by: Daniel J Blueman <[email protected]>

Seems ok to me.

Acked-by: Mauro Carvalho Chehab <[email protected]>

>>
>> diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c
>> index cc9357d..e0187d1 100644
>> --- a/drivers/edac/i7core_edac.c
>> +++ b/drivers/edac/i7core_edac.c
>> @@ -1300,7 +1300,7 @@ int i7core_get_onedevice(struct pci_dev **prev, int devno,
>> if (devno == 0)
>> return -ENODEV;
>>
>> - i7core_printk(KERN_ERR,
>> + i7core_printk(KERN_INFO,
>> "Device not found: dev %02x.%d PCI ID %04x:%04x\n",
>> dev_descr->dev, dev_descr->func,
>> PCI_VENDOR_ID_INTEL, dev_descr->dev_id);
>>
>
> Adding the driver maintainer to CC. Please, try doing that in the
> future,
>
> Thanks.
>