2010-08-21 10:54:08

by Maxim Osipov

[permalink] [raw]

Subject: [PATCH] USB: Fix kernel oops with g_ether and Windows

---

Hello,

Please find attached patch for
https://bugzilla.kernel.org/show_bug.cgi?id=16023 problem.

Kind regards,
Maxim

---

Attachments:

0001-USB-Fix-kernel-oops-with-g_ether-and-Windows.patch (1.13 kB)

2010-08-21 13:29:23

by Sergei Shtylyov

[permalink] [raw]

Subject: Re: [PATCH] USB: Fix kernel oops with g_ether and Windows

---

Hello.

Maxim Osipov wrote:

> Please find attached patch for
> https://bugzilla.kernel.org/show_bug.cgi?id=16023 problem.

It's preferrable that the patahces areposted inline.

> Kind regards,
> Maxim

> From 43568dec4f387da4562d5bc81557c642a468b685 Mon Sep 17 00:00:00 2001
> From: Maxim Osipov <[email protected]>
> Date: Thu, 19 Aug 2010 07:25:28 +0400
> Subject: [PATCH] USB: Fix kernel oops with g_ether and Windows

> Signed-off-by: Maxim Osipov <[email protected]>
[...]
> diff --git a/drivers/usb/gadget/rndis.c b/drivers/usb/gadget/rndis.c
> index 5c0d06c..1043da1 100644
> --- a/drivers/usb/gadget/rndis.c
> +++ b/drivers/usb/gadget/rndis.c
> @@ -292,9 +292,13 @@ gen_ndis_query_resp (int configNr, u32 OID, u8 *buf, unsigned buf_len,
> /* mandatory */
> case OID_GEN_VENDOR_DESCRIPTION:
> pr_debug("%s: OID_GEN_VENDOR_DESCRIPTION\n", __func__);
> - length = strlen (rndis_per_dev_params [configNr].vendorDescr);
> - memcpy (outbuf,
> - rndis_per_dev_params [configNr].vendorDescr, length);
> + if ( rndis_per_dev_params [configNr].vendorDescr ) {

There should be not space after ( and before ). Run your patches thru
scripts/checkpatch.pl before submitting please.

> + length = strlen (rndis_per_dev_params [configNr].vendorDescr);
> + memcpy (outbuf,
> + rndis_per_dev_params [configNr].vendorDescr, length);

Should be no space before ( either and before [ too.

WBR, Sergei