2010-07-15 09:45:13

by Wan ZongShun

[permalink] [raw]
Subject: Re: [rtc-linux] [PATCH] Fix the rx8581 setdatetime

2010/7/15 Rudolf Marek <[email protected]>:
> Hello,
>
> This patch fixes the logic while writing new date/time to the chip. The
> driver incorrectly written back register values to different registers
> and even with wrong mask. The patch adds clearing of the VLF register,
> which should be cleared if all date/time values are set.
>
> Signed-off-by: Rudolf Marek <[email protected]>
>
> I'm attaching this as an attachment because Thunderbird will break it

Not everyone has time and willing to download your patch for reviewing,
so why not try to setting your Thunderbird to solve this break?

Anyway, this is a good patch, thanks!

Acked-by: Wan ZongShun <[email protected]>

> otherwise.
> For your reference, datasheet is here:
>
> http://www.epsontoyocom.co.jp/english/product/RTC/set03/ra8581sa/index.html
>
> Thanks,
> Rudolf
>
> --
>
> S přátelským pozdravem / Best regards / Mit freundlichen Grüßen
>
> Ing. Rudolf Marek
> SYSGO s.r.o.
> Zelený pruh 99
> CZ-14800 Praha 4
> Phone: +420 222138 627, +49 6136 9948 627
> Fax: +420 296374890, +49 6136 9948 1 627
> [email protected]
>
> http://www.sysgo.com | http://www.elinos.com | http://www.pikeos.com
>
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
>



--
*linux-arm-kernel mailing list
mail addr:[email protected]
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:[email protected]
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
[email protected]