2011-03-24 19:04:50

by Guenter Roeck

Subject: [PATCH] mfd: Select MFD_CORE if TPS6105X driver is configured

The TPS61050/61052 driver uses MFD core code, yet does not specify the
dependency in Kconfig. If it is the only MFD driver configured, compilation
fails with

ERROR: "mfd_add_devices" [drivers/mfd/tps6105x.ko] undefined!
ERROR: "mfd_remove_devices" [drivers/mfd/tps6105x.ko] undefined!

Fix the problem by adding "select MFD_CORE" to the respective Kconfig entry.

Signed-off-by: Guenter Roeck <[email protected]>
---
drivers/mfd/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index a9a1af4..e986f91 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -133,6 +133,7 @@ config TPS6105X
tristate "TPS61050/61052 Boost Converters"
depends on I2C
select REGULATOR
+ select MFD_CORE
select REGULATOR_FIXED_VOLTAGE
help
This option enables a driver for the TP61050/TPS61052
--
1.7.3.1

2011-03-24 22:03:30

by Linus Walleij

Subject: Re: [PATCH] mfd: Select MFD_CORE if TPS6105X driver is configured

On Thu, Mar 24, 2011 at 8:12 PM, Guenter Roeck
<[email protected]> wrote:

> The TPS61050/61052 driver uses MFD core code, yet does not specify the
> dependency in Kconfig. If it is the only MFD driver configured, compilation
> fails with
>
> ERROR: "mfd_add_devices" [drivers/mfd/tps6105x.ko] undefined!
> ERROR: "mfd_remove_devices" [drivers/mfd/tps6105x.ko] undefined!
>
> Fix the problem by adding "select MFD_CORE" to the respective Kconfig entry.
>
> Signed-off-by: Guenter Roeck <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Thanks G?nter,
Linus Walleij