2011-02-01 08:32:53

by Sedat Dilek

Subject: Re: linux-next: Tree for February 1 [ staging/usbvid eo/vicam.c: error: expected ‘;’ before ‘)’ token ]

On Tue, Feb 1, 2011 at 5:34 AM, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> Changes since 20110131:
>
> Dropped tree: xen
>
> The tty.current tree lost its conflict.
>
> The slab tree still has its build failure so I used the version from
> next-20110121.
>
> The suspend tree lost its build failure.
>
> The sparc64 defconfig build has been fixed.
>
> The powerpc allyesconfig build has been broken by some obscure bloating
> of the low memory code.
>
> ----------------------------------------------------------------------------

[ CC greg-kh ]

Build error:
...
drivers/staging/usbvideo/vicam.c:222:57: error: expected ‘;’ before ‘)’ token
drivers/staging/usbvideo/vicam.c:222:57: error: expected statement
before ‘)’ token
...

This should be fixed by:

Index: linux-next-20110201/drivers/staging/usbvideo/vicam.c
===================================================================
--- linux-next-20110201.orig/drivers/staging/usbvideo/vicam.c
+++ linux-next-20110201/drivers/staging/usbvideo/vicam.c
@@ -219,7 +219,7 @@ set_camera_power(struct vicam_camera *ca
{
int status;

- status = send_control_msg(cam, 0x50, state, 0, NULL, 0));
+ status = send_control_msg(cam, 0x50, state, 0, NULL, 0);
if (status < 0)
return status;

- Sedat -

2011-02-01 11:58:52

by Sedat Dilek

Subject: Re: linux-next: Tree for February 1 [ staging/usbvid eo/vicam.c: error: expected ‘;’ before ‘)’ token ]

On Tue, Feb 1, 2011 at 9:32 AM, Sedat Dilek <[email protected]> wrote:
> On Tue, Feb 1, 2011 at 5:34 AM, Stephen Rothwell <[email protected]> wrote:
>> Hi all,
>>
>> Changes since 20110131:
>>
>> Dropped tree: xen
>>
>> The tty.current tree lost its conflict.
>>
>> The slab tree still has its build failure so I used the version from
>> next-20110121.
>>
>> The suspend tree lost its build failure.
>>
>> The sparc64 defconfig build has been fixed.
>>
>> The powerpc allyesconfig build has been broken by some obscure bloating
>> of the low memory code.
>>
>> ----------------------------------------------------------------------------
>
> [ CC greg-kh ]
>
> Build error:
> ...
> drivers/staging/usbvideo/vicam.c:222:57: error: expected ‘;’ before ‘)’ token
> drivers/staging/usbvideo/vicam.c:222:57: error: expected statement
> before ‘)’ token
> ...
>
> This should be fixed by:
>
> Index: linux-next-20110201/drivers/staging/usbvideo/vicam.c
> ===================================================================
> --- linux-next-20110201.orig/drivers/staging/usbvideo/vicam.c
> +++ linux-next-20110201/drivers/staging/usbvideo/vicam.c
> @@ -219,7 +219,7 @@ set_camera_power(struct vicam_camera *ca
>  {
>        int status;
>
> -       status = send_control_msg(cam, 0x50, state, 0, NULL, 0));
> +       status = send_control_msg(cam, 0x50, state, 0, NULL, 0);
>        if (status < 0)
>                return status;
>
> - Sedat -
>

[ Changed... TO Timo von Holtz + CC sfr ]

Just FYI:

The problem was introduced in staging-next GIT branch:

commit 046d747e0d2cb597e0b6fa4a79c32b43e97ed792
"taging: usbvideo: vicam: fixed some coding style issues"

- Sedat -

[1] http://git.kernel.org/?p=linux/kernel/git/gregkh/staging-2.6.git;a=commit;h=046d747e0d2cb597e0b6fa4a79c32b43e97ed792