2010-12-21 01:01:34

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure in Linus' tree

Hi all,

While building Linus' tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/block/cciss.c: In function 'cciss_revalidate':
drivers/block/cciss.c:2839: error: expected ';' before 'if'

Caused by commit 0fc13c8995cd96f4123de400c71c223d80400ed9 ("cciss: fix
cciss_revalidate panic"). Was this even build tested? More care
required.

I have reverted that commit for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (509.00 B)
(No filename) (490.00 B)
Download all attachments

2010-12-21 04:47:24

by Sedat Dilek

[permalink] [raw]
Subject: Re: linux-next: build failure in Linus' tree

On Tue, Dec 21, 2010 at 2:01 AM, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> While building Linus' tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/block/cciss.c: In function 'cciss_revalidate':
> drivers/block/cciss.c:2839: error: expected ';' before 'if'
>
> Caused by commit 0fc13c8995cd96f4123de400c71c223d80400ed9 ("cciss: fix
> cciss_revalidate panic").  Was this even build tested?  More care
> required.
>
> I have reverted that commit for today.
> --
> Cheers,
> Stephen Rothwell                    [email protected]
> http://www.canb.auug.org.au/~sfr/
>

[ CC Thiago Farina ]

Did you see the patch "[PATCH] drivers/block/cciss.c: Fix compiling
error by adding ';' at the end of continue statement." from [1] from
Thiago?

- Sedat -

[1] http://lkml.org/lkml/2010/12/20/465