2010-07-16 16:13:08

by Kulikov Vasiliy

Subject: [PATCH 02/15] arm/mach-u300: check kmalloc result

If kmalloc() fails free already allocated memory and exit with -ENOMEM.

Signed-off-by: Kulikov Vasiliy <[email protected]>
---
arch/arm/mach-u300/dummyspichip.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-u300/dummyspichip.c b/arch/arm/mach-u300/dummyspichip.c
index 5f55012..452218a 100644
--- a/arch/arm/mach-u300/dummyspichip.c
+++ b/arch/arm/mach-u300/dummyspichip.c
@@ -64,6 +64,11 @@ static ssize_t dummy_looptest(struct device *dev,
goto out;
}
bigrxbuf_virtual = kmalloc(DMA_TEST_SIZE, GFP_KERNEL);
+ if (bigrxbuf_virtual == NULL) {
+ kfree(bigtxbuf_virtual);
+ status = -ENOMEM;
+ goto out;
+ }

/* Fill TXBUF with some happy pattern */
memset(bigtxbuf_virtual, 0xAA, DMA_TEST_SIZE);
--
1.7.0.4

2010-07-17 10:00:43

by Linus Walleij

Subject: Re: [PATCH 02/15] arm/mach-u300: check kmalloc result

2010/7/16 Kulikov Vasiliy <[email protected]>:

> ?arch/arm/mach-u300/dummyspichip.c | ? ?5 +++++
> ?1 files changed, 5 insertions(+), 0 deletions(-)

NACK I have recently submitted two patches to move this test chip to
drivers/spi, please base your fixes work on top of those patches
instead, and make sure to mail them to Grant Likely and the
spi-devel-general list.

Yours,
Linus Walleij