The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
http://userweb.kernel.org/~akpm/mmotm/
and will soon be available at
git://zen-kernel.org/kernel/mmotm.git
It contains the following patches against 2.6.35-rc5:
origin.patch
ipc-semc-bugfix-for-semop-not-reporting-successful-operation.patch
ipc-semc-bugfix-for-semop-not-reporting-successful-operation-update.patch
mm-vmap-area-cache.patch
mm-vmap-area-cache-fix.patch
mm-vmscan-fix-mapping-use-after-free.patch
edac-mpc85xx-fix-mpc85xx-dependency.patch
edac-mpc85xx-add-support-for-mpc8569-edac-controllers.patch
x86-numa-fix-boot-without-ram-on-node0-again.patch
x86-numa-fix-boot-without-ram-on-node0-again-fix.patch
email-address-change.patch
sdhci-s3c-add-missing-remove-function.patch
linux-next.patch
next-remove-localversion.patch
revert-driver-core-remove-config_sysfs_deprecated.patch
revert-sysfs-dont-allow-the-creation-of-symlinks-we-cant-remove.patch
fs-inodec-work-around-bug.patch
i-need-old-gcc.patch
include-linux-fsh-complete-hexification-of-fmode_-constants.patch
vfs-fix-rcu-lockdep-false-positive-due-to-proc.patch
x86nobootmem-make-alloc_bootmem_node-fall-back-to-other-node-when-32bit-numa-is-used.patch
backlight-fix-88pm860x_bl-macro-collision.patch
cpufreq-revert-remove-rwsem-lock-from-cpufreq_gov_stop-call-second-call-site.patch
intel_agp-dont-oops-with-zero-stolen-memory.patch
vfs-dont-hold-s_umount-over-close_bdev_exclusive-call.patch
x86-i8259-only-register-sysdev-for-real-pic.patch
acpi-fix-bogus-preemption-logic.patch
acpi-fix-bogus-preemption-logic-fix.patch
acpi-fix-unused-function-warning.patch
gcc-46-acpi-fix-unused-but-set-variables-in-acpi.patch
hp-wmi-return-enodev-if-bios-does-not-export-any-supported-hp-wmi-guid.patch
acerhdf-add-new-bios-versions.patch
acerhdf-remove-chk_off-as-it-was-only-needed-for-t31-netbooks.patch
acerhdf-driver-didnt-verify-the-pointers-in-which-it-got-product-information.patch
acerhdf-add-ao531-and-many-bios-versions-for-1410-1810xx-and-packard-bell-netbooks.patch
fujitsu-laptop-remove-unnecessary-input_free_device-calls.patch
compal-laptop-added-jhl90-battery-hwmon-interface.patch
compal-laptop-uses-hwmon-interfaces-depends-on-hwmon.patch
compal-laptop-fujitsu-laptop-msi-laptop-make-dmi_check_cb-to-return-1-instead-of-0.patch
asus_acpi-fix-a-memory-leak-in-asus_hotk_get_info.patch
asus_acpi-fix-coding-style-to-improve-readability.patch
acerhdf-make-needlessly-global-symbols-static.patch
classmate-laptop-make-needlessly-global-symbols-static.patch
fujitsu-laptop-make-needlessly-global-symbols-static.patch
msi-laptop-make-struct-rfkill_ops-const.patch
asus-laptop-fix-incorrect-return-value-for-write_acpi_int_ret-if-handle-is-null.patch
asus-laptop-return-proper-error-for-store_ledd-if-write_acpi_int-fail.patch
acerhdf-fix-resource-reclaim-in-error-path.patch
toshiba_acpi-make-remove_device-and-add_device-void.patch
toshiba_acpi-rename-add_device-and-remove_device-to-create_toshiba_proc_entries-and-remove_toshiba_proc_entries.patch
hp-wmi-add-return-value-checking-for-input_allocate_device.patch
acer-wmi-fix-memory-leaks-in-wmid_set_capabilities-and-get_wmid_devices.patch
acer-wmi-fix-memory-leaks-in-wmab_execute-error-path.patch
acer-wmi-fix-memory-leaks-in-wmab_execute-error-path-v2.patch
acer-wmi-fix-memory-leaks-in-wmab_execute-error-path-v2-fix.patch
acer-wmi-remove-non-used-acer_quirks-struct-definition.patch
asus-laptop-fix-wapf-wlan_status-and-bluetooth_status-module_param-permissions.patch
eeepc-laptop-fix-hotplug_disabled-module_param-permissions.patch
intel_menlow-fix-memory-leaks-in-error-path-fix.patch
x86-cpufreq-make-trace_power_frequency-cpufreq-driver-independent.patch
x86-cpufreq-make-trace_power_frequency-cpufreq-driver-independent-fix.patch
x86-rwsem-stay-on-fast-path-when-count0-in-__up_write.patch
x86-rwsem-stay-on-fast-path-when-count0-in-__up_write-fix.patch
x86-rwsem-minor-cleanups.patch
x86-mm-create-symbolic-index-into-address_markers-array.patch
x86-fix-wrong-page-aligned-size-calculation-in-ioremapping-code.patch
gcc-46-x86-avoid-unused-by-set-variables-in-rdmsr.patch
gcc-46-x86-fix-set-but-not-read-variables.patch
gcc-46-kgdb-remove-set-but-unused-newpc.patch
parport-prevent-arm-boards-frmo-crashing-when-cups-is-loaded.patch
parport-prevent-arm-boards-frmo-crashing-when-cups-is-loaded-fix.patch
avr32-invoke-oom-killer-from-page-fault.patch
fs-btrfs-use-memdup_user.patch
fs-btrfs-use-err_cast.patch
gcc-46-btrfs-clean-up-unused-variables-bugs.patch
gcc-46-btrfs-clean-up-unused-variables-bugs-fix.patch
gcc-46-btrfs-clean-up-unused-variables-nonbugs.patch
cifs-provide-user-with-a-hint-when-name-resolution-fails.patch
powernow-k8-limit-pstate-transition-latency-check.patch
powernow-k8-fix-misleading-variable-naming.patch
pcmcia-fix-driver-did-not-release-config-properly-warning.patch
sysfs-fix-discrepancies-between-implementation-and-documentation.patch
drivers-gpu-drm-i915-remove-duplicate-structure-field-initialization.patch
include-linux-vgaarbh-add-missing-part-of-include-guard.patch
dib3000mc-reduce-large-stack-usage-fix.patch
drivers-video-omap2-displays-add-missing-mutex_unlock.patch
gcc-46-irq-move-alloc_desk_mask-variables-inside-ifdef.patch
hpet-factor-timer-allocate-from-open.patch
posix_timer-move-copy_to_usercreated_timer_id-down-in-timer_create.patch
timersc-document-meaning-of-deferrable-timer.patch
kbuild-fix-config_cross_compile-issue-in-config.patch
leds-route-kbd-leds-through-the-generic-leds-layer.patch
leds-route-kbd-leds-through-the-generic-leds-layer-fix-sleep-inside-atomic.patch
mtd-sst25l-check-for-null-consistently.patch
mtd-return-1-if-verify-failed.patch
mtd-nand-davinci-correct-4-bit-error-correction.patch
mtdpart-memory-accessor-interface-for-mtd-layer.patch
gcc-46-nfsd-fix-initialized-but-not-read-warnings.patch
score-fix-dereference-of-null-pointer-in-local_flush_tlb_page.patch
fs-squashfs-xattrc-fix-warning.patch
drivers-net-cxgb3-t3_hwc-use-new-hex_to_bin-method.patch
arch-um-drivers-remove-duplicate-structure-field-initialization.patch
drivers-net-82596c-fix-warning.patch
3x59x-fix-pci-resource-management.patch
drivers-video-backlight-s6e63m0c-set-permissions-on-gamma_table-file-to-0444.patch
backlight-fix-blanking-for-lms283gf05-lcd.patch
backlight-fix-blanking-for-l4f00242t03-lcd.patch
btusb-patch-add_apple_macbookpro62.patch
parisc-fix-wrong-page-aligned-size-calculation-in-ioremapping-code.patch
altera_uart-simplify-altera_uart_console_putc-checkpatch-fixes.patch
serial-fix-missing-bit-coverage-of-async_flags.patch
serial-general-fixes-in-the-serial_rs485-structure.patch
serial-mcf-dont-take-spinlocks-in-already-protected-functions.patch
serial-mcf-dont-take-spinlocks-in-already-protected-functions-fix.patch
serial-mmio32-support-for-8250_earlyc.patch
serial-mmio32-support-for-8250_earlyc-fix.patch
serial-mmio32-support-for-8250_earlyc-fix-fix.patch
timbuart-use-__devinit-and-__devexit-macros-for-probe-and-remove.patch
drivers-serial-68328serialc-remove-dead-alma_ans-dragonixvz-m68ez328ads.patch
gcc-46-perf-fix-set-but-unused-variables-in-perf.patch
drivers-s390-net-use-memdup_user.patch
gcc-46-kernel-fix-unused-but-set-warnings.patch
security-add-const-to-security_task_setscheduler.patch
security-add-const-to-security_task_setscheduler-fix.patch
sched-make-sched_param-argument-static-variables-in-some-sched_setscheduler-caller.patch
percpu-online-cpu-before-memory-failed-in-pcpu_alloc_pages.patch
percpu-fix-list_head-init-bug-in-__percpu_counter_init.patch
scsi-add-__init-__exit-macros-to-ibmvstgtc.patch
osst-fix-read-buffer-overflow.patch
gdth-unmap-ccb_phys-when-scsi_add_host-fails-in-gdth_eisa_probe_one.patch
drivers-scsi-libsas-use-sam_good.patch
ncr5380-bit-mr_dma_mode-set-twice-in-ncr5380_transfer_dma.patch
drivers-scsi-remove-unnecessary-null-test.patch
drivers-message-move-dereference-after-null-test.patch
mpt-fusion-convert-to-seq_file.patch
g_ncr5380-remove-misleading-pnp-error-message.patch
g_ncr5380-fix-broken-mmio-compilation.patch
dc395x-decrease-iteration-for-tag_number-of-max_command-in-start_scsi.patch
drivers-scsi-correct-the-size-argument-to-kmalloc.patch
scsi-remove-superfluous-null-pointer-check-from-scsi_kill_request.patch
scsi-sdc-quiet-all-sparse-noise.patch
drivers-scsi-qla2xxx-qla_osc-fix-continuation-line-formats.patch
scsi-bfa-correct-onstack-wait_queue_head-declaration.patch
drivers-scsi-chc-dont-use-vprintk-as-macro.patch
bfa-wrong-fcport-h2i-message-tested-in-bfa_fcport_isr.patch
scsi-use-__ux-types-for-headers-exported-to-user-space.patch
scsi-fix-pmcraid-build-errors.patch
scsi-fix-be2iscsi-build.patch
scsi-fix-bnx2i-build-errors.patch
scsi-remove-private-bit-macros.patch
drivers-scsi-use-memdup_user.patch
drivers-scsi-use-newly-introduced-hex_to_bin-method.patch
scsi-mvsas-fix-potential-null-dereference.patch
drivers-scsi-pmcraidc-remove-unwanted-cast-for-void-pointers.patch
drivers-block-use-memdup_user.patch
floppy-make-controller-const.patch
drivers-usb-serial-io_tic-dont-return-0-if-writing-the-download-record-failed.patch
virtio_9ph-include-linux-typesh.patch
vfs-improve-comment-describing-fget_light.patch
vfs-o_-bit-numbers-uniqueness-check.patch
vfs-introduce-fmode_neg_offset-for-allowing-negative-f_pos.patch
vfs-clarify-that-nonseekable_open-will-never-fail.patch
vfs-use-kmalloc-to-allocate-fdmem-if-possible.patch
modpost-support-objects-with-more-than-64k-sections.patch
mm.patch
mm-use-memdup_user.patch
mm-use-err_cast.patch
mm-provide-init_mm-mm_context-initializer.patch
fs-move-code-out-of-bufferc.patch
hugetlb-call-mmu-notifiers-on-hugepage-cow.patch
kmap_atomic-make-kunmap_atomic-harder-to-misuse.patch
define-madv_hugepage.patch
mm-rename-anon_vma_lock-to-vma_lock_anon_vma.patch
mm-change-direct-call-of-spin_lockanon_vma-lock-to-inline-function.patch
mm-track-the-root-oldest-anon_vma.patch
mm-track-the-root-oldest-anon_vma-fix.patch
mm-always-lock-the-root-oldest-anon_vma.patch
mm-extend-ksm-refcounts-to-the-anon_vma-root.patch
mm-extend-ksm-refcounts-to-the-anon_vma-root-fix.patch
buffer_head-remove-redundant-test-from-wait_on_buffer.patch
oom-check-pf_kthread-instead-of-mm-to-skip-kthreads.patch
oom-pf_exiting-check-should-take-mm-into-account.patch
oom-introduce-find_lock_task_mm-to-fix-mm-false-positives.patch
oom-dump_tasks-use-find_lock_task_mm-too.patch
oom-improve-commentary-in-dump_tasks.patch
oom-dump_tasks-use-find_lock_task_mm-too-dump_tasks-use-find_lock_task_mm-too-fix.patch
oom-give-current-access-to-memory-reserves-if-it-has-been-killed.patch
oom-avoid-sending-exiting-tasks-a-sigkill.patch
oom-filter-tasks-not-sharing-the-same-cpuset.patch
oom-sacrifice-child-with-highest-badness-score-for-parent.patch
oom-sacrifice-child-with-highest-badness-score-for-parent-protect-dereferencing-of-tasks-comm.patch
oom-sacrifice-child-with-highest-badness-score-for-parent-fix.patch
oom-select-task-from-tasklist-for-mempolicy-ooms.patch
oom-select-task-from-tasklist-for-mempolicy-ooms-add-has_intersects_mems_allowed-uma-variant.patch
oom-select-task-from-tasklist-for-mempolicy-ooms-introduce-find_lock_task_mm-to-fix-mm-false-positives-fix.patch
oom-enable-oom-tasklist-dump-by-default.patch
oom-avoid-oom-killer-for-lowmem-allocations.patch
oom-extract-panic-helper-function.patch
oom-remove-special-handling-for-pagefault-ooms.patch
oom-move-sysctl-declarations-to-oomh.patch
oom-remove-unnecessary-code-and-cleanup.patch
mm-rename-try_set_zone_oom-to-try_set_zonelist_oom.patch
oom-remove-constraint-argument-from-select_bad_process-and-__out_of_memory.patch
oom-fold-__out_of_memory-into-out_of_memory.patch
mm-use-for_each_online_cpu-in-vmstat.patch
mmzoneh-remove-dead-prototype.patch
topology-alternate-fix-for-ia64-tiger_defconfig-build-breakage.patch
mempolicy-reduce-stack-size-of-migrate_pages.patch
mempolicy-reduce-stack-size-of-migrate_pages-fix.patch
gcc-46-pagemap-avoid-unused-but-set-variable.patch
gcc-46-mm-fix-unused-but-set-warnings.patch
tmpfs-add-accurate-compare-function-to-percpu_counter-library.patch
tmpfs-make-tmpfs-scalable-with-percpu_counter-for-used-blocks.patch
tmpfs-make-tmpfs-scalable-with-percpu_counter-for-used-update.patch
shmem-reduce-one-time-of-locking-in-pagefault.patch
shmem-reduce-one-time-of-locking-in-pagefault-fix.patch
mmap-remove-unnecessary-lock-from-__vma_link.patch
rmap-always-add-new-vmas-at-the-end.patch
ksm-fix-ksm-swapin-time-optimization.patch
rmap-always-use-anon_vma-root-pointer.patch
rmap-resurrect-page_address_in_vma-anon_vma-check.patch
add-anon_vma-bug-checks.patch
radix-tree-implement-function-radix_tree_range_tag_if_tagged.patch
mm-implement-writeback-livelock-avoidance-using-page-tagging.patch
vmscan-zone_reclaim-dont-call-disable_swap_token.patch
vmscan-recalculate-lru_pages-on-each-priority.patch
vmscan-tracing-add-trace-events-for-kswapd-wakeup-sleeping-and-direct-reclaim.patch
vmscan-tracing-add-trace-events-for-lru-page-isolation.patch
vmscan-tracing-add-trace-events-for-lru-page-isolation-checkpatch-fixes.patch
vmscan-tracing-add-trace-event-when-a-page-is-written.patch
vmscan-tracing-add-a-postprocessing-script-for-reclaim-related-ftrace-events.patch
vmscan-kill-prev_priority-completely.patch
vmscan-simplify-shrink_inactive_list.patch
vmscan-simplify-shrink_inactive_list-checkpatch-fixes.patch
vmscan-remove-unnecessary-temporary-vars-in-do_try_to_free_pages.patch
vmscan-remove-unnecessary-temporary-vars-in-do_try_to_free_pages-checkpatch-fixes.patch
vmscan-set-up-pagevec-as-late-as-possible-in-shrink_inactive_list.patch
vmscan-set-up-pagevec-as-late-as-possible-in-shrink_page_list.patch
vmscan-update-isolated-page-counters-outside-of-main-path-in-shrink_inactive_list.patch
oom-dont-try-to-kill-oom_unkillable-child.patch
oom-dont-try-to-kill-oom_unkillable-child-checkpatch-fixes.patch
oom-oom_kill_process-doesnt-select-kthread-child.patch
oom-make-oom_unkillable_task-helper-function.patch
oom-oom_kill_process-needs-to-check-that-p-is-unkillable.patch
oom-proc-pid-oom_score-treat-kernel-thread-honestly.patch
oom-kill-duplicate-oom_disable-check.patch
oom-move-oom_disable-check-from-oom_kill_task-to-out_of_memory.patch
oom-cleanup-has_intersects_mems_allowed.patch
oom-remove-child-mm-check-from-oom_kill_process.patch
oom-give-the-dying-task-a-higher-priority.patch
oom-multi-threaded-process-coredump-dont-make-deadlock.patch
oom-move-badness-declaration-into-oomh.patch
oom-move-badness-declaration-into-oomh-fix.patch
rmap-add-exclusive-page-to-private-anon_vma-on-swapin.patch
mm-set-vm_fault_write-in-do_swap_page.patch
drivers-base-nodec-reduce-stack-usage-of-node_read_meminfo.patch
vmscan-avoid-subtraction-of-unsigned-types.patch
vmscan-protect-reading-of-reclaim_stat-with-lru_lock.patch
mmu-notifiers-remove-mmu-notifier-calls-in-apply_to_page_range.patch
mmu-notifiers-remove-mmu-notifier-calls-in-apply_to_page_range-fix.patch
writeback-reduce-calls-to-global_page_state-in-balance_dirty_pages.patch
writeback-avoid-unnecessary-calculation-of-bdi-dirty-thresholds.patch
writeback-avoid-unnecessary-calculation-of-bdi-dirty-thresholds-fix.patch
writeback-dont-redirty-tail-an-inode-with-dirty-pages.patch
writeback-fix-queue_io-ordering.patch
writeback-merge-for_kupdate-and-for_kupdate-cases.patch
vmscan-shrink_slab-require-number-of-lru_pages-not-page-order.patch
frv-duplicate-output_buffer-of-e03.patch
frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch
alpha-add-performance-monitor-interrupt-counter.patch
alpha-add-wrperfmonh-header-file-to-aid-use-of-wrperfmon-palcall.patch
alpha-implement-hw-performance-events-on-the-ev67-and-later-cpus.patch
um-call-free_irq-only-on-enabled-channels.patch
asm-generic-ioh-add-big-endian-versions-of-ioreadwrite1632.patch
include-linux-compiler-gcch-use-__same_type-in-__must_be_array.patch
alpha-h8300-m68k-remove-obsolete-asm-mdh-files.patch
kernelh-remove-unused-nipquad-and-nipquad_fmt.patch
submittingpatches-add-more-about-patch-descriptions.patch
vfs-fix-warning-dirent-is-used-uninitialized-in-this-function.patch
misc-rohm-bh1780gli-ambient-light-sensor-driver.patch
hpilo-fix-pointer-warning-in-ilo_ccb_setup.patch
drivers-misc-support-for-the-pressure-sensor-bmp085-from-bosch-sensortec.patch
drivers-misc-support-for-the-pressure-sensor-bmp085-from-bosch-sensortec-fix.patch
drivers-misc-support-for-the-pressure-sensor-bmp085-from-bosch-sensortec-update.patch
drivers-misc-support-for-the-pressure-sensor-bmp085-from-bosch-sensortec-update-checkpatch-fixes.patch
add-abi-documentation-for-the-bmp085-digital-pressure-sensor.patch
bmp085-add-interface-documentation-and-link-to-datasheet.patch
sys_personality-remove-the-bogus-checks-in-sys_personality-__set_personality-path.patch
kernel-range-remove-unused-definition-of-array_size.patch
init-mainc-fix-warning-calltimetv64-may-be-used-uninitialized.patch
init-mainc-mark-do_one_initcall-as-__init_or_module.patch
char-add-warn_on-in-misc_deregister.patch
s390-remove-warn_on-for-misc_deregister-failures.patch
gcc-46-printk-use-stable-variable-to-dump-kmsg-buffer.patch
maintainers-update-arm-bcmring-mtd-nand-driver-file-patterns.patch
maintainers-update-arm-nuvoton-w90x900-arm-architecture-file-patterns.patch
maintainers-update-arm-voipac-pxa270-file-patterns.patch
maintainers-update-arm-zipit-z2-support-file-patterns.patch
maintainers-update-networking-file-patterns.patch
maintainers-update-ppp-over-l2tp-file-patterns.patch
maintainers-update-ricoh-smartmedia-xd-driver-file-patterns.patch
maintainers-remove-section-smx-uio-interface.patch
maintainers-update-spear-clock-framework-support-file-patterns.patch
maintainers-remove-section-strip.patch
maintainers-remove-section-wavelan-network-driver-wireless-extensions.patch
maintainers-add-file-patterns-to-uclinux-for-renesas-h8-300.patch
maintainers-update-drm-drivers-patterns.patch
maintainers-add-patterns-to-cryptographic-random-number-generator.patch
maintainers-add-patterns-to-dell-wmi-extras.patch
maintainers-add-patterns-to-powerpc-embedded-ppc8xx.patch
maintainers-add-patterns-to-omap-usb.patch
maintainers-remove-section-promise-dc4030.patch
maintainers-add-patterns-to-ps3vram-driver.patch
maintainers-add-patterns-to-wimax-stack.patch
maintainers-update-information-about-linux-test-project-maintainence.patch
maintainers-update-laurent-pinchart-email.patch
edd-fix-possible-memory-leak-in-edd_init-error-path.patch
edd-fix-possible-memory-leak-in-edd_init-error-path-fix.patch
mmc-recognize-csd-structure.patch
mmc-recognize-csd-structure-fix.patch
mmc-split-mmc_sd_init_card.patch
mmc-implement-sd-combo-iomem-support.patch
s5pc110-sdhci-s3c-can-override-host-capabilities.patch
s5pc110-sdhci-s3c-support-on-s5pc110.patch
sdhci-add-no-hi-speed-bit-quirk-support.patch
mmc-fix-all-hangs-related-to-mmc-sd-card-insert-removal-during-suspend-resume.patch
mmc-fix-all-hangs-related-to-mmc-sd-card-insert-removal-during-suspend-resume-fix.patch
mmc-make-sdhci-work-with-ricoh-mmc-controller.patch
sdhci-remove-useless-set_clock-check.patch
sdhci-8-bit-data-transfer-width-support.patch
sdhci-dont-assign-mmc-caps-at-sdhci-directly.patch
mmc-only-set-blockaddressed-for-2gib-cards.patch
mmc-omap-fix-for-bus-width-which-improves-sd-cards-peformance.patch
mmc-add-jz4740-mmc-driver.patch
mmc-add-jz4740-mmc-driver-v6.patch
sdhci-pltfm-switch-to-module-device-table-matching.patch
sdhci-pltfm-reorganize-makefile-entries-to-support-soc-devices.patch
sdhci-pltfm-add-support-for-cns3xxx-soc-devices.patch
sdio-allow-non-standard-sdio-cards.patch
omap_hsmmc-add-init_card-pass-through-callback.patch
omap-pandora-pass-wl1251-information-to-sdio-core.patch
tmio_mmc-prevent-unexpected-status-clear.patch
tmio_mmc-revise-limit-on-data-size.patch
sdhci-s3c-add-support-for-the-non-standard-minimal-clock-value.patch
sdhci-s3c-add-support-for-new-card-detection-methods.patch
sdhci-s3c-add-support-for-new-card-detection-methods-update.patch
mmc-add-erase-secure-erase-trim-and-secure-trim-operations.patch
mmc_block-add-discard-support.patch
omap_hsmmc-add-erase-capability.patch
block-add-secure-discard.patch
mmc_block-add-support-for-secure-discard.patch
checkpatch-refactor-allowed-asm-includes-and-add-memoryh.patch
checkpatchpl-add-check-for-space-after-struct-or-union-definition.patch
checkpatch-fix-handling-of-leading-spaces.patch
drivers-hwmon-hdapsc-add-lenovo-thinkpad-t400-to-the-whitelist.patch
hmc6352-add-driver-for-the-hmc6352-compass.patch
hwmon-driver-for-smm665-six-channel-active-dc-output-controller-monitor.patch
hwmon-smm665-driver-documentation.patch
hwmon-update-maintainers-for-smm665-driver.patch
hwmon-add-support-for-jedec-jc-424-compliant-temperature-sensors.patch
hwmon-add-support-for-jedec-jc-424-compliant-temperature-sensors-v3.patch
rwsem-fully-separate-code-pathes-to-wake-writers-vs-readers.patch
rwsem-lighter-active-count-checks-when-waking-up-readers.patch
rwsem-let-rwsem_waiting_bias-represent-any-number-of-waiting-threads.patch
rwsem-wake-queued-readers-when-writer-blocks-on-active-read-lock.patch
rwsem-smaller-wrappers-around-rwsem_down_failed_common.patch
fix-vc-vc_origin-on-take_over_console.patch
fix-vc-vc_origin-on-take_over_console-checkpatch-fixes.patch
drivers-char-vtc-vc_do_resize-local-var-end-should-be-unsigned-long.patch
drivers-char-vtc-vc_do_resize-local-var-end-should-be-unsigned-long-update.patch
drivers-message-i2o-exec-osmc-add-missing-mutex_unlock.patch
autofs4-remove-unneeded-null-check-in-try_to_fill_dentry.patch
nuc900-rtc-change-the-waiting-for-device-ready-implement.patch
rtc-nuc900-fix-checking-of-args-during-time-setting.patch
drivers-rtc-rtc-pcf8563c-remove-unused-struct.patch
rtc-pxa-remove-unused-field.patch
rtc-m48t59-kfreenull-is-ok.patch
rtc-rtc-mxc-remove-six-unused-fields.patch
rtc-fixes-and-new-functionality-for-fm3130.patch
rtc-fixes-and-new-functionality-for-fm3130-fix.patch
rtc-pxa-remove-unnecessary-private-ops-ioctl.patch
drivers-rtc-rtc-pl031c-remove-unused-include-linux-versionh.patch
rtc-driver-for-the-dryice-block-found-in-imx25-chips.patch
rtc-add-intersil-isl12022-rtc-driver.patch
rtc-m41t80-use-rtc_valid_tm-to-check-returned-tm.patch
rtc-max6900-use-rtc_valid_tm-to-check-returning-tm.patch
rtc-m48t59-use-rtc_valid_tm-to-check-returned-tm.patch
rtc-m48t86-use-rtc_valid_tm-to-check-returned-tm.patch
rtc-nuc900-make-returning-time-checking-function-valid.patch
rtc-nuc900-modify-enable-disable-irqs-and-driver-data-setting-location.patch
rtc-nuc900-fix-build-warning.patch
rtc-add-support-for-ds3232-rtc.patch
rtc-add-support-for-ds3232-rtc-fix.patch
gpio-max730x-make-pullups-configurable-via-platformdata.patch
pcf857x-support-working-w-o-platform-data.patch
gpiolib-decouple-might_sleep_if-from-debug.patch
gpio-sx150x-add-semtech-i2c-sx150x-gpio-expander-driver.patch
gpio-sx150x-add-semtech-i2c-sx150x-gpio-expander-driver-disable.patch
gpiolib-get-rid-of-struct-poll_desc-and-worklet.patch
gpiolib-allow-nested-threaded-irqs-for-poll2.patch
fbdev-efifb-section-fixes.patch
fbcon-deinline-large-static-function-get_color.patch
drivers-video-via-via-gpioc-fix-warning.patch
fbcon-uninline-four-foo_update_attr-functions.patch
drivers-video-fbmemc-simplify-strlen==0-check-in-fb_get_options.patch
s3c-fb-change-to-depending-on-config_s3c_fb_dev.patch
s3c-fb-add-default-window-feature.patch
s3c-fb-fix-distortedness-situation-for-the-mode-more-then-24bpp.patch
s3c-fb-only-init-window-colour-key-controls-for-windows-with-blending.patch
s3c-fb-initial-move-to-unifying-the-header-files.patch
s3c-fb-udpate-to-support-s3c2416-s3c2443-style-hardware.patch
s3c-fb-integrate-palette-setup-code-into-main-driver.patch
s3c-fb-fix-various-null-references-on-framebuffer-memory-alloc-failure.patch
s3c-fb-correct-framesel1-bitfield-defines-for-vidintcon0-register.patch
s3c-fb-separate-s5pc100-and-s5pv210-framebuffer-driver-data-structures.patch
s3c-fb-add-device-name-initialization.patch
s3c-fb-add-support-for-display-panning.patch
s3c-fb-add-wait-for-vsync-ioctl.patch
s3c-fb-window-3-of-64xx-does-not-have-an-osd_d-register.patch
s3c-fb-add-shadowcon-shadow-register-locking-support-for-s5pv210.patch
s3c-fb-correct-window-osd-size-and-alpha-register-handling.patch
s3c-fb-protect-window-specific-registers-during-updates.patch
s3c-fb-fix-section-mismatch.patch
s3c-fb-add-support-for-dma-channel-control-on-s5pv210.patch
s3c-fb-automatically-calculate-pixel-clock-when-none-is-given.patch
arm-samsung-remove-pixclock-from-several-boards.patch
hfsplus-identify-journal-info-block-in-volume-header.patch
hfsplus-fix-journal-detection.patch
reiserfs-remove-unused-local-wait.patch
fusion-fix-kernel-doc-warnings.patch
timerc-fix-kernel-doc-warning.patch
mtd-nand_base-fix-kernel-doc-warnings-typos.patch
documentation-networking-wavelantxt-deleted-not-in-tree.patch
docbook-need-xmldoclinks-for-all-doc-types.patch
cgroups-save-space-for-the-terminator.patch
blkdev-cgroup-whitelist-permission-fix.patch
memcg-remove-experimental-from-swap-account-config.patch
memcg-clean-up-try_charge-main-loop-v2.patch
memcg-clean-up-waiting-move-acct-v2.patch
memcg-clean-up-waiting-move-acct-v2-fix.patch
memcg-remove-redundant-codes.patch
memcg-remove-mem-from-arg-of-charge_common.patch
memcg-use-find_lock_task_mm-in-memory-cgroups-oom.patch
memcg-avoid-css_get.patch
procfs-simplify-conditional-processing-of-fs-proco.patch
drivers-char-ipmi-ipmi_si_intfc-fix-warning-variable-addr_space-set-but-not-used.patch
drivers-char-n_gsmc-add-missing-spin_unlock_irqrestore.patch
drivers-char-add-packet-hub-driver-for-the-topcliff-pch.patch
drivers-char-add-packet-hub-driver-for-the-topcliff-pch-update.patch
cs5535-mfgpt-reuse-timers-that-have-never-been-set-up.patch
partitions-fix-sometimes-unreadable-partition-strings.patch
pids-fix-a-race-in-pid-generation-that-causes-pids-to-be-reused-immediately.patch
pids-alloc_pidmap-remove-the-unnecessary-boundary-checks.patch
delay-accounting-re-implement-c-for-getdelaysc-to-report-information-on-a-target-command.patch
delay-accounting-re-implement-c-for-getdelaysc-to-report-information-on-a-target-command-checkpatch-fixes.patch
delayacct-align-to-8-byte-boundary-on-64-bit-systems.patch
edac-add-wissing-pieces-from-mpc85xx-fsl_soc_booke.patch
dma-mapping-rename-arch_kmalloc_minalign-to-arch_dma_minalign.patch
dma-mapping-unify-dma_get_cache_alignment-implementations.patch
dma-mapping-parisc-set-arch_dma_minalign.patch
panic-keep-blinking-in-spite-of-long-spin-timer-mode.patch
lib-bugc-make-warn-implementation-match-the-kernel-panicc-one.patch
lib-bugc-make-warn-implementation-match-the-kernel-panicc-one-checkpatch-fixes.patch
add-oops-end-marker-to-lib-bugc-warn-implementation.patch
parport_serial-use-the-pci-irq-if-offered.patch
aio-do-not-return-erestartsys-and-friends-from-aio.patch
aio-always-reinitialize-iocb-ki_run_list-at-the-end-of-aio_run_iocb.patch
kfifo-kfifo_is_fullempty-should-return-bools-not-ints.patch
kfifo-fix-kfifo-miss-use-of-nozamic.patch
kfifo-add-the-new-generic-kfifo-api.patch
kfifo-replace-the-old-non-generic-api.patch
kfifo-add-example-files-to-the-kernel-sample-directory.patch
kfifo-add-example-files-to-the-kernel-sample-directory-checkpatch-fixes.patch
lib-decompress_bunzip2c-fix-checkstack-warning.patch
time-kill-off-config_generic_time.patch
vfs-add-super-operation-writeback_inodes.patch
vfs-add-super-operation-writeback_inodes-fix.patch
vfs-take-2add-set_page_dirty_notag.patch
vfs-change-writeback_inodes-signature.patch
reiser4-export-remove_from_page_cache.patch
reiser4-export-remove_from_page_cache-fix.patch
reiser4-export-find_get_pages.patch
reiser4.patch
reiser4-rename-quota-methods.patch
reiser4-remove-inode_setattr.patch
reiser4-change-fsync-signature.patch
reiser4-writeback_inodes-implementation.patch
reiser4-writeback_inodes-implementation-fix.patch
reiser4-writeback_inodes-implementation-adjust-to-writeback-changes.patch
reiser4-fixup-checkin-checkout-jnodes-for-entd.patch
reiser4-fixups.patch
reiser4-broke.patch
make-sure-nobodys-leaking-resources.patch
journal_add_journal_head-debug.patch
releasing-resources-with-children.patch
make-frame_pointer-default=y.patch
mutex-subsystem-synchro-test-module.patch
mutex-subsystem-synchro-test-module-add-missing-header-file.patch
slab-leaks3-default-y.patch
put_bh-debug.patch
add-debugging-aid-for-memory-initialisation-problems.patch
workaround-for-a-pci-restoring-bug.patch
prio_tree-debugging-patch.patch
single_open-seq_release-leak-diagnostics.patch
add-a-refcount-check-in-dput.patch
getblk-handle-2tb-devices.patch
On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
> The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
Throws a warning at boot:
[ 1.786060] WARNING: at kernel/pm_qos_params.c:264 pm_qos_update_request+0x28/0x54()
[ 1.786088] Hardware name: Latitude E6500
[ 1.787045] pm_qos_update_request() called for unknown object
[ 1.787966] Modules linked in:
[ 1.788940] Pid: 1, comm: swapper Not tainted 2.6.35-rc5-mmotm0719 #1
[ 1.790035] Call Trace:
[ 1.791121] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
[ 1.792205] [<ffffffff810373e1>] warn_slowpath_fmt+0x41/0x43
[ 1.793279] [<ffffffff81057c14>] pm_qos_update_request+0x28/0x54
[ 1.794347] [<ffffffff8134889e>] e1000_configure+0x421/0x459
[ 1.795393] [<ffffffff8134afbd>] e1000_open+0xbd/0x37c
[ 1.796436] [<ffffffff8105743a>] ? raw_notifier_call_chain+0xf/0x11
[ 1.797491] [<ffffffff8145f948>] __dev_open+0xae/0xe2
[ 1.798547] [<ffffffff8145f997>] dev_open+0x1b/0x49
[ 1.799612] [<ffffffff8146e36e>] netpoll_setup+0x84/0x259
[ 1.800685] [<ffffffff81b5037c>] init_netconsole+0xbc/0x21f
[ 1.801744] [<ffffffff81b5026c>] ? sir_wq_init+0x0/0x35
[ 1.802793] [<ffffffff81b502c0>] ? init_netconsole+0x0/0x21f
[ 1.803845] [<ffffffff810002ff>] do_one_initcall+0x7a/0x12f
[ 1.804885] [<ffffffff81b2ccae>] kernel_init+0x138/0x1c2
[ 1.805915] [<ffffffff81003554>] kernel_thread_helper+0x4/0x10
[ 1.806937] [<ffffffff81590e00>] ? restore_args+0x0/0x30
[ 1.807955] [<ffffffff81b2cb76>] ? kernel_init+0x0/0x1c2
[ 1.808958] [<ffffffff81003550>] ? kernel_thread_helper+0x0/0x10
[ 1.809958] ---[ end trace 84b562a00a60539e ]---
Looks like a repeat of something I reported against -mmotm 2010-05-11, though a
WARNING rather than an outright crash - the traceback is pretty much identical.
I have *no* idea why -rc3-mmotm0701 doesn't whinge similarly.
On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
> The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
(Andrew - did we lose a bunch of -swedish-chef-fix-fix-fix.patch files? This is the second
thing that I reported back in May, worked in mm-rc3-0701, but dies in -rc5-0719...)
[ 50.949361] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 50.950978] IP: [<(null)>] (null)
[ 50.952045] PGD 11b7b0067 PUD 119d9c067 PMD 0
[ 50.954744] Oops: 0010 [#1] PREEMPT SMP
[ 50.954744] last sysfs file: /sys/devices/pci0000:00/0000:00:1b.0/device
[ 50.954744] CPU 0
[ 50.954744] Modules linked in: microcode(+) [last unloaded: scsi_wait_scan]
[ 50.954744]
[ 50.967468] Pid: 2994, comm: keymap Tainted: G W 2.6.35-rc5-mmotm0719 #1 0X564R/Latitude E6500
[ 50.967468] RIP: 0010:[<0000000000000000>] [<(null)>] (null)
[ 50.967468] RSP: 0018:ffff88011e7e5cb0 EFLAGS: 00010046
[ 50.967468] RAX: 0000000000000000 RBX: ffff88011d8b5000 RCX: 0000000000000000
[ 50.967468] RDX: ffff88011e7e5cc8 RSI: ffff88011e7e5cc8 RDI: ffff88011d8b5000
[ 50.967468] RBP: ffff88011e7e5d28 R08: 0890000000000000 R09: 0000000000000001
[ 50.967468] R10: ffff88011d8b5858 R11: ffff88011d8b5840 R12: 0000000000000000
[ 50.967468] R13: 00000000000000a4 R14: ffff88011d8b5840 R15: 0000000000000296
[ 50.967468] FS: 00007fea0676e720(0000) GS:ffff880002600000(0000) knlGS:0000000000000000
[ 50.967468] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 50.967468] CR2: 0000000000000000 CR3: 000000011f72b000 CR4: 00000000000406f0
[ 50.967468] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 50.967468] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 50.967468] Process keymap (pid: 2994, threadinfo ffff88011e7e4000, task ffff88011e620100)
[ 50.967468] Stack:
[ 50.967468] ffffffff813b4b54 ffff88011e7e5cc8 0000008100000246 00000081000000a4
[ 50.967468] <0> 0000000000000004 0000000000000000 ffff88011e7e5cc4 00007fffe9f95f00
[ 50.967468] <0> ffff88011b4a3300 ffff88011e7e5d28 0000000000000081 fffffffffffffff2
[ 50.967468] Call Trace:
[ 50.967468] [<ffffffff813b4b54>] ? input_set_keycode+0xbc/0x13c
[ 50.967468] [<ffffffff813b7ee2>] evdev_do_ioctl+0x24c/0x816
[ 51.016215] [<ffffffff813b84e6>] ? evdev_ioctl_handler+0x3a/0x81
[ 51.018336] [<ffffffff813b84e6>] ? evdev_ioctl_handler+0x3a/0x81
[ 51.021130] [<ffffffff813b8510>] evdev_ioctl_handler+0x64/0x81
[ 51.022519] [<ffffffff813b854a>] evdev_ioctl+0xb/0xd
[ 51.024439] [<ffffffff810e91a0>] vfs_ioctl+0x31/0xa2
[ 51.026408] [<ffffffff810e9b1f>] do_vfs_ioctl+0x496/0x4c9
[ 51.028337] [<ffffffff810e9ba9>] sys_ioctl+0x57/0x96
[ 51.030245] [<ffffffff8100272b>] system_call_fastpath+0x16/0x1b
[ 51.032123] Code: Bad RIP value.
[ 51.034015] RIP [<(null)>] (null)
[ 51.037307] RSP <ffff88011e7e5cb0>
[ 51.038270] CR2: 0000000000000000
[ 51.038270] ---[ end trace 84b562a00a6053a0 ]---
And things go downhill from there...
On Tue, Jul 20, 2010 at 04:41:32PM -0400, [email protected] wrote:
> On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
> > The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> (Andrew - did we lose a bunch of -swedish-chef-fix-fix-fix.patch files? This is the second
> thing that I reported back in May, worked in mm-rc3-0701, but dies in -rc5-0719...)
>
> [ 50.949361] BUG: unable to handle kernel NULL pointer dereference at (null)
> [ 50.950978] IP: [<(null)>] (null)
> [ 50.952045] PGD 11b7b0067 PUD 119d9c067 PMD 0
> [ 50.954744] Oops: 0010 [#1] PREEMPT SMP
> [ 50.954744] last sysfs file: /sys/devices/pci0000:00/0000:00:1b.0/device
> [ 50.954744] CPU 0
> [ 50.954744] Modules linked in: microcode(+) [last unloaded: scsi_wait_scan]
> [ 50.954744]
> [ 50.967468] Pid: 2994, comm: keymap Tainted: G W 2.6.35-rc5-mmotm0719 #1 0X564R/Latitude E6500
> [ 50.967468] RIP: 0010:[<0000000000000000>] [<(null)>] (null)
> [ 50.967468] RSP: 0018:ffff88011e7e5cb0 EFLAGS: 00010046
> [ 50.967468] RAX: 0000000000000000 RBX: ffff88011d8b5000 RCX: 0000000000000000
> [ 50.967468] RDX: ffff88011e7e5cc8 RSI: ffff88011e7e5cc8 RDI: ffff88011d8b5000
> [ 50.967468] RBP: ffff88011e7e5d28 R08: 0890000000000000 R09: 0000000000000001
> [ 50.967468] R10: ffff88011d8b5858 R11: ffff88011d8b5840 R12: 0000000000000000
> [ 50.967468] R13: 00000000000000a4 R14: ffff88011d8b5840 R15: 0000000000000296
> [ 50.967468] FS: 00007fea0676e720(0000) GS:ffff880002600000(0000) knlGS:0000000000000000
> [ 50.967468] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 50.967468] CR2: 0000000000000000 CR3: 000000011f72b000 CR4: 00000000000406f0
> [ 50.967468] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [ 50.967468] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> [ 50.967468] Process keymap (pid: 2994, threadinfo ffff88011e7e4000, task ffff88011e620100)
> [ 50.967468] Stack:
> [ 50.967468] ffffffff813b4b54 ffff88011e7e5cc8 0000008100000246 00000081000000a4
> [ 50.967468] <0> 0000000000000004 0000000000000000 ffff88011e7e5cc4 00007fffe9f95f00
> [ 50.967468] <0> ffff88011b4a3300 ffff88011e7e5d28 0000000000000081 fffffffffffffff2
> [ 50.967468] Call Trace:
> [ 50.967468] [<ffffffff813b4b54>] ? input_set_keycode+0xbc/0x13c
> [ 50.967468] [<ffffffff813b7ee2>] evdev_do_ioctl+0x24c/0x816
> [ 51.016215] [<ffffffff813b84e6>] ? evdev_ioctl_handler+0x3a/0x81
> [ 51.018336] [<ffffffff813b84e6>] ? evdev_ioctl_handler+0x3a/0x81
> [ 51.021130] [<ffffffff813b8510>] evdev_ioctl_handler+0x64/0x81
> [ 51.022519] [<ffffffff813b854a>] evdev_ioctl+0xb/0xd
> [ 51.024439] [<ffffffff810e91a0>] vfs_ioctl+0x31/0xa2
> [ 51.026408] [<ffffffff810e9b1f>] do_vfs_ioctl+0x496/0x4c9
> [ 51.028337] [<ffffffff810e9ba9>] sys_ioctl+0x57/0x96
> [ 51.030245] [<ffffffff8100272b>] system_call_fastpath+0x16/0x1b
> [ 51.032123] Code: Bad RIP value.
> [ 51.034015] RIP [<(null)>] (null)
> [ 51.037307] RSP <ffff88011e7e5cb0>
> [ 51.038270] CR2: 0000000000000000
> [ 51.038270] ---[ end trace 84b562a00a6053a0 ]---
>
> And things go downhill from there...
This looks like the same trace we got in the Red Hat bugzilla a few days
ago, and for which I submitted this:
https://patchwork.kernel.org/patch/112791/
--
Jarod Wilson
[email protected]
On Tue, 20 Jul 2010 16:35:25 -0400
[email protected] wrote:
> On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
> > The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
>
> Throws a warning at boot:
>
> [ 1.786060] WARNING: at kernel/pm_qos_params.c:264 pm_qos_update_request+0x28/0x54()
> [ 1.786088] Hardware name: Latitude E6500
> [ 1.787045] pm_qos_update_request() called for unknown object
> [ 1.787966] Modules linked in:
> [ 1.788940] Pid: 1, comm: swapper Not tainted 2.6.35-rc5-mmotm0719 #1
> [ 1.790035] Call Trace:
> [ 1.791121] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
> [ 1.792205] [<ffffffff810373e1>] warn_slowpath_fmt+0x41/0x43
> [ 1.793279] [<ffffffff81057c14>] pm_qos_update_request+0x28/0x54
> [ 1.794347] [<ffffffff8134889e>] e1000_configure+0x421/0x459
> [ 1.795393] [<ffffffff8134afbd>] e1000_open+0xbd/0x37c
> [ 1.796436] [<ffffffff8105743a>] ? raw_notifier_call_chain+0xf/0x11
> [ 1.797491] [<ffffffff8145f948>] __dev_open+0xae/0xe2
> [ 1.798547] [<ffffffff8145f997>] dev_open+0x1b/0x49
> [ 1.799612] [<ffffffff8146e36e>] netpoll_setup+0x84/0x259
> [ 1.800685] [<ffffffff81b5037c>] init_netconsole+0xbc/0x21f
> [ 1.801744] [<ffffffff81b5026c>] ? sir_wq_init+0x0/0x35
> [ 1.802793] [<ffffffff81b502c0>] ? init_netconsole+0x0/0x21f
> [ 1.803845] [<ffffffff810002ff>] do_one_initcall+0x7a/0x12f
> [ 1.804885] [<ffffffff81b2ccae>] kernel_init+0x138/0x1c2
> [ 1.805915] [<ffffffff81003554>] kernel_thread_helper+0x4/0x10
> [ 1.806937] [<ffffffff81590e00>] ? restore_args+0x0/0x30
> [ 1.807955] [<ffffffff81b2cb76>] ? kernel_init+0x0/0x1c2
> [ 1.808958] [<ffffffff81003550>] ? kernel_thread_helper+0x0/0x10
> [ 1.809958] ---[ end trace 84b562a00a60539e ]---
>
> Looks like a repeat of something I reported against -mmotm 2010-05-11, though a
> WARNING rather than an outright crash - the traceback is pretty much identical.
> I have *no* idea why -rc3-mmotm0701 doesn't whinge similarly.
>
I don't recall you reporting that, sorry.
The warning was added by
: commit 82f682514a5df89ffb3890627eebf0897b7a84ec
: Author: James Bottomley <[email protected]>
: AuthorDate: Mon Jul 5 22:53:06 2010 +0200
: Commit: Rafael J. Wysocki <[email protected]>
: CommitDate: Mon Jul 19 02:00:34 2010 +0200
:
: pm_qos: Get rid of the allocation in pm_qos_add_request()
It's a pretty crappy warning too. Neither the warning nor the code
comments provide developers with any hint as to what they have done
wrong, nor what they must do to fix things. And the patch changelog
doesn't mention the new warnings *at all*.
So one must assume that the people who stuck this thing in the tree
have volunteered to fix e1000e. Let's cc 'em.
On Tue, 20 Jul 2010 13:50:27 PDT, Dmitry Torokhov said:
> > And things go downhill from there...
>
> I guess you need these 2 from Jarod...
Hmm. I seem to remember 2 similar patches from the last time I reported it. :)
System boots fine after applying those two patches. I'll let somebody else
worry about making sure they end up in linux-next in time for the next merge
window...
On Tue, Jul 20, 2010 at 05:11:40PM -0400, [email protected] wrote:
> On Tue, 20 Jul 2010 13:50:27 PDT, Dmitry Torokhov said:
>
> > > And things go downhill from there...
> >
> > I guess you need these 2 from Jarod...
>
> Hmm. I seem to remember 2 similar patches from the last time I reported it. :)
>
> System boots fine after applying those two patches. I'll let somebody else
> worry about making sure they end up in linux-next in time for the next merge
> window...
I believe Mauro's on vacation at the moment, but due back Real Soon Now,
and I'd expect him to pick up both fixes shortly after he settles back in
at his desk, so they should be in next before much longer, and definitely
before the merge window.
--
Jarod Wilson
[email protected]
On Tue, 20 Jul 2010 14:07:51 -0700
Andrew Morton <[email protected]> wrote:
> On Tue, 20 Jul 2010 16:35:25 -0400
> [email protected] wrote:
>
> > On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
> > > The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
> > >
> > > http://userweb.kernel.org/~akpm/mmotm/
> >
> > Throws a warning at boot:
> >
> > [ 1.786060] WARNING: at kernel/pm_qos_params.c:264 pm_qos_update_request+0x28/0x54()
> > [ 1.786088] Hardware name: Latitude E6500
> > [ 1.787045] pm_qos_update_request() called for unknown object
> > [ 1.787966] Modules linked in:
> > [ 1.788940] Pid: 1, comm: swapper Not tainted 2.6.35-rc5-mmotm0719 #1
> > [ 1.790035] Call Trace:
> > [ 1.791121] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
> > [ 1.792205] [<ffffffff810373e1>] warn_slowpath_fmt+0x41/0x43
> > [ 1.793279] [<ffffffff81057c14>] pm_qos_update_request+0x28/0x54
> > [ 1.794347] [<ffffffff8134889e>] e1000_configure+0x421/0x459
> > [ 1.795393] [<ffffffff8134afbd>] e1000_open+0xbd/0x37c
> > [ 1.796436] [<ffffffff8105743a>] ? raw_notifier_call_chain+0xf/0x11
> > [ 1.797491] [<ffffffff8145f948>] __dev_open+0xae/0xe2
> > [ 1.798547] [<ffffffff8145f997>] dev_open+0x1b/0x49
> > [ 1.799612] [<ffffffff8146e36e>] netpoll_setup+0x84/0x259
> > [ 1.800685] [<ffffffff81b5037c>] init_netconsole+0xbc/0x21f
> > [ 1.801744] [<ffffffff81b5026c>] ? sir_wq_init+0x0/0x35
> > [ 1.802793] [<ffffffff81b502c0>] ? init_netconsole+0x0/0x21f
> > [ 1.803845] [<ffffffff810002ff>] do_one_initcall+0x7a/0x12f
> > [ 1.804885] [<ffffffff81b2ccae>] kernel_init+0x138/0x1c2
> > [ 1.805915] [<ffffffff81003554>] kernel_thread_helper+0x4/0x10
> > [ 1.806937] [<ffffffff81590e00>] ? restore_args+0x0/0x30
> > [ 1.807955] [<ffffffff81b2cb76>] ? kernel_init+0x0/0x1c2
> > [ 1.808958] [<ffffffff81003550>] ? kernel_thread_helper+0x0/0x10
> > [ 1.809958] ---[ end trace 84b562a00a60539e ]---
> >
> > Looks like a repeat of something I reported against -mmotm 2010-05-11, though a
> > WARNING rather than an outright crash - the traceback is pretty much identical.
> > I have *no* idea why -rc3-mmotm0701 doesn't whinge similarly.
> >
>
> I don't recall you reporting that, sorry.
>
> The warning was added by
>
> : commit 82f682514a5df89ffb3890627eebf0897b7a84ec
> : Author: James Bottomley <[email protected]>
> : AuthorDate: Mon Jul 5 22:53:06 2010 +0200
> : Commit: Rafael J. Wysocki <[email protected]>
> : CommitDate: Mon Jul 19 02:00:34 2010 +0200
> :
> : pm_qos: Get rid of the allocation in pm_qos_add_request()
>
>
> It's a pretty crappy warning too. Neither the warning nor the code
> comments provide developers with any hint as to what they have done
> wrong, nor what they must do to fix things. And the patch changelog
> doesn't mention the new warnings *at all*.
>
> So one must assume that the people who stuck this thing in the tree
> have volunteered to fix e1000e. Let's cc 'em.
>
e1000 calls update_request before registering said request with pm_qos.
This was silently ignored before but now emits a warning. The warning
is sound, because it means, that the constraint-request didn't take
effect.
The right thing is probably to register the request before
calling update_request.
Attached patch moves the registering from e1000_up to e1000_open and
the unregistering from e1000_down to e1000_close.
It is only compile-tested as I don't have the hardware.
Cheers,
Flo
p.s.: sorry if this get's mangled or is wrongly formatted, i'm just using
the "insert file" option of my mailclient and crossing my fingers...
>From 693c71b911ff0845c872261d5704a1d40960722d Mon Sep 17 00:00:00 2001
From: Florian Mickler <[email protected]>
Date: Wed, 21 Jul 2010 08:44:21 +0200
Subject: [PATCH] e1000e: register pm_qos request on hardware activation
The pm_qos_add_request call has to register the pm_qos request with the pm_qos
susbsystem before first use of the pm_qos request via
pm_qos_update_request.
As pm_qos changed to use plists there is no benefit in registering and
unregistering the pm_qos request on ifup/ifdown and thus we move the
registering into e1000_open and the unregistering in e1000_close.
This fixes the following warning:
[ 1.786060] WARNING: at kernel/pm_qos_params.c:264
pm_qos_update_request+0x28/0x54()
[ 1.786088] Hardware name: Latitude E6500
[ 1.787045] pm_qos_update_request() called for unknown object
[ 1.787966] Modules linked in:
[ 1.788940] Pid: 1, comm: swapper Not tainted 2.6.35-rc5-mmotm0719 #1
[ 1.790035] Call Trace:
[ 1.791121] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
[ 1.792205] [<ffffffff810373e1>] warn_slowpath_fmt+0x41/0x43
[ 1.793279] [<ffffffff81057c14>] pm_qos_update_request+0x28/0x54
[ 1.794347] [<ffffffff8134889e>] e1000_configure+0x421/0x459
[ 1.795393] [<ffffffff8134afbd>] e1000_open+0xbd/0x37c
[ 1.796436] [<ffffffff8105743a>] ? raw_notifier_call_chain+0xf/0x11
[ 1.797491] [<ffffffff8145f948>] __dev_open+0xae/0xe2
[ 1.798547] [<ffffffff8145f997>] dev_open+0x1b/0x49
[ 1.799612] [<ffffffff8146e36e>] netpoll_setup+0x84/0x259
[ 1.800685] [<ffffffff81b5037c>] init_netconsole+0xbc/0x21f
[ 1.801744] [<ffffffff81b5026c>] ? sir_wq_init+0x0/0x35
[ 1.802793] [<ffffffff81b502c0>] ? init_netconsole+0x0/0x21f
[ 1.803845] [<ffffffff810002ff>] do_one_initcall+0x7a/0x12f
[ 1.804885] [<ffffffff81b2ccae>] kernel_init+0x138/0x1c2
[ 1.805915] [<ffffffff81003554>] kernel_thread_helper+0x4/0x10
[ 1.806937] [<ffffffff81590e00>] ? restore_args+0x0/0x30
[ 1.807955] [<ffffffff81b2cb76>] ? kernel_init+0x0/0x1c2
[ 1.808958] [<ffffffff81003550>] ? kernel_thread_helper+0x0/0x10
[ 1.809958] ---[ end trace 84b562a00a60539e ]---
Signed-off-by: Florian Mickler <[email protected]>
---
drivers/net/e1000e/netdev.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 8ba366a..1bd9054 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -3218,12 +3218,6 @@ int e1000e_up(struct e1000_adapter *adapter)
{
struct e1000_hw *hw = &adapter->hw;
- /* DMA latency requirement to workaround early-receive/jumbo issue */
- if (adapter->flags & FLAG_HAS_ERT)
- pm_qos_add_request(&adapter->netdev->pm_qos_req,
- PM_QOS_CPU_DMA_LATENCY,
- PM_QOS_DEFAULT_VALUE);
-
/* hardware has been reset, we need to reload some things */
e1000_configure(adapter);
@@ -3287,9 +3281,6 @@ void e1000e_down(struct e1000_adapter *adapter)
e1000_clean_tx_ring(adapter);
e1000_clean_rx_ring(adapter);
- if (adapter->flags & FLAG_HAS_ERT)
- pm_qos_remove_request(&adapter->netdev->pm_qos_req);
-
/*
* TODO: for power management, we could drop the link and
* pci_disable_device here.
@@ -3524,6 +3515,12 @@ static int e1000_open(struct net_device *netdev)
E1000_MNG_DHCP_COOKIE_STATUS_VLAN))
e1000_update_mng_vlan(adapter);
+ /* DMA latency requirement to workaround early-receive/jumbo issue */
+ if (adapter->flags & FLAG_HAS_ERT)
+ pm_qos_add_request(&adapter->netdev->pm_qos_req,
+ PM_QOS_CPU_DMA_LATENCY,
+ PM_QOS_DEFAULT_VALUE);
+
/*
* before we allocate an interrupt, we must be ready to handle it.
* Setting DEBUG_SHIRQ in the kernel makes it fire an interrupt
@@ -3628,6 +3625,9 @@ static int e1000_close(struct net_device *netdev)
if (adapter->flags & FLAG_HAS_AMT)
e1000_release_hw_control(adapter);
+ if (adapter->flags & FLAG_HAS_ERT)
+ pm_qos_remove_request(&adapter->netdev->pm_qos_req);
+
pm_runtime_put_sync(&pdev->dev);
return 0;
--
1.7.1.1
On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
> The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
I've accumulated about 1,000 of these overnight. Seems to be consistently landing in
pairs based on the timestamps.
[42875.544006] WARNING: at lib/plist.c:57 plist_check_head+0x47/0x114()
[42875.544006] Hardware name: Latitude E6500
[42875.544006] Modules linked in: ppp_async sunrpc microcode usb_storage [last unloaded: scsi_wait_scan]
[42875.544006] Pid: 58070, comm: pulseaudio Tainted: G W 2.6.35-rc5-mmotm0719 #2
[42875.544006] Call Trace:
[42875.544006] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
[42875.544006] [<ffffffff81037362>] warn_slowpath_null+0x15/0x17
[42875.544006] [<ffffffff812051df>] plist_check_head+0x47/0x114
[42875.544006] [<ffffffff812052c7>] plist_add+0x1b/0xb1
[42875.544006] [<ffffffff81057b2e>] update_target+0x94/0xd0
[42875.544006] [<ffffffff81057d54>] pm_qos_add_request+0x79/0x7b
[42875.544006] [<ffffffff8141d199>] snd_pcm_hw_params+0x25a/0x28a
[42875.544006] [<ffffffff8141da29>] snd_pcm_common_ioctl1+0x23b/0x980
[42875.544006] [<ffffffff811c63db>] ? inode_has_perm.clone.18+0x92/0xa2
[42875.544006] [<ffffffff8141e613>] snd_pcm_playback_ioctl1+0x231/0x246
[42875.544006] [<ffffffff810d9178>] ? fd_install+0x36/0xd5
[42875.544006] [<ffffffff8141e652>] snd_pcm_playback_ioctl+0x2a/0x2e
[42875.544006] [<ffffffff810e91a0>] vfs_ioctl+0x31/0xa2
[42875.544006] [<ffffffff810e9b1f>] do_vfs_ioctl+0x496/0x4c9
[42875.544006] [<ffffffff810e9ba9>] sys_ioctl+0x57/0x96
[42875.544006] [<ffffffff8100272b>] system_call_fastpath+0x16/0x1b
[42875.544006] ---[ end trace 23d666d936caf587 ]---
[42875.544006] ------------[ cut here ]------------
[42875.544006] WARNING: at lib/plist.c:57 plist_check_head+0x47/0x114()
[42875.544006] Hardware name: Latitude E6500
[42875.544006] Modules linked in: ppp_async sunrpc microcode usb_storage [last unloaded: scsi_wait_scan]
[42875.544006] Pid: 58070, comm: pulseaudio Tainted: G W 2.6.35-rc5-mmotm0719 #2
[42875.544006] Call Trace:
[42875.544006] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
[42875.544006] [<ffffffff81037362>] warn_slowpath_null+0x15/0x17
[42875.544006] [<ffffffff812051df>] plist_check_head+0x47/0x114
[42875.544006] [<ffffffff81205354>] plist_add+0xa8/0xb1
[42875.544006] [<ffffffff81057b2e>] update_target+0x94/0xd0
[42875.544006] [<ffffffff81057d54>] pm_qos_add_request+0x79/0x7b
[42875.544006] [<ffffffff8141d199>] snd_pcm_hw_params+0x25a/0x28a
[42875.544006] [<ffffffff8141da29>] snd_pcm_common_ioctl1+0x23b/0x980
[42875.544006] [<ffffffff811c63db>] ? inode_has_perm.clone.18+0x92/0xa2
[42875.544006] [<ffffffff8141e613>] snd_pcm_playback_ioctl1+0x231/0x246
[42875.544006] [<ffffffff810d9178>] ? fd_install+0x36/0xd5
[42875.544006] [<ffffffff8141e652>] snd_pcm_playback_ioctl+0x2a/0x2e
[42875.544006] [<ffffffff810e91a0>] vfs_ioctl+0x31/0xa2
[42875.544006] [<ffffffff810e9b1f>] do_vfs_ioctl+0x496/0x4c9
[42875.544006] [<ffffffff810e9ba9>] sys_ioctl+0x57/0x96
[42875.544006] [<ffffffff8100272b>] system_call_fastpath+0x16/0x1b
[42875.544006] ---[ end trace 23d666d936caf588 ]---
[42882.427310] ------------[ cut here ]------------
[42882.428016] WARNING: at lib/plist.c:57 plist_check_head+0x47/0x114()
[42882.428016] Hardware name: Latitude E6500
[42882.428016] Modules linked in: ppp_async sunrpc microcode usb_storage [last unloaded: scsi_wait_scan]
[42882.428016] Pid: 58070, comm: pulseaudio Tainted: G W 2.6.35-rc5-mmotm0719 #2
[42882.428016] Call Trace:
[42882.428016] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
[42882.428016] [<ffffffff81037362>] warn_slowpath_null+0x15/0x17
[42882.428016] [<ffffffff812051df>] plist_check_head+0x47/0x114
[42882.428016] [<ffffffff8120537c>] plist_del+0x1f/0x8b
[42882.428016] [<ffffffff81057b21>] update_target+0x87/0xd0
[42882.428016] [<ffffffff81057bb6>] pm_qos_remove_request+0x4c/0x5c
[42882.428016] [<ffffffff8141dad9>] snd_pcm_common_ioctl1+0x2eb/0x980
[42882.428016] [<ffffffff811c63db>] ? inode_has_perm.clone.18+0x92/0xa2
[42882.428016] [<ffffffff8141e613>] snd_pcm_playback_ioctl1+0x231/0x246
[42882.428016] [<ffffffff8109589d>] ? trace_preempt_on+0x15/0x28
[42882.428016] [<ffffffff810c727e>] ? unmap_region+0xbd/0xcc
[42882.428016] [<ffffffff8141e652>] snd_pcm_playback_ioctl+0x2a/0x2e
[42882.428016] [<ffffffff810e91a0>] vfs_ioctl+0x31/0xa2
[42882.428016] [<ffffffff810e9b1f>] do_vfs_ioctl+0x496/0x4c9
[42882.428016] [<ffffffff810e9ba9>] sys_ioctl+0x57/0x96
[42882.428016] [<ffffffff810c746a>] ? unlink_file_vma+0x2d/0x4d
[42882.428016] [<ffffffff8100272b>] system_call_fastpath+0x16/0x1b
[42882.428016] ---[ end trace 23d666d936caf589 ]---
[42882.428016] ------------[ cut here ]------------
[42882.428016] WARNING: at lib/plist.c:57 plist_check_head+0x47/0x114()
[42882.428016] Hardware name: Latitude E6500
[42882.428016] Modules linked in: ppp_async sunrpc microcode usb_storage [last unloaded: scsi_wait_scan]
[42882.428016] Pid: 58070, comm: pulseaudio Tainted: G W 2.6.35-rc5-mmotm0719 #2
[42882.428016] Call Trace:
[42882.428016] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
[42882.428016] [<ffffffff81037362>] warn_slowpath_null+0x15/0x17
[42882.428016] [<ffffffff812051df>] plist_check_head+0x47/0x114
[42882.428016] [<ffffffff812053df>] plist_del+0x82/0x8b
[42882.428016] [<ffffffff81057b21>] update_target+0x87/0xd0
[42882.428016] [<ffffffff81057bb6>] pm_qos_remove_request+0x4c/0x5c
[42882.428016] [<ffffffff8141dad9>] snd_pcm_common_ioctl1+0x2eb/0x980
[42882.428016] [<ffffffff811c63db>] ? inode_has_perm.clone.18+0x92/0xa2
[42882.428016] [<ffffffff8141e613>] snd_pcm_playback_ioctl1+0x231/0x246
[42882.428016] [<ffffffff8109589d>] ? trace_preempt_on+0x15/0x28
[42882.428016] [<ffffffff810c727e>] ? unmap_region+0xbd/0xcc
[42882.428016] [<ffffffff8141e652>] snd_pcm_playback_ioctl+0x2a/0x2e
[42882.428016] [<ffffffff810e91a0>] vfs_ioctl+0x31/0xa2
[42882.428016] [<ffffffff810e9b1f>] do_vfs_ioctl+0x496/0x4c9
[42882.428016] [<ffffffff810e9ba9>] sys_ioctl+0x57/0x96
[42882.428016] [<ffffffff810c746a>] ? unlink_file_vma+0x2d/0x4d
[42882.428016] [<ffffffff8100272b>] system_call_fastpath+0x16/0x1b
[42882.428016] ---[ end trace 23d666d936caf58a ]---
On Wed, Jul 21, 2010 at 08:54:52AM -0400, [email protected] wrote:
> On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
> > The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
> >
> > http://userweb.kernel.org/~akpm/mmotm/
> I've accumulated about 1,000 of these overnight. Seems to be consistently landing in
> pairs based on the timestamps.
This looks like a problem I already reported to James, there's a fix
from him in -next already (folded into the original patch). It was a
generic problem in the PM QoS stuff when CONFIG_DEBUG_PI_LIST was
selected. See linux-pm for the discussion.
On Tue, Jul 20, 2010 at 02:07:51PM -0700, Andrew Morton wrote:
> On Tue, 20 Jul 2010 16:35:25 -0400
> [email protected] wrote:
>
> > On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
> > > The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
> > >
> > > http://userweb.kernel.org/~akpm/mmotm/
> >
> > Throws a warning at boot:
> >
> > [ 1.786060] WARNING: at kernel/pm_qos_params.c:264 pm_qos_update_request+0x28/0x54()
> > [ 1.786088] Hardware name: Latitude E6500
> > [ 1.787045] pm_qos_update_request() called for unknown object
> > [ 1.787966] Modules linked in:
> > [ 1.788940] Pid: 1, comm: swapper Not tainted 2.6.35-rc5-mmotm0719 #1
> > [ 1.790035] Call Trace:
> > [ 1.791121] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
> > [ 1.792205] [<ffffffff810373e1>] warn_slowpath_fmt+0x41/0x43
> > [ 1.793279] [<ffffffff81057c14>] pm_qos_update_request+0x28/0x54
> > [ 1.794347] [<ffffffff8134889e>] e1000_configure+0x421/0x459
> > [ 1.795393] [<ffffffff8134afbd>] e1000_open+0xbd/0x37c
> > [ 1.796436] [<ffffffff8105743a>] ? raw_notifier_call_chain+0xf/0x11
> > [ 1.797491] [<ffffffff8145f948>] __dev_open+0xae/0xe2
> > [ 1.798547] [<ffffffff8145f997>] dev_open+0x1b/0x49
> > [ 1.799612] [<ffffffff8146e36e>] netpoll_setup+0x84/0x259
> > [ 1.800685] [<ffffffff81b5037c>] init_netconsole+0xbc/0x21f
> > [ 1.801744] [<ffffffff81b5026c>] ? sir_wq_init+0x0/0x35
> > [ 1.802793] [<ffffffff81b502c0>] ? init_netconsole+0x0/0x21f
> > [ 1.803845] [<ffffffff810002ff>] do_one_initcall+0x7a/0x12f
> > [ 1.804885] [<ffffffff81b2ccae>] kernel_init+0x138/0x1c2
> > [ 1.805915] [<ffffffff81003554>] kernel_thread_helper+0x4/0x10
> > [ 1.806937] [<ffffffff81590e00>] ? restore_args+0x0/0x30
> > [ 1.807955] [<ffffffff81b2cb76>] ? kernel_init+0x0/0x1c2
> > [ 1.808958] [<ffffffff81003550>] ? kernel_thread_helper+0x0/0x10
> > [ 1.809958] ---[ end trace 84b562a00a60539e ]---
> >
> > Looks like a repeat of something I reported against -mmotm 2010-05-11, though a
> > WARNING rather than an outright crash - the traceback is pretty much identical.
> > I have *no* idea why -rc3-mmotm0701 doesn't whinge similarly.
> >
>
> I don't recall you reporting that, sorry.
>
> The warning was added by
>
> : commit 82f682514a5df89ffb3890627eebf0897b7a84ec
> : Author: James Bottomley <[email protected]>
> : AuthorDate: Mon Jul 5 22:53:06 2010 +0200
> : Commit: Rafael J. Wysocki <[email protected]>
> : CommitDate: Mon Jul 19 02:00:34 2010 +0200
> :
> : pm_qos: Get rid of the allocation in pm_qos_add_request()
>
>
> It's a pretty crappy warning too. Neither the warning nor the code
> comments provide developers with any hint as to what they have done
> wrong, nor what they must do to fix things. And the patch changelog
> doesn't mention the new warnings *at all*.
Sorry about that. Its my fault, but I thought I had stronger language
in the original warning text.
The warning is for pm_qos users that are attempting to change a request
that isn't even in the list of request. It was a silent failure in the
original code. The result of the silent fail is that the request is not
changed as assumed by the caller.
> So one must assume that the people who stuck this thing in the tree
> have volunteered to fix e1000e. Let's cc 'em.
I'll put a 1000e patch together at the airport, but I wont be able to
test it until tuesday.
--mgross
On Wed, Jul 21, 2010 at 09:12:00AM +0200, Florian Mickler wrote:
> On Tue, 20 Jul 2010 14:07:51 -0700
> Andrew Morton <[email protected]> wrote:
>
> > On Tue, 20 Jul 2010 16:35:25 -0400
> > [email protected] wrote:
> >
> > > On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
> > > > The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
> > > >
> > > > http://userweb.kernel.org/~akpm/mmotm/
> > >
> > > Throws a warning at boot:
> > >
> > > [ 1.786060] WARNING: at kernel/pm_qos_params.c:264 pm_qos_update_request+0x28/0x54()
> > > [ 1.786088] Hardware name: Latitude E6500
> > > [ 1.787045] pm_qos_update_request() called for unknown object
> > > [ 1.787966] Modules linked in:
> > > [ 1.788940] Pid: 1, comm: swapper Not tainted 2.6.35-rc5-mmotm0719 #1
> > > [ 1.790035] Call Trace:
> > > [ 1.791121] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
> > > [ 1.792205] [<ffffffff810373e1>] warn_slowpath_fmt+0x41/0x43
> > > [ 1.793279] [<ffffffff81057c14>] pm_qos_update_request+0x28/0x54
> > > [ 1.794347] [<ffffffff8134889e>] e1000_configure+0x421/0x459
> > > [ 1.795393] [<ffffffff8134afbd>] e1000_open+0xbd/0x37c
> > > [ 1.796436] [<ffffffff8105743a>] ? raw_notifier_call_chain+0xf/0x11
> > > [ 1.797491] [<ffffffff8145f948>] __dev_open+0xae/0xe2
> > > [ 1.798547] [<ffffffff8145f997>] dev_open+0x1b/0x49
> > > [ 1.799612] [<ffffffff8146e36e>] netpoll_setup+0x84/0x259
> > > [ 1.800685] [<ffffffff81b5037c>] init_netconsole+0xbc/0x21f
> > > [ 1.801744] [<ffffffff81b5026c>] ? sir_wq_init+0x0/0x35
> > > [ 1.802793] [<ffffffff81b502c0>] ? init_netconsole+0x0/0x21f
> > > [ 1.803845] [<ffffffff810002ff>] do_one_initcall+0x7a/0x12f
> > > [ 1.804885] [<ffffffff81b2ccae>] kernel_init+0x138/0x1c2
> > > [ 1.805915] [<ffffffff81003554>] kernel_thread_helper+0x4/0x10
> > > [ 1.806937] [<ffffffff81590e00>] ? restore_args+0x0/0x30
> > > [ 1.807955] [<ffffffff81b2cb76>] ? kernel_init+0x0/0x1c2
> > > [ 1.808958] [<ffffffff81003550>] ? kernel_thread_helper+0x0/0x10
> > > [ 1.809958] ---[ end trace 84b562a00a60539e ]---
> > >
> > > Looks like a repeat of something I reported against -mmotm 2010-05-11, though a
> > > WARNING rather than an outright crash - the traceback is pretty much identical.
> > > I have *no* idea why -rc3-mmotm0701 doesn't whinge similarly.
> > >
> >
> > I don't recall you reporting that, sorry.
> >
> > The warning was added by
> >
> > : commit 82f682514a5df89ffb3890627eebf0897b7a84ec
> > : Author: James Bottomley <[email protected]>
> > : AuthorDate: Mon Jul 5 22:53:06 2010 +0200
> > : Commit: Rafael J. Wysocki <[email protected]>
> > : CommitDate: Mon Jul 19 02:00:34 2010 +0200
> > :
> > : pm_qos: Get rid of the allocation in pm_qos_add_request()
> >
> >
> > It's a pretty crappy warning too. Neither the warning nor the code
> > comments provide developers with any hint as to what they have done
> > wrong, nor what they must do to fix things. And the patch changelog
> > doesn't mention the new warnings *at all*.
> >
> > So one must assume that the people who stuck this thing in the tree
> > have volunteered to fix e1000e. Let's cc 'em.
> >
>
> e1000 calls update_request before registering said request with pm_qos.
> This was silently ignored before but now emits a warning. The warning
> is sound, because it means, that the constraint-request didn't take
> effect.
>
> The right thing is probably to register the request before
> calling update_request.
>
> Attached patch moves the registering from e1000_up to e1000_open and
> the unregistering from e1000_down to e1000_close.
> It is only compile-tested as I don't have the hardware.
>
> Cheers,
> Flo
>
> p.s.: sorry if this get's mangled or is wrongly formatted, i'm just using
> the "insert file" option of my mailclient and crossing my fingers...
>
>
> From 693c71b911ff0845c872261d5704a1d40960722d Mon Sep 17 00:00:00 2001
> From: Florian Mickler <[email protected]>
> Date: Wed, 21 Jul 2010 08:44:21 +0200
> Subject: [PATCH] e1000e: register pm_qos request on hardware activation
>
> The pm_qos_add_request call has to register the pm_qos request with the pm_qos
> susbsystem before first use of the pm_qos request via
> pm_qos_update_request.
>
> As pm_qos changed to use plists there is no benefit in registering and
> unregistering the pm_qos request on ifup/ifdown and thus we move the
> registering into e1000_open and the unregistering in e1000_close.
>
> This fixes the following warning:
>
> [ 1.786060] WARNING: at kernel/pm_qos_params.c:264
> pm_qos_update_request+0x28/0x54()
> [ 1.786088] Hardware name: Latitude E6500
> [ 1.787045] pm_qos_update_request() called for unknown object
> [ 1.787966] Modules linked in:
> [ 1.788940] Pid: 1, comm: swapper Not tainted 2.6.35-rc5-mmotm0719 #1
> [ 1.790035] Call Trace:
> [ 1.791121] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
> [ 1.792205] [<ffffffff810373e1>] warn_slowpath_fmt+0x41/0x43
> [ 1.793279] [<ffffffff81057c14>] pm_qos_update_request+0x28/0x54
> [ 1.794347] [<ffffffff8134889e>] e1000_configure+0x421/0x459
> [ 1.795393] [<ffffffff8134afbd>] e1000_open+0xbd/0x37c
> [ 1.796436] [<ffffffff8105743a>] ? raw_notifier_call_chain+0xf/0x11
> [ 1.797491] [<ffffffff8145f948>] __dev_open+0xae/0xe2
> [ 1.798547] [<ffffffff8145f997>] dev_open+0x1b/0x49
> [ 1.799612] [<ffffffff8146e36e>] netpoll_setup+0x84/0x259
> [ 1.800685] [<ffffffff81b5037c>] init_netconsole+0xbc/0x21f
> [ 1.801744] [<ffffffff81b5026c>] ? sir_wq_init+0x0/0x35
> [ 1.802793] [<ffffffff81b502c0>] ? init_netconsole+0x0/0x21f
> [ 1.803845] [<ffffffff810002ff>] do_one_initcall+0x7a/0x12f
> [ 1.804885] [<ffffffff81b2ccae>] kernel_init+0x138/0x1c2
> [ 1.805915] [<ffffffff81003554>] kernel_thread_helper+0x4/0x10
> [ 1.806937] [<ffffffff81590e00>] ? restore_args+0x0/0x30
> [ 1.807955] [<ffffffff81b2cb76>] ? kernel_init+0x0/0x1c2
> [ 1.808958] [<ffffffff81003550>] ? kernel_thread_helper+0x0/0x10
> [ 1.809958] ---[ end trace 84b562a00a60539e ]---
>
> Signed-off-by: Florian Mickler <[email protected]>
> ---
> drivers/net/e1000e/netdev.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
> index 8ba366a..1bd9054 100644
> --- a/drivers/net/e1000e/netdev.c
> +++ b/drivers/net/e1000e/netdev.c
> @@ -3218,12 +3218,6 @@ int e1000e_up(struct e1000_adapter *adapter)
> {
> struct e1000_hw *hw = &adapter->hw;
>
> - /* DMA latency requirement to workaround early-receive/jumbo issue */
> - if (adapter->flags & FLAG_HAS_ERT)
> - pm_qos_add_request(&adapter->netdev->pm_qos_req,
> - PM_QOS_CPU_DMA_LATENCY,
> - PM_QOS_DEFAULT_VALUE);
> -
> /* hardware has been reset, we need to reload some things */
> e1000_configure(adapter);
>
> @@ -3287,9 +3281,6 @@ void e1000e_down(struct e1000_adapter *adapter)
> e1000_clean_tx_ring(adapter);
> e1000_clean_rx_ring(adapter);
>
> - if (adapter->flags & FLAG_HAS_ERT)
> - pm_qos_remove_request(&adapter->netdev->pm_qos_req);
> -
> /*
> * TODO: for power management, we could drop the link and
> * pci_disable_device here.
> @@ -3524,6 +3515,12 @@ static int e1000_open(struct net_device *netdev)
> E1000_MNG_DHCP_COOKIE_STATUS_VLAN))
> e1000_update_mng_vlan(adapter);
>
> + /* DMA latency requirement to workaround early-receive/jumbo issue */
> + if (adapter->flags & FLAG_HAS_ERT)
> + pm_qos_add_request(&adapter->netdev->pm_qos_req,
> + PM_QOS_CPU_DMA_LATENCY,
> + PM_QOS_DEFAULT_VALUE);
> +
> /*
> * before we allocate an interrupt, we must be ready to handle it.
> * Setting DEBUG_SHIRQ in the kernel makes it fire an interrupt
> @@ -3628,6 +3625,9 @@ static int e1000_close(struct net_device *netdev)
> if (adapter->flags & FLAG_HAS_AMT)
> e1000_release_hw_control(adapter);
>
> + if (adapter->flags & FLAG_HAS_ERT)
> + pm_qos_remove_request(&adapter->netdev->pm_qos_req);
> +
> pm_runtime_put_sync(&pdev->dev);
>
> return 0;
> --
> 1.7.1.1
>
wow! thanks! I'll test this when I get back next tuesday.
--mgross
On Wed, 21 Jul 2010 09:12:00 +0200, Florian Mickler said:
> Attached patch moves the registering from e1000_up to e1000_open and
> the unregistering from e1000_down to e1000_close.
> It is only compile-tested as I don't have the hardware.
My laptop has the hardware, so I tested it - system does indeed boot
without whinging about this issue. Feel free to stick in a:
Tested-by: Valdis Kletnieks <[email protected]>
Thanks for the fast fix. :)
> From 693c71b911ff0845c872261d5704a1d40960722d Mon Sep 17 00:00:00 2001
> From: Florian Mickler <[email protected]>
> Date: Wed, 21 Jul 2010 08:44:21 +0200
> Subject: [PATCH] e1000e: register pm_qos request on hardware activation
>
> The pm_qos_add_request call has to register the pm_qos request with the pm_qos
> susbsystem before first use of the pm_qos request via
> pm_qos_update_request.
>
> As pm_qos changed to use plists there is no benefit in registering and
> unregistering the pm_qos request on ifup/ifdown and thus we move the
> registering into e1000_open and the unregistering in e1000_close.
On Thursday, July 22, 2010, [email protected] wrote:
> On Wed, 21 Jul 2010 09:12:00 +0200, Florian Mickler said:
>
> > Attached patch moves the registering from e1000_up to e1000_open and
> > the unregistering from e1000_down to e1000_close.
> > It is only compile-tested as I don't have the hardware.
>
> My laptop has the hardware, so I tested it - system does indeed boot
> without whinging about this issue. Feel free to stick in a:
>
> Tested-by: Valdis Kletnieks <[email protected]>
>
> Thanks for the fast fix. :)
I'm going to add the patch to the suspend-2.6 tree. Any objections?
> > From 693c71b911ff0845c872261d5704a1d40960722d Mon Sep 17 00:00:00 2001
> > From: Florian Mickler <[email protected]>
> > Date: Wed, 21 Jul 2010 08:44:21 +0200
> > Subject: [PATCH] e1000e: register pm_qos request on hardware activation
> >
> > The pm_qos_add_request call has to register the pm_qos request with the pm_qos
> > susbsystem before first use of the pm_qos request via
> > pm_qos_update_request.
> >
> > As pm_qos changed to use plists there is no benefit in registering and
> > unregistering the pm_qos request on ifup/ifdown and thus we move the
> > registering into e1000_open and the unregistering in e1000_close.
Rafael
On Wed, Jul 21, 2010 at 00:12, Florian Mickler <[email protected]> wrote:
> On Tue, 20 Jul 2010 14:07:51 -0700
> Andrew Morton <[email protected]> wrote:
>
>> On Tue, 20 Jul 2010 16:35:25 -0400
>> [email protected] wrote:
>>
>> > On Mon, 19 Jul 2010 16:38:09 PDT, [email protected] said:
>> > > The mm-of-the-moment snapshot 2010-07-19-16-37 has been uploaded to
>> > >
>> > > http://userweb.kernel.org/~akpm/mmotm/
>> >
>> > Throws a warning at boot:
>> >
>> > [ 1.786060] WARNING: at kernel/pm_qos_params.c:264 pm_qos_update_request+0x28/0x54()
>> > [ 1.786088] Hardware name: Latitude E6500
>> > [ 1.787045] pm_qos_update_request() called for unknown object
>> > [ 1.787966] Modules linked in:
>> > [ 1.788940] Pid: 1, comm: swapper Not tainted 2.6.35-rc5-mmotm0719 #1
>> > [ 1.790035] Call Trace:
>> > [ 1.791121] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
>> > [ 1.792205] [<ffffffff810373e1>] warn_slowpath_fmt+0x41/0x43
>> > [ 1.793279] [<ffffffff81057c14>] pm_qos_update_request+0x28/0x54
>> > [ 1.794347] [<ffffffff8134889e>] e1000_configure+0x421/0x459
>> > [ 1.795393] [<ffffffff8134afbd>] e1000_open+0xbd/0x37c
>> > [ 1.796436] [<ffffffff8105743a>] ? raw_notifier_call_chain+0xf/0x11
>> > [ 1.797491] [<ffffffff8145f948>] __dev_open+0xae/0xe2
>> > [ 1.798547] [<ffffffff8145f997>] dev_open+0x1b/0x49
>> > [ 1.799612] [<ffffffff8146e36e>] netpoll_setup+0x84/0x259
>> > [ 1.800685] [<ffffffff81b5037c>] init_netconsole+0xbc/0x21f
>> > [ 1.801744] [<ffffffff81b5026c>] ? sir_wq_init+0x0/0x35
>> > [ 1.802793] [<ffffffff81b502c0>] ? init_netconsole+0x0/0x21f
>> > [ 1.803845] [<ffffffff810002ff>] do_one_initcall+0x7a/0x12f
>> > [ 1.804885] [<ffffffff81b2ccae>] kernel_init+0x138/0x1c2
>> > [ 1.805915] [<ffffffff81003554>] kernel_thread_helper+0x4/0x10
>> > [ 1.806937] [<ffffffff81590e00>] ? restore_args+0x0/0x30
>> > [ 1.807955] [<ffffffff81b2cb76>] ? kernel_init+0x0/0x1c2
>> > [ 1.808958] [<ffffffff81003550>] ? kernel_thread_helper+0x0/0x10
>> > [ 1.809958] ---[ end trace 84b562a00a60539e ]---
>> >
>> > Looks like a repeat of something I reported against -mmotm 2010-05-11, though a
>> > WARNING rather than an outright crash - the traceback is pretty much identical.
>> > I have *no* idea why -rc3-mmotm0701 doesn't whinge similarly.
>> >
>>
>> I don't recall you reporting that, sorry.
>>
>> The warning was added by
>>
>> : commit 82f682514a5df89ffb3890627eebf0897b7a84ec
>> : Author: James Bottomley <[email protected]>
>> : AuthorDate: Mon Jul 5 22:53:06 2010 +0200
>> : Commit: Rafael J. Wysocki <[email protected]>
>> : CommitDate: Mon Jul 19 02:00:34 2010 +0200
>> :
>> : pm_qos: Get rid of the allocation in pm_qos_add_request()
>>
>>
>> It's a pretty crappy warning too. Neither the warning nor the code
>> comments provide developers with any hint as to what they have done
>> wrong, nor what they must do to fix things. And the patch changelog
>> doesn't mention the new warnings *at all*.
>>
>> So one must assume that the people who stuck this thing in the tree
>> have volunteered to fix e1000e. Let's cc 'em.
>>
>
> e1000 calls update_request before registering said request with pm_qos.
> This was silently ignored before but now emits a warning. The warning
> is sound, because it means, that the constraint-request didn't take
> effect.
>
> The right thing is probably to register the request before
> calling update_request.
>
> Attached patch moves the registering from e1000_up to e1000_open and
> the unregistering from e1000_down to e1000_close.
> It is only compile-tested as I don't have the hardware.
>
> Cheers,
> Flo
>
> p.s.: sorry if this get's mangled or is wrongly formatted, i'm just using
> the "insert file" option of my mailclient and crossing my fingers...
>
>
> From 693c71b911ff0845c872261d5704a1d40960722d Mon Sep 17 00:00:00 2001
> From: Florian Mickler <[email protected]>
> Date: Wed, 21 Jul 2010 08:44:21 +0200
> Subject: [PATCH] e1000e: register pm_qos request on hardware activation
>
> The pm_qos_add_request call has to register the pm_qos request with the pm_qos
> susbsystem before first use of the pm_qos request via
> pm_qos_update_request.
>
> As pm_qos changed to use plists there is no benefit in registering and
> unregistering the pm_qos request on ifup/ifdown and thus we move the
> registering into e1000_open and the unregistering in e1000_close.
>
> This fixes the following warning:
>
> [ 1.786060] WARNING: at kernel/pm_qos_params.c:264
> pm_qos_update_request+0x28/0x54()
> [ 1.786088] Hardware name: Latitude E6500
> [ 1.787045] pm_qos_update_request() called for unknown object
> [ 1.787966] Modules linked in:
> [ 1.788940] Pid: 1, comm: swapper Not tainted 2.6.35-rc5-mmotm0719 #1
> [ 1.790035] Call Trace:
> [ 1.791121] [<ffffffff81037335>] warn_slowpath_common+0x80/0x98
> [ 1.792205] [<ffffffff810373e1>] warn_slowpath_fmt+0x41/0x43
> [ 1.793279] [<ffffffff81057c14>] pm_qos_update_request+0x28/0x54
> [ 1.794347] [<ffffffff8134889e>] e1000_configure+0x421/0x459
> [ 1.795393] [<ffffffff8134afbd>] e1000_open+0xbd/0x37c
> [ 1.796436] [<ffffffff8105743a>] ? raw_notifier_call_chain+0xf/0x11
> [ 1.797491] [<ffffffff8145f948>] __dev_open+0xae/0xe2
> [ 1.798547] [<ffffffff8145f997>] dev_open+0x1b/0x49
> [ 1.799612] [<ffffffff8146e36e>] netpoll_setup+0x84/0x259
> [ 1.800685] [<ffffffff81b5037c>] init_netconsole+0xbc/0x21f
> [ 1.801744] [<ffffffff81b5026c>] ? sir_wq_init+0x0/0x35
> [ 1.802793] [<ffffffff81b502c0>] ? init_netconsole+0x0/0x21f
> [ 1.803845] [<ffffffff810002ff>] do_one_initcall+0x7a/0x12f
> [ 1.804885] [<ffffffff81b2ccae>] kernel_init+0x138/0x1c2
> [ 1.805915] [<ffffffff81003554>] kernel_thread_helper+0x4/0x10
> [ 1.806937] [<ffffffff81590e00>] ? restore_args+0x0/0x30
> [ 1.807955] [<ffffffff81b2cb76>] ? kernel_init+0x0/0x1c2
> [ 1.808958] [<ffffffff81003550>] ? kernel_thread_helper+0x0/0x10
> [ 1.809958] ---[ end trace 84b562a00a60539e ]---
>
> Signed-off-by: Florian Mickler <[email protected]>
> ---
> drivers/net/e1000e/netdev.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
Thanks I have added the patch to my queue.
--
Cheers,
Jeff
Em 20-07-2010 18:41, Jarod Wilson escreveu:
> On Tue, Jul 20, 2010 at 05:11:40PM -0400, [email protected] wrote:
>> On Tue, 20 Jul 2010 13:50:27 PDT, Dmitry Torokhov said:
>>
>>>> And things go downhill from there...
>>>
>>> I guess you need these 2 from Jarod...
>>
>> Hmm. I seem to remember 2 similar patches from the last time I reported it. :)
>>
>> System boots fine after applying those two patches. I'll let somebody else
>> worry about making sure they end up in linux-next in time for the next merge
>> window...
>
> I believe Mauro's on vacation at the moment, but due back Real Soon Now,
> and I'd expect him to pick up both fixes shortly after he settles back in
> at his desk, so they should be in next before much longer, and definitely
> before the merge window.
I just arrived from vacations. I'll be testing this patch and applying it if OK.
Just give me some days, since I have a huge backlog due to vacations.
Cheers,
Mauro.