2013-03-12 22:13:53

by Geert Uytterhoeven

[permalink] [raw]
Subject: [-next] staging/comedi regressions

m68k/allmodconfig:

drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’:
drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’
undeclared (first use in this function)
drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared
identifier is reported only once
drivers/staging/comedi/drivers/ni_atmio.c:353: error: for each
function it appears in.)
drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_getboardtype’:
drivers/staging/comedi/drivers/ni_atmio.c:391: error: ‘n_ni_boards’
undeclared (first use in this function)
drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_atmio_attach’:
drivers/staging/comedi/drivers/ni_atmio.c:470: error: ‘boardtype’
undeclared (first use in this function)

http://kisskb.ellerman.id.au/kisskb/buildresult/8392062/

Seems like the following two commits removed some macros:

commit 6293e35742550320b1720044f9969d9544a5deaa
Author: H Hartley Sweeten <[email protected]>
Date: Tue Mar 5 10:20:41 2013 -0700

staging: comedi: ni_stc.h: remove boardtype macro

ayla$ git show f5a1d92bf6f4fa063d5ea43613f43494896e333f
commit f5a1d92bf6f4fa063d5ea43613f43494896e333f
Author: H Hartley Sweeten <[email protected]>
Date: Tue Mar 5 10:21:03 2013 -0700

staging: comedi: ni_stc.h: remove n_ni_boards macro

while they're still used by drivers/staging/comedi/drivers/ni_atmio.c.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2013-03-12 22:21:38

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [-next] staging/comedi regressions

On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote:
> m68k/allmodconfig:
>
> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’:
> drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’
> undeclared (first use in this function)
> drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared
> identifier is reported only once
> drivers/staging/comedi/drivers/ni_atmio.c:353: error: for each
> function it appears in.)
> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_getboardtype’:
> drivers/staging/comedi/drivers/ni_atmio.c:391: error: ‘n_ni_boards’
> undeclared (first use in this function)
> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_atmio_attach’:
> drivers/staging/comedi/drivers/ni_atmio.c:470: error: ‘boardtype’
> undeclared (first use in this function)
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/8392062/

Hartley already fixed it, this will show up in the next linux-next tree
as I commited the fix a few hours ago.

thanks,

greg k-h

2013-03-14 19:33:32

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [-next] staging/comedi regressions

On Tue, Mar 12, 2013 at 11:21 PM, Greg Kroah-Hartman
<[email protected]> wrote:
> On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote:
>> m68k/allmodconfig:
>>
>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’:
>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’
>> undeclared (first use in this function)
>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared
>> identifier is reported only once
>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: for each
>> function it appears in.)
>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_getboardtype’:
>> drivers/staging/comedi/drivers/ni_atmio.c:391: error: ‘n_ni_boards’
>> undeclared (first use in this function)
>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_atmio_attach’:
>> drivers/staging/comedi/drivers/ni_atmio.c:470: error: ‘boardtype’
>> undeclared (first use in this function)
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/8392062/
>
> Hartley already fixed it, this will show up in the next linux-next tree
> as I commited the fix a few hours ago.

Thanks, but now it fails differently:

http://kisskb.ellerman.id.au/kisskb/buildresult/8398995/
drivers/staging/comedi/drivers/ni_atmio.c:472:2: error: expected ';'
before 'printk'

There's a semicolon missing on the previous line.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2013-03-14 20:36:58

by Hartley Sweeten

[permalink] [raw]
Subject: RE: [-next] staging/comedi regressions

On Thursday, March 14, 2013 12:33 PM, Geert Uytterhoeven wrote:
> On Tue, Mar 12, 2013 at 11:21 PM, Greg Kroah-Hartman <[email protected]> wrote:
>> On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote:
>>> m68k/allmodconfig:
>>>
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’:
>>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’
>>> undeclared (first use in this function)
>>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared
>>> identifier is reported only once
>>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: for each
>>> function it appears in.)
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_getboardtype’:
>>> drivers/staging/comedi/drivers/ni_atmio.c:391: error: ‘n_ni_boards’
>>> undeclared (first use in this function)
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_atmio_attach’:
>>> drivers/staging/comedi/drivers/ni_atmio.c:470: error: ‘boardtype’
>>> undeclared (first use in this function)
>>>
>>> http://kisskb.ellerman.id.au/kisskb/buildresult/8392062/
>>
>> Hartley already fixed it, this will show up in the next linux-next tree
>> as I commited the fix a few hours ago.
>
> Thanks, but now it fails differently:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/8398995/
> drivers/staging/comedi/drivers/ni_atmio.c:472:2: error: expected ';'
> before 'printk'
>
> There's a semicolon missing on the previous line.

Grrr... Sorry about that.

Patch coming in a minute.

Regards,
Hartley

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?