2013-03-15 08:15:09

by Kumar Amit Mehta

Subject: [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon

fix a missing end-of-statement by adding a semicolon.

Signed-off-by: Kumar Amit Mehta <[email protected]>
---
drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
index 279f2cd..37372a1 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -467,7 +467,7 @@ static int ni_atmio_attach(struct comedi_device *dev,
return -EIO;

dev->board_ptr = ni_boards + board;
- boardtype = comedi_board(dev)
+ boardtype = comedi_board(dev);

printk(" %s", boardtype->name);
dev->board_name = boardtype->name;
--
1.7.9.5

2013-03-15 09:41:14

by Ian Abbott

Subject: Re: [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon

On 2013-03-15 08:14, Kumar Amit Mehta wrote:
> fix a missing end-of-statement by adding a semicolon.
>
> Signed-off-by: Kumar Amit Mehta <[email protected]>
> ---
> drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
> index 279f2cd..37372a1 100644
> --- a/drivers/staging/comedi/drivers/ni_atmio.c
> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
> @@ -467,7 +467,7 @@ static int ni_atmio_attach(struct comedi_device *dev,
> return -EIO;
>
> dev->board_ptr = ni_boards + board;
> - boardtype = comedi_board(dev)
> + boardtype = comedi_board(dev);
>
> printk(" %s", boardtype->name);
> dev->board_name = boardtype->name;

Ironically, that was introduced by a patch titled "staging: comedi:
ni_atmio: fix build errors". :-)

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-

2013-03-15 16:05:08

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon

On Fri, Mar 15, 2013 at 01:14:29AM -0700, Kumar Amit Mehta wrote:
> fix a missing end-of-statement by adding a semicolon.
>
> Signed-off-by: Kumar Amit Mehta <[email protected]>
> ---
> drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Hartley sent a fix for this yesterday, sorry about not applying it
sooner.

greg k-h

2013-03-15 16:10:08

by Hartley Sweeten

Subject: RE: [PATCH] staging: comedi: drivers: ni_atmio.c: Add a missing semicolon

On Friday, March 15, 2013 2:41 AM, Ian Abbott wrote:
> On 2013-03-15 08:14, Kumar Amit Mehta wrote:
>> fix a missing end-of-statement by adding a semicolon.
>>
>> Signed-off-by: Kumar Amit Mehta <[email protected]>
>> ---
>> drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
>> index 279f2cd..37372a1 100644
>> --- a/drivers/staging/comedi/drivers/ni_atmio.c
>> +++ b/drivers/staging/comedi/drivers/ni_atmio.c
>> @@ -467,7 +467,7 @@ static int ni_atmio_attach(struct comedi_device *dev,
>> return -EIO;
>>
>> dev->board_ptr = ni_boards + board;
>> - boardtype = comedi_board(dev)
>> + boardtype = comedi_board(dev);
>>
>> printk(" %s", boardtype->name);
>> dev->board_name = boardtype->name;
>
> Ironically, that was introduced by a patch titled "staging: comedi:
> ni_atmio: fix build errors". :-)

My only excuse is that the coffee machine was broken...

Actually, I just realized that this driver as well as the others that depend
on ISAPNP were not being compiled on my Debian 6.0 64bit system . I
hacked my config to build the ones that depend on ISA but missed the
ISAPNP ones.

Sorry about the trouble.

Hartley