2018-02-18 18:08:40

by Mykola Golub

[permalink] [raw]
Subject: nbd: on-the-fly resize does not work any more

Hi,

It looks like after the recent changes to nbd driver, on-the-fly
resize has stopped working for rbd-nbd. Particularly this change [1]
breaks how NBD_SET_SIZE is used for rbd-nbd on-the-fly resize [2].

Could this be fixed?

[1] https://github.com/torvalds/linux/commit/639812a1ed9bf49ae2c026086fbf975339cd1eef
[2] https://github.com/ceph/ceph/blob/483f14c/src/tools/rbd_nbd/rbd-nbd.cc#L488

--
Mykola Golub


2018-02-19 19:07:22

by Josef Bacik

[permalink] [raw]
Subject: Re: nbd: on-the-fly resize does not work any more

Yeah I fucked that up, I’ll fix it when I’m back from holiday tomorrow. Thanks,

Josef

Sent from my iPhone

> On Feb 18, 2018, at 1:08 PM, Mykola Golub <[email protected]> wrote:
>
> Hi,
>
> It looks like after the recent changes to nbd driver, on-the-fly
> resize has stopped working for rbd-nbd. Particularly this change [1]
> breaks how NBD_SET_SIZE is used for rbd-nbd on-the-fly resize [2].
>
> Could this be fixed?
>
> [1] https://github.com/torvalds/linux/commit/639812a1ed9bf49ae2c026086fbf975339cd1eef
> [2] https://github.com/ceph/ceph/blob/483f14c/src/tools/rbd_nbd/rbd-nbd.cc#L488
>
> --
> Mykola Golub