2020-04-19 09:06:55

by Markus Elfring

Subject: Re: [PATCH] drm/amdgpu: Reduce a lock scope in amdgpu_amdkfd_gpuvm_free_memory_of_gpu()

> Maybe we could reduce the mutex_lock(&mem->lock)`s protected code area,
> and noneed to protect pr_debug.

I suggest to improve the commit message.
Would you like to adjust the patch subject?

Do you imagine that data synchronisation should evolve in other ways?

Regards,
Markus

2020-04-20 01:02:02

by 赵军奎

Subject: Re:Re: [PATCH] drm/amdgpu: Reduce a lock scope in amdgpu_amdkfd_gpuvm_free_memory_of_gpu()

From: Markus Elfring <[email protected]>
Date: 2020-04-19 17:05:07
To: Bernard Zhao <[email protected]>,[email protected],[email protected],Alex Deucher <[email protected]>,"Christian König" <[email protected]>,Chunming Zhou <[email protected]>,"Felix Kühling" <[email protected]>
Cc: [email protected],[email protected],Daniel Vetter <[email protected]>,David Airlie <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: Reduce a lock scope in amdgpu_amdkfd_gpuvm_free_memory_of_gpu()>> Maybe we could reduce the mutex_lock(&mem->lock)`s protected code area,
>> and noneed to protect pr_debug.
>
>I suggest to improve the commit message.
>Would you like to adjust the patch subject?
>
>Do you imagine that data synchronisation should evolve in other ways?
>
>Regards,
>Markus

Sure, I will modify the code and adjust this patch subject. I will submit it again.